Re: [PATCH v2] clk: fixed-rate: Use "clock-output-names" to name fixed clocks

2025-04-25 Thread Marek Vasut
On 4/25/25 3:55 PM, Fabio Estevam wrote: On Fri, Apr 25, 2025 at 9:55 AM Fabio Estevam wrote: With the top-of-tree U-Boot, SPL calculates the wrong sdhc_clk on the imx8mm-evk: U-Boot SPL 2025.04-01380-ga9820e12db18-dirty (Apr 25 2025 - 09:40:45 -0300) No pmic WDT: Started watchdog@3028

Re: [PATCH v2] clk: fixed-rate: Use "clock-output-names" to name fixed clocks

2025-04-25 Thread Marek Vasut
On 4/25/25 2:55 PM, Fabio Estevam wrote: On Thu, Apr 24, 2025 at 11:35 PM Fabio Estevam wrote: I haven't had a chance to debug this issue yet. I applied this debug patch: --- a/drivers/mmc/fsl_esdhc_imx.c +++ b/drivers/mmc/fsl_esdhc_imx.c @@ -1539,6 +1539,7 @@ static int fsl_esdhc_probe(str

Re: [PATCH v2] clk: fixed-rate: Use "clock-output-names" to name fixed clocks

2025-04-25 Thread Fabio Estevam
On Fri, Apr 25, 2025 at 9:55 AM Fabio Estevam wrote: > With the top-of-tree U-Boot, SPL calculates the wrong sdhc_clk on the > imx8mm-evk: > > U-Boot SPL 2025.04-01380-ga9820e12db18-dirty (Apr 25 2025 - 09:40:45 -0300) > No pmic > WDT: Started watchdog@3028 with servicing every 1000ms (60s

Re: [PATCH v2] clk: fixed-rate: Use "clock-output-names" to name fixed clocks

2025-04-25 Thread Fabio Estevam
On Thu, Apr 24, 2025 at 11:35 PM Fabio Estevam wrote: > I haven't had a chance to debug this issue yet. I applied this debug patch: --- a/drivers/mmc/fsl_esdhc_imx.c +++ b/drivers/mmc/fsl_esdhc_imx.c @@ -1539,6 +1539,7 @@ static int fsl_esdhc_probe(struct udevice *dev) } priv->

Re: [PATCH v2] clk: fixed-rate: Use "clock-output-names" to name fixed clocks

2025-04-24 Thread Adam Ford
On Thu, Apr 24, 2025 at 9:37 PM Adam Ford wrote: > > On Thu, Apr 24, 2025 at 9:35 PM Fabio Estevam wrote: > > > > On Thu, Apr 24, 2025 at 11:20 PM Marek Vasut wrote: > > > > > Probably some timeout in the esdhc driver, maybe some clock are not > > > enabled ? I don't see it on the MX8MP. > > > >

Re: [PATCH v2] clk: fixed-rate: Use "clock-output-names" to name fixed clocks

2025-04-24 Thread Adam Ford
On Thu, Apr 24, 2025 at 9:35 PM Fabio Estevam wrote: > > On Thu, Apr 24, 2025 at 11:20 PM Marek Vasut wrote: > > > Probably some timeout in the esdhc driver, maybe some clock are not > > enabled ? I don't see it on the MX8MP. > > Same here. I didn't see this error on an imx8mp-evk. If memory ser

Re: [PATCH v2] clk: fixed-rate: Use "clock-output-names" to name fixed clocks

2025-04-24 Thread Fabio Estevam
On Thu, Apr 24, 2025 at 11:20 PM Marek Vasut wrote: > Probably some timeout in the esdhc driver, maybe some clock are not > enabled ? I don't see it on the MX8MP. Same here. I didn't see this error on an imx8mp-evk. > > Did you already apply > Re: [PATCH] clk: imx: Finish converting clock-osc-2

Re: [PATCH v2] clk: fixed-rate: Use "clock-output-names" to name fixed clocks

2025-04-24 Thread Marek Vasut
On 4/25/25 4:02 AM, Fabio Estevam wrote: Hi Marek, On Sun, Apr 20, 2025 at 4:20 PM Marek Vasut wrote: Can you send that as a fix ? And also, fix this patch up and drop the bogus second half of the commit message and do a V3. Sorry for the delay. I found another issue on an imx8mm-evk boar

Re: [PATCH v2] clk: fixed-rate: Use "clock-output-names" to name fixed clocks

2025-04-24 Thread Fabio Estevam
Hi Marek, On Sun, Apr 20, 2025 at 4:20 PM Marek Vasut wrote: > Can you send that as a fix ? > > And also, fix this patch up and drop the bogus second half of the commit > message and do a V3. Sorry for the delay. I found another issue on an imx8mm-evk board. U-Boot SPL 2025.04-01379-g10f48365

Re: [PATCH v2] clk: fixed-rate: Use "clock-output-names" to name fixed clocks

2025-04-21 Thread Adam Ford
On Sun, Apr 20, 2025 at 2:20 PM Marek Vasut wrote: > > On 4/20/25 3:07 AM, Fabio Estevam wrote: > > On Sat, Apr 19, 2025 at 9:48 PM Marek Vasut wrote: > > > >> Try something like this (also attached), maybe this needs to be made > >> generic ? Thanks for doing this. > > > > It works for me: > >

Re: [PATCH v2] clk: fixed-rate: Use "clock-output-names" to name fixed clocks

2025-04-20 Thread Marek Vasut
On 4/20/25 3:07 AM, Fabio Estevam wrote: On Sat, Apr 19, 2025 at 9:48 PM Marek Vasut wrote: Try something like this (also attached), maybe this needs to be made generic ? It works for me: Tested-by: Fabio Estevam Can you send that as a fix ? And also, fix this patch up and drop the bogu

Re: [PATCH v2] clk: fixed-rate: Use "clock-output-names" to name fixed clocks

2025-04-19 Thread Fabio Estevam
On Sat, Apr 19, 2025 at 9:48 PM Marek Vasut wrote: > Try something like this (also attached), maybe this needs to be made > generic ? It works for me: Tested-by: Fabio Estevam

Re: [PATCH v2] clk: fixed-rate: Use "clock-output-names" to name fixed clocks

2025-04-19 Thread Marek Vasut
On 4/19/25 10:40 PM, Adam Ford wrote: On Sat, Apr 19, 2025 at 2:12 PM Fabio Estevam wrote: Hi Marek, On Fri, Apr 18, 2025 at 11:53 AM Marek Vasut wrote: The "clock-output-names" is NEVER used for any clock look up. In Linux, "clock-output-names" is used to register the name of the fixed-

Re: [PATCH v2] clk: fixed-rate: Use "clock-output-names" to name fixed clocks

2025-04-19 Thread Marek Vasut
On 4/19/25 9:11 PM, Fabio Estevam wrote: Hi Marek, On Fri, Apr 18, 2025 at 11:53 AM Marek Vasut wrote: The "clock-output-names" is NEVER used for any clock look up. In Linux, "clock-output-names" is used to register the name of the fixed-rate clock. From Linux drivers/clk/clk-fixed-rate.c

Re: [PATCH v2] clk: fixed-rate: Use "clock-output-names" to name fixed clocks

2025-04-19 Thread Marek Vasut
On 4/19/25 2:59 PM, Adam Ford wrote: On Fri, Apr 18, 2025 at 9:53 AM Marek Vasut wrote: On 4/17/25 7:11 PM, Fabio Estevam wrote: From: Fabio Estevam Currently, fixed-rate clocks in U-Boot are named based on their devicetree node names. For example, given the following node: osc_24m: clock-

Re: [PATCH v2] clk: fixed-rate: Use "clock-output-names" to name fixed clocks

2025-04-19 Thread Adam Ford
On Sat, Apr 19, 2025 at 2:12 PM Fabio Estevam wrote: > > Hi Marek, > > On Fri, Apr 18, 2025 at 11:53 AM Marek Vasut wrote: > > > The "clock-output-names" is NEVER used for any clock look up. > > In Linux, "clock-output-names" is used to register the name of the > fixed-rate clock. > > From Linux

Re: [PATCH v2] clk: fixed-rate: Use "clock-output-names" to name fixed clocks

2025-04-19 Thread Fabio Estevam
Hi Marek, On Fri, Apr 18, 2025 at 11:53 AM Marek Vasut wrote: > The "clock-output-names" is NEVER used for any clock look up. In Linux, "clock-output-names" is used to register the name of the fixed-rate clock. >From Linux drivers/clk/clk-fixed-rate.c: ``` static struct clk_hw *_of_fixed_clk_

Re: [PATCH v2] clk: fixed-rate: Use "clock-output-names" to name fixed clocks

2025-04-19 Thread Adam Ford
On Fri, Apr 18, 2025 at 9:53 AM Marek Vasut wrote: > > On 4/17/25 7:11 PM, Fabio Estevam wrote: > > From: Fabio Estevam > > > > Currently, fixed-rate clocks in U-Boot are named based on their devicetree > > node names. For example, given the following node: > > > > osc_24m: clock-osc-24m { > >

Re: [PATCH v2] clk: fixed-rate: Use "clock-output-names" to name fixed clocks

2025-04-18 Thread Marek Vasut
On 4/17/25 7:11 PM, Fabio Estevam wrote: From: Fabio Estevam Currently, fixed-rate clocks in U-Boot are named based on their devicetree node names. For example, given the following node: osc_24m: clock-osc-24m { compatible = "fixed-clock"; #clock-cells = <0>; clock-freq