Re: [PATCH v1 5/6] treewide: Add a function to change page permissions

2025-02-20 Thread Ilias Apalodimas
Hi Heinrich On Sun, Feb 09, 2025 at 09:27:36PM +0100, Heinrich Schuchardt wrote: > Am 9. Februar 2025 21:15:53 MEZ schrieb Simon Glass : > >Hi Tom, > > > >On Sun, 9 Feb 2025 at 09:39, Tom Rini wrote: > >> > >> On Thu, Feb 06, 2025 at 08:47:47AM -0700, Simon Glass wrote: > >> > >> [snip] > >> > Pe

Re: [PATCH v1 5/6] treewide: Add a function to change page permissions

2025-02-09 Thread Simon Glass
Hi Tom, On Sun, 9 Feb 2025 at 09:39, Tom Rini wrote: > > On Thu, Feb 06, 2025 at 08:47:47AM -0700, Simon Glass wrote: > > [snip] > > Perhaps make EFI_LOADER select CPU, or depend on CPU? If that's the > > way you want to go, I'd be happy to do a precursor series to deal with > > the fallout. > >

Re: [PATCH v1 5/6] treewide: Add a function to change page permissions

2025-02-09 Thread Heinrich Schuchardt
Am 9. Februar 2025 21:15:53 MEZ schrieb Simon Glass : >Hi Tom, > >On Sun, 9 Feb 2025 at 09:39, Tom Rini wrote: >> >> On Thu, Feb 06, 2025 at 08:47:47AM -0700, Simon Glass wrote: >> >> [snip] >> > Perhaps make EFI_LOADER select CPU, or depend on CPU? If that's the >> > way you want to go, I'd be ha

Re: [PATCH v1 5/6] treewide: Add a function to change page permissions

2025-02-09 Thread Tom Rini
On Thu, Feb 06, 2025 at 08:47:47AM -0700, Simon Glass wrote: [snip] > Perhaps make EFI_LOADER select CPU, or depend on CPU? If that's the > way you want to go, I'd be happy to do a precursor series to deal with > the fallout. I'm not sure what EFI_LOADER has to do with the generic security featur

Re: [PATCH v1 5/6] treewide: Add a function to change page permissions

2025-02-09 Thread Tom Rini
On Thu, Feb 06, 2025 at 05:30:43AM -0700, Simon Glass wrote: > Hi Ilias, > > On Wed, 5 Feb 2025 at 09:54, Ilias Apalodimas > wrote: > > > > Hi Heinrich, > > > > On Wed, 5 Feb 2025 at 18:48, Heinrich Schuchardt wrote: > > > > > > On 2/5/25 08:16, Ilias Apalodimas wrote: > > > > For armv8 we are a

Re: [PATCH v1 5/6] treewide: Add a function to change page permissions

2025-02-09 Thread Tom Rini
On Sun, Feb 09, 2025 at 07:35:31AM -0700, Simon Glass wrote: > Hi Ilias, > > On Thu, 6 Feb 2025 at 09:21, Ilias Apalodimas > wrote: > > > > Hi Simon, > > > > On Thu, 6 Feb 2025 at 17:48, Simon Glass wrote: > > > > > > Hi Ilias, > > > > > > On Thu, 6 Feb 2025 at 08:16, Ilias Apalodimas > > > wro

Re: [PATCH v1 5/6] treewide: Add a function to change page permissions

2025-02-09 Thread Simon Glass
Hi Ilias, On Thu, 6 Feb 2025 at 09:21, Ilias Apalodimas wrote: > > Hi Simon, > > On Thu, 6 Feb 2025 at 17:48, Simon Glass wrote: > > > > Hi Ilias, > > > > On Thu, 6 Feb 2025 at 08:16, Ilias Apalodimas > > wrote: > > > > > > On Thu, 6 Feb 2025 at 14:58, Simon Glass wrote: > > > > > > > > Hi Ili

Re: [PATCH v1 5/6] treewide: Add a function to change page permissions

2025-02-06 Thread Ilias Apalodimas
Hi Simon, On Thu, 6 Feb 2025 at 17:48, Simon Glass wrote: > > Hi Ilias, > > On Thu, 6 Feb 2025 at 08:16, Ilias Apalodimas > wrote: > > > > On Thu, 6 Feb 2025 at 14:58, Simon Glass wrote: > > > > > > Hi Ilias, > > > > > > On Thu, 6 Feb 2025 at 05:52, Ilias Apalodimas > > > wrote: > > > > > > >

Re: [PATCH v1 5/6] treewide: Add a function to change page permissions

2025-02-06 Thread Simon Glass
Hi Ilias, On Thu, 6 Feb 2025 at 08:16, Ilias Apalodimas wrote: > > On Thu, 6 Feb 2025 at 14:58, Simon Glass wrote: > > > > Hi Ilias, > > > > On Thu, 6 Feb 2025 at 05:52, Ilias Apalodimas > > wrote: > > > > > > Hi Simon, > > > > > > On Thu, 6 Feb 2025 at 14:30, Simon Glass wrote: > > > > > > >

Re: [PATCH v1 5/6] treewide: Add a function to change page permissions

2025-02-06 Thread Ilias Apalodimas
On Thu, 6 Feb 2025 at 14:58, Simon Glass wrote: > > Hi Ilias, > > On Thu, 6 Feb 2025 at 05:52, Ilias Apalodimas > wrote: > > > > Hi Simon, > > > > On Thu, 6 Feb 2025 at 14:30, Simon Glass wrote: > > > > > > Hi Ilias, > > > > > > On Wed, 5 Feb 2025 at 09:54, Ilias Apalodimas > > > wrote: > > > >

Re: [PATCH v1 5/6] treewide: Add a function to change page permissions

2025-02-06 Thread Simon Glass
Hi Ilias, On Thu, 6 Feb 2025 at 05:52, Ilias Apalodimas wrote: > > Hi Simon, > > On Thu, 6 Feb 2025 at 14:30, Simon Glass wrote: > > > > Hi Ilias, > > > > On Wed, 5 Feb 2025 at 09:54, Ilias Apalodimas > > wrote: > > > > > > Hi Heinrich, > > > > > > On Wed, 5 Feb 2025 at 18:48, Heinrich Schuchar

Re: [PATCH v1 5/6] treewide: Add a function to change page permissions

2025-02-06 Thread Ilias Apalodimas
Hi Simon, On Thu, 6 Feb 2025 at 14:30, Simon Glass wrote: > > Hi Ilias, > > On Wed, 5 Feb 2025 at 09:54, Ilias Apalodimas > wrote: > > > > Hi Heinrich, > > > > On Wed, 5 Feb 2025 at 18:48, Heinrich Schuchardt wrote: > > > > > > On 2/5/25 08:16, Ilias Apalodimas wrote: > > > > For armv8 we are a

Re: [PATCH v1 5/6] treewide: Add a function to change page permissions

2025-02-06 Thread Simon Glass
Hi Ilias, On Wed, 5 Feb 2025 at 09:54, Ilias Apalodimas wrote: > > Hi Heinrich, > > On Wed, 5 Feb 2025 at 18:48, Heinrich Schuchardt wrote: > > > > On 2/5/25 08:16, Ilias Apalodimas wrote: > > > For armv8 we are adding proper page permissions for the relocated U-Boot > > > binary. Add a weak fun

Re: [PATCH v1 5/6] treewide: Add a function to change page permissions

2025-02-06 Thread Ilias Apalodimas
Hi Heinrich, [...] > > > +++ b/arch/arm/lib/cache.c > > > @@ -170,3 +170,5 @@ __weak int arm_reserve_mmu(void) > > > > > > return 0; > > > } > > > + > > > +void __weak pgprot_set_attrs(phys_addr_t addr, size_t size, u64 perm) {} > > > > I would prefer if the weak function would return -EN

Re: [PATCH v1 5/6] treewide: Add a function to change page permissions

2025-02-06 Thread Heinrich Schuchardt
On 2/6/25 10:42, Ilias Apalodimas wrote: Hi Heinrich, [...] +++ b/arch/arm/lib/cache.c @@ -170,3 +170,5 @@ __weak int arm_reserve_mmu(void) return 0; } + +void __weak pgprot_set_attrs(phys_addr_t addr, size_t size, u64 perm) {} I would prefer if the weak function would return -ENO

Re: [PATCH v1 5/6] treewide: Add a function to change page permissions

2025-02-05 Thread Ilias Apalodimas
Hi Heinrich, On Wed, 5 Feb 2025 at 18:48, Heinrich Schuchardt wrote: > > On 2/5/25 08:16, Ilias Apalodimas wrote: > > For armv8 we are adding proper page permissions for the relocated U-Boot > > binary. Add a weak function that can be used across architectures to change > > the page permissions >

Re: [PATCH v1 5/6] treewide: Add a function to change page permissions

2025-02-05 Thread Heinrich Schuchardt
On 2/5/25 08:16, Ilias Apalodimas wrote: For armv8 we are adding proper page permissions for the relocated U-Boot binary. Add a weak function that can be used across architectures to change the page permissions Signed-off-by: Ilias Apalodimas --- arch/arc/lib/cache.c | 2 ++ arch/