Re: [PATCH v1 2/8] spi: dw: Add device tree properties for fields in CTRL0

2020-03-21 Thread Marek Vasut
On 3/22/20 4:33 AM, Sean Anderson wrote: > On 3/21/20 11:13 PM, Marek Vasut wrote: >> On 3/22/20 4:08 AM, Sean Anderson wrote: >>> On 3/21/20 11:04 PM, Marek Vasut wrote: Could be a different revision of the IP. This is usually handled by using SoC-specific compatible strings, see e.g. Li

Re: [PATCH v1 2/8] spi: dw: Add device tree properties for fields in CTRL0

2020-03-21 Thread Sean Anderson
On 3/21/20 11:13 PM, Marek Vasut wrote: > On 3/22/20 4:08 AM, Sean Anderson wrote: >> On 3/21/20 11:04 PM, Marek Vasut wrote: >>> Could be a different revision of the IP. This is usually handled by >>> using SoC-specific compatible strings, see e.g. Linux >>> Documentation/devicetree/bindings/usb/r

Re: [PATCH v1 2/8] spi: dw: Add device tree properties for fields in CTRL0

2020-03-21 Thread Marek Vasut
On 3/22/20 4:08 AM, Sean Anderson wrote: > On 3/21/20 11:04 PM, Marek Vasut wrote: >> On 3/22/20 3:36 AM, Sean Anderson wrote: >>> On 3/21/20 9:51 PM, Marek Vasut wrote: On 3/5/20 8:19 PM, Sean Anderson wrote: > Some devices have different layouts for the fields in CTRL0 (e.g. the > Ke

Re: [PATCH v1 2/8] spi: dw: Add device tree properties for fields in CTRL0

2020-03-21 Thread Sean Anderson
On 3/21/20 11:04 PM, Marek Vasut wrote: > On 3/22/20 3:36 AM, Sean Anderson wrote: >> On 3/21/20 9:51 PM, Marek Vasut wrote: >>> On 3/5/20 8:19 PM, Sean Anderson wrote: Some devices have different layouts for the fields in CTRL0 (e.g. the Kendryte K210). Allow this layout to be configurab

Re: [PATCH v1 2/8] spi: dw: Add device tree properties for fields in CTRL0

2020-03-21 Thread Marek Vasut
On 3/22/20 3:36 AM, Sean Anderson wrote: > On 3/21/20 9:51 PM, Marek Vasut wrote: >> On 3/5/20 8:19 PM, Sean Anderson wrote: >>> Some devices have different layouts for the fields in CTRL0 (e.g. the >>> Kendryte K210). Allow this layout to be configurable from the device tree. >>> The documentation

Re: [PATCH v1 2/8] spi: dw: Add device tree properties for fields in CTRL0

2020-03-21 Thread Sean Anderson
On 3/21/20 9:51 PM, Marek Vasut wrote: > On 3/5/20 8:19 PM, Sean Anderson wrote: >> Some devices have different layouts for the fields in CTRL0 (e.g. the >> Kendryte K210). Allow this layout to be configurable from the device tree. >> The documentation has been taken from Linux. >> >> Signed-off-by

Re: [PATCH v1 2/8] spi: dw: Add device tree properties for fields in CTRL0

2020-03-21 Thread Marek Vasut
On 3/5/20 8:19 PM, Sean Anderson wrote: > Some devices have different layouts for the fields in CTRL0 (e.g. the > Kendryte K210). Allow this layout to be configurable from the device tree. > The documentation has been taken from Linux. > > Signed-off-by: Sean Anderson > Reviewed-by: Simon Glass