Re: [PATCH v1 17/24] ns16550: match when to define bdf with uart code

2023-02-22 Thread Simon Glass
Hi Troy, On Wed, 22 Feb 2023 at 14:33, Troy Kisky wrote: > > Hi Simon > > So how is this ? > diff --git a/arch/x86/cpu/apollolake/uart.c b/arch/x86/cpu/apollolake/uart.c > index a9362436000..878aa48ed76 100644 > --- a/arch/x86/cpu/apollolake/uart.c > +++ b/arch/x86/cpu/apollolake/uart.c > @@ -79,

Re: [PATCH v1 17/24] ns16550: match when to define bdf with uart code

2023-02-22 Thread Simon Glass
Hi Troy, On Wed, 22 Feb 2023 at 14:06, Troy Kisky wrote: > > On Wed, Feb 22, 2023 at 12:41 PM Troy Kisky > wrote: >> >> >> >>> >>> How does this look ? >>> >>> diff --git a/arch/x86/cpu/apollolake/uart.c b/arch/x86/cpu/apollolake/uart.c >>> index a9362436000..da184638cb9 100644 >>> --- a/arch/x

Re: [PATCH v1 17/24] ns16550: match when to define bdf with uart code

2023-02-22 Thread Troy Kisky
On Wed, Feb 22, 2023 at 12:41 PM Troy Kisky wrote: > > > >> How does this look ? >> >> diff --git a/arch/x86/cpu/apollolake/uart.c >> b/arch/x86/cpu/apollolake/uart.c >> index a9362436000..da184638cb9 100644 >> --- a/arch/x86/cpu/apollolake/uart.c >> +++ b/arch/x86/cpu/apollolake/uart.c >> @@ -79

Re: [PATCH v1 17/24] ns16550: match when to define bdf with uart code

2023-02-22 Thread Simon Glass
Hi Troy, On Wed, 22 Feb 2023 at 12:39, Troy Kisky wrote: > > > On Wed, Feb 22, 2023 at 10:42 AM Troy Kisky > wrote: >> >> On Wed, Feb 22, 2023 at 10:18 AM Tom Rini wrote: >>> >>> On Tue, Feb 21, 2023 at 05:38:14PM -0800, Troy Kisky wrote: >>> >>> > When switching defined(CONFIG_PCI) to CONFIG_

Re: [PATCH v1 17/24] ns16550: match when to define bdf with uart code

2023-02-22 Thread Troy Kisky
On Wed, Feb 22, 2023 at 11:39 AM Troy Kisky wrote: > > On Wed, Feb 22, 2023 at 10:42 AM Troy Kisky > wrote: > >> On Wed, Feb 22, 2023 at 10:18 AM Tom Rini wrote: >> >>> On Tue, Feb 21, 2023 at 05:38:14PM -0800, Troy Kisky wrote: >>> >>> > When switching defined(CONFIG_PCI) to CONFIG_IS_ENABLED(

Re: [PATCH v1 17/24] ns16550: match when to define bdf with uart code

2023-02-22 Thread Troy Kisky
On Wed, Feb 22, 2023 at 10:42 AM Troy Kisky wrote: > On Wed, Feb 22, 2023 at 10:18 AM Tom Rini wrote: > >> On Tue, Feb 21, 2023 at 05:38:14PM -0800, Troy Kisky wrote: >> >> > When switching defined(CONFIG_PCI) to CONFIG_IS_ENABLED(PCI) >> > bdf is no longer accessible. So change to preprocessor

Re: [PATCH v1 17/24] ns16550: match when to define bdf with uart code

2023-02-22 Thread Simon Glass
Hi Troy, On Wed, 22 Feb 2023 at 11:43, Troy Kisky wrote: > > On Wed, Feb 22, 2023 at 10:18 AM Tom Rini wrote: >> >> On Tue, Feb 21, 2023 at 05:38:14PM -0800, Troy Kisky wrote: >> >> > When switching defined(CONFIG_PCI) to CONFIG_IS_ENABLED(PCI) >> > bdf is no longer accessible. So change to prep

Re: [PATCH v1 17/24] ns16550: match when to define bdf with uart code

2023-02-22 Thread Troy Kisky
On Wed, Feb 22, 2023 at 10:18 AM Tom Rini wrote: > On Tue, Feb 21, 2023 at 05:38:14PM -0800, Troy Kisky wrote: > > > When switching defined(CONFIG_PCI) to CONFIG_IS_ENABLED(PCI) > > bdf is no longer accessible. So change to preprocessor to avoid access. > > > > Signed-off-by: Troy Kisky > > ---

Re: [PATCH v1 17/24] ns16550: match when to define bdf with uart code

2023-02-22 Thread Tom Rini
On Tue, Feb 21, 2023 at 05:38:14PM -0800, Troy Kisky wrote: > When switching defined(CONFIG_PCI) to CONFIG_IS_ENABLED(PCI) > bdf is no longer accessible. So change to preprocessor to avoid access. > > Signed-off-by: Troy Kisky > --- > > arch/x86/cpu/apollolake/uart.c | 6 +++--- > include/ns16