Re: [PATCH v1] acpi_table: Fix coverity defect in acpi_write_spcr

2024-10-30 Thread Patrick Rudolph
Hi Tom, On Tue, Oct 29, 2024 at 3:53 AM Tom Rini wrote: > > On Mon, Oct 28, 2024 at 05:27:14PM -0600, Tom Rini wrote: > > On Mon, 28 Oct 2024 09:08:35 +0100, Patrick Rudolph wrote: > > > > > Fix "Integer handling issues (SIGN_EXTENSION)" in newly added code: > > > Cast serial_info.reg_offset to u

Re: [PATCH v1] acpi_table: Fix coverity defect in acpi_write_spcr

2024-10-28 Thread Tom Rini
On Mon, Oct 28, 2024 at 05:27:14PM -0600, Tom Rini wrote: > On Mon, 28 Oct 2024 09:08:35 +0100, Patrick Rudolph wrote: > > > Fix "Integer handling issues (SIGN_EXTENSION)" in newly added code: > > Cast serial_info.reg_offset to u64 to prevent an integer overflow when > > shifted too many bits to

Re: [PATCH v1] acpi_table: Fix coverity defect in acpi_write_spcr

2024-10-28 Thread Tom Rini
On Mon, 28 Oct 2024 09:08:35 +0100, Patrick Rudolph wrote: > Fix "Integer handling issues (SIGN_EXTENSION)" in newly added code: > Cast serial_info.reg_offset to u64 to prevent an integer overflow when > shifted too many bits to the left. Currently this never happens as the > shift is supposed to

Re: [PATCH v1] acpi_table: Fix coverity defect in acpi_write_spcr

2024-10-28 Thread Moritz Fischer
On Mon, Oct 28, 2024 at 1:09 AM Patrick Rudolph wrote: > > Fix "Integer handling issues (SIGN_EXTENSION)" in newly added code: > Cast serial_info.reg_offset to u64 to prevent an integer overflow when > shifted too many bits to the left. Currently this never happens as the > shift is supposed to b