Re: [PATCH 2/3] dm: button: add support for linux_code in button-gpio.c driver

2023-01-16 Thread Quentin Schulz
Hi Dzmitry, On 1/16/23 12:19, Dzmitry Sankouski wrote: I guess, u-boot button driver was created as minimal as possible intentionally, to keep the size small. I'm not sure that we're *that* size constrained in U-Boot proper. It may be used in scripts without event code with button command. S

Re: [PATCH 2/3] dm: button: add support for linux_code in button-gpio.c driver

2023-01-16 Thread Dzmitry Sankouski
I guess, u-boot button driver was created as minimal as possible intentionally, to keep the size small. It may be used in scripts without event code with button command. Some dts has no event code, for example sandbox.dtsi. пн, 16 янв. 2023 г. в 12:53, Quentin Schulz : > > Hi Dzmitry, > > On 1/14/

Re: [PATCH 2/3] dm: button: add support for linux_code in button-gpio.c driver

2023-01-16 Thread Quentin Schulz
Hi Dzmitry, On 1/14/23 20:42, Dzmitry Sankouski wrote: dev_read_u32 will fail, if linux,code is not found. We shouldn't fail here, as linux,code is optional, so maybe dev_read_u32_default with 0 default value, instead of negative error code? No, 0 is an existing and valid code. FYI, linux,co

Re: [PATCH 2/3] dm: button: add support for linux_code in button-gpio.c driver

2023-01-14 Thread Dzmitry Sankouski
dev_read_u32 will fail, if linux,code is not found. We shouldn't fail here, as linux,code is optional, so maybe dev_read_u32_default with 0 default value, instead of negative error code? ср, 11 янв. 2023 г. в 18:48, Quentin Schulz : > > Hi Dzmitry, > > On 1/11/23 11:19, Dzmitry Sankouski wrote: >

Re: [PATCH 2/3] dm: button: add support for linux_code in button-gpio.c driver

2023-01-11 Thread Quentin Schulz
Hi Dzmitry, On 1/11/23 11:19, Dzmitry Sankouski wrote: Linux event code may be used in input devices, using buttons. Signed-off-by: Dzmitry Sankouski --- drivers/button/button-gpio.c | 20 drivers/button/button-uclass.c | 10 ++ include/button.h