Re: [PATCH 1/6] clk: Handle error pointers in clk_valid()

2023-03-04 Thread Michal Suchánek
On Sat, Mar 04, 2023 at 01:54:12PM -0600, Samuel Holland wrote: > On 2/20/23 13:42, Michal Suchánek wrote: > > On Mon, Feb 20, 2023 at 10:57:17AM -0500, Sean Anderson wrote: > >> > >> On 2/20/23 05:46, Michal Suchánek wrote: > >>> On Sun, Feb 19, 2023 at 11:59:34PM -0600, Samuel Holland wrote: > >>

Re: [PATCH 1/6] clk: Handle error pointers in clk_valid()

2023-03-04 Thread Samuel Holland
On 2/20/23 13:42, Michal Suchánek wrote: > On Mon, Feb 20, 2023 at 10:57:17AM -0500, Sean Anderson wrote: >> >> On 2/20/23 05:46, Michal Suchánek wrote: >>> On Sun, Feb 19, 2023 at 11:59:34PM -0600, Samuel Holland wrote: Some clk uclass functions, such as devm_clk_get() and clk_get_parent(), >

Re: [PATCH 1/6] clk: Handle error pointers in clk_valid()

2023-02-20 Thread Michal Suchánek
On Mon, Feb 20, 2023 at 10:57:17AM -0500, Sean Anderson wrote: > > On 2/20/23 05:46, Michal Suchánek wrote: > > On Sun, Feb 19, 2023 at 11:59:34PM -0600, Samuel Holland wrote: > > > Some clk uclass functions, such as devm_clk_get() and clk_get_parent(), > > > return error pointers. clk_valid() sho

Re: [PATCH 1/6] clk: Handle error pointers in clk_valid()

2023-02-20 Thread Sean Anderson
On 2/20/23 05:46, Michal Suchánek wrote: On Sun, Feb 19, 2023 at 11:59:34PM -0600, Samuel Holland wrote: Some clk uclass functions, such as devm_clk_get() and clk_get_parent(), return error pointers. clk_valid() should not consider these pointers to be valid. Fixes: 8a1661f20e6c ("drivers: clk

Re: [PATCH 1/6] clk: Handle error pointers in clk_valid()

2023-02-20 Thread Michal Suchánek
On Sun, Feb 19, 2023 at 11:59:34PM -0600, Samuel Holland wrote: > Some clk uclass functions, such as devm_clk_get() and clk_get_parent(), > return error pointers. clk_valid() should not consider these pointers > to be valid. > > Fixes: 8a1661f20e6c ("drivers: clk: Handle gracefully NULL pointers")