Re: [PATCH 1/1] mvebu: fix end-of-array check

2022-12-06 Thread Stefan Roese
Hi Pali, Hi Derek, On 12/6/22 20:56, Pali Rohár wrote: On Tuesday 06 December 2022 07:10:15 Stefan Roese wrote: Hi Pali, On 12/5/22 19:18, Pali Rohár wrote: On Monday 05 December 2022 12:42:44 Stefan Roese wrote: Hi! On 12/4/22 11:39, Pali Rohár wrote: Hello! I would suggest to change des

Re: [PATCH 1/1] mvebu: fix end-of-array check

2022-12-06 Thread Pali Rohár
On Tuesday 06 December 2022 07:10:15 Stefan Roese wrote: > Hi Pali, > > On 12/5/22 19:18, Pali Rohár wrote: > > On Monday 05 December 2022 12:42:44 Stefan Roese wrote: > > > Hi! > > > > > > On 12/4/22 11:39, Pali Rohár wrote: > > > > Hello! > > > > > > > > I would suggest to change description o

Re: [PATCH 1/1] mvebu: fix end-of-array check

2022-12-05 Thread Stefan Roese
Hi Pali, On 12/5/22 19:18, Pali Rohár wrote: On Monday 05 December 2022 12:42:44 Stefan Roese wrote: Hi! On 12/4/22 11:39, Pali Rohár wrote: Hello! I would suggest to change description of the patch from "mvebu: fix end-of-array check" to something like: "arm: mvebu: Espressobin:

Re: [PATCH 1/1] mvebu: fix end-of-array check

2022-12-05 Thread Pali Rohár
On Monday 05 December 2022 12:42:44 Stefan Roese wrote: > Hi! > > On 12/4/22 11:39, Pali Rohár wrote: > > Hello! > > > > I would suggest to change description of the patch from > > > >"mvebu: fix end-of-array check" > > > > to something like: > > > >"arm: mvebu: Espressobin: fix end-of

Re: [PATCH 1/1] mvebu: fix end-of-array check

2022-12-05 Thread Simon Glass
Hi Pali, On Mon, 5 Dec 2022 at 10:51, Pali Rohár wrote: > > On Monday 05 December 2022 10:16:51 Simon Glass wrote: > > On Thu, 1 Dec 2022 at 07:55, Derek LaHousse wrote: > > > > > > Properly seek the end of default_environment variables. > > > > > > The current algorithm overwrites from the seco

Re: [PATCH 1/1] mvebu: fix end-of-array check

2022-12-05 Thread Stefan Roese
Hi! On 12/4/22 11:39, Pali Rohár wrote: Hello! I would suggest to change description of the patch from "mvebu: fix end-of-array check" to something like: "arm: mvebu: Espressobin: fix end-of-array check in env" as it affects only Espressobin boards (not other mvebu). Yes, please upd

Re: [PATCH 1/1] mvebu: fix end-of-array check

2022-12-04 Thread Pali Rohár
On Monday 05 December 2022 10:16:51 Simon Glass wrote: > On Thu, 1 Dec 2022 at 07:55, Derek LaHousse wrote: > > > > Properly seek the end of default_environment variables. > > > > The current algorithm overwrites from the second variable. This > > replacement finds the end of the array of strings

Re: [PATCH 1/1] mvebu: fix end-of-array check

2022-12-04 Thread Simon Glass
On Thu, 1 Dec 2022 at 07:55, Derek LaHousse wrote: > > Properly seek the end of default_environment variables. > > The current algorithm overwrites from the second variable. This > replacement finds the end of the array of strings. > > Stomped variables include "board", "soc", "loadaddr". These

Re: [PATCH 1/1] mvebu: fix end-of-array check

2022-12-04 Thread Pali Rohár
Hello! I would suggest to change description of the patch from "mvebu: fix end-of-array check" to something like: "arm: mvebu: Espressobin: fix end-of-array check in env" as it affects only Espressobin boards (not other mvebu). Stefan, please look below as this issue/fix is important. On