Re: [PATCH 05/18] net/net: fix switch/case fallthrough annotations

2025-04-10 Thread Andre Przywara
On Tue, 8 Apr 2025 19:46:46 -0600 Tom Rini wrote: Hi Tom, > On Wed, Apr 09, 2025 at 12:53:47AM +0100, Andre Przywara wrote: > > On Tue, 8 Apr 2025 16:29:18 -0600 > > Tom Rini wrote: > > > > Hi Tom, > > > > thanks for staying on this! > > > > > On Thu, Mar 27, 2025 at 03:33:00PM +, Andr

Re: [PATCH 05/18] net/net: fix switch/case fallthrough annotations

2025-04-09 Thread Tom Rini
On Wed, Apr 09, 2025 at 11:41:37AM +0100, Andre Przywara wrote: > On Tue, 8 Apr 2025 19:46:46 -0600 > Tom Rini wrote: > > Hi Tom, > > > On Wed, Apr 09, 2025 at 12:53:47AM +0100, Andre Przywara wrote: > > > On Tue, 8 Apr 2025 16:29:18 -0600 > > > Tom Rini wrote: > > > > > > Hi Tom, > > > > > >

Re: [PATCH 05/18] net/net: fix switch/case fallthrough annotations

2025-04-08 Thread Tom Rini
On Wed, Apr 09, 2025 at 12:53:47AM +0100, Andre Przywara wrote: > On Tue, 8 Apr 2025 16:29:18 -0600 > Tom Rini wrote: > > Hi Tom, > > thanks for staying on this! > > > On Thu, Mar 27, 2025 at 03:33:00PM +, Andre Przywara wrote: > > > > > The net_check_prereq() routine in the generic networ

Re: [PATCH 05/18] net/net: fix switch/case fallthrough annotations

2025-04-08 Thread Andre Przywara
On Tue, 8 Apr 2025 16:29:18 -0600 Tom Rini wrote: Hi Tom, thanks for staying on this! > On Thu, Mar 27, 2025 at 03:33:00PM +, Andre Przywara wrote: > > > The net_check_prereq() routine in the generic network handling code > > mixes case: labels with #ifdef's, which makes predicting fallthr

Re: [PATCH 05/18] net/net: fix switch/case fallthrough annotations

2025-04-08 Thread Tom Rini
On Thu, Mar 27, 2025 at 03:33:00PM +, Andre Przywara wrote: > The net_check_prereq() routine in the generic network handling code > mixes case: labels with #ifdef's, which makes predicting fallthrough > situations tricky. We had two "fall through" comments in the code, but > at the wrong place

Re: [PATCH 05/18] net/net: fix switch/case fallthrough annotations

2025-03-31 Thread Tom Rini
On Thu, Mar 27, 2025 at 03:33:00PM +, Andre Przywara wrote: > The net_check_prereq() routine in the generic network handling code > mixes case: labels with #ifdef's, which makes predicting fallthrough > situations tricky. We had two "fall through" comments in the code, but > at the wrong place