Re: [PATCH 01/16] lib: fdtdec: Handle multiple memory nodes

2024-06-11 Thread Heinrich Schuchardt
Am 11. Juni 2024 20:51:55 MESZ schrieb Simon Glass : >Hi Jiaxun, > >On Tue, 11 Jun 2024 at 07:48, Jiaxun Yang wrote: >> >> >> >> 在2024年6月11日六月 下午1:26,Heinrich Schuchardt写道: >> Hi Heinrich, >> >> Thanks for your comments, will fix most of them in next reversion. >> >> [...] >> >> -gd

Re: [PATCH 01/16] lib: fdtdec: Handle multiple memory nodes

2024-06-11 Thread Simon Glass
Hi Jiaxun, On Tue, 11 Jun 2024 at 07:48, Jiaxun Yang wrote: > > > > 在2024年6月11日六月 下午1:26,Heinrich Schuchardt写道: > Hi Heinrich, > > Thanks for your comments, will fix most of them in next reversion. > > [...] > >> -gd->bd->bi_dram[bank].start = (phys_addr_t)res.start; > > > > The conve

Re: [PATCH 01/16] lib: fdtdec: Handle multiple memory nodes

2024-06-11 Thread Jiaxun Yang
在2024年6月11日六月 下午1:26,Heinrich Schuchardt写道: Hi Heinrich, Thanks for your comments, will fix most of them in next reversion. [...] >> -gd->bd->bi_dram[bank].start = (phys_addr_t)res.start; > > The conversion is superfluous. This is necessary as phys_addr_t can be unsigned long or u

Re: [PATCH 01/16] lib: fdtdec: Handle multiple memory nodes

2024-06-11 Thread Heinrich Schuchardt
On 22.05.24 17:34, Jiaxun Yang wrote: Current code only tries to fetch the first memory node found in fdt tree and determine memory banks from multiple reg properties. Linux do allow multiple memory nodes in devicetree, rework %/do allow/allows/ It is not Linux that allows it but Devicetree