Re: [PATCH] video: Add parentheses around VNBYTES() macro

2024-09-06 Thread Tom Rini
On Mon, Sep 02, 2024 at 10:17:59AM +0200, Miquel Raynal wrote: > Hello, > > tr...@konsulko.com wrote on Tue, 19 Sep 2023 11:14:56 -0400: > > > On Mon, Sep 18, 2023 at 07:04:41PM -0600, Simon Glass wrote: > > > Hi Tom, Dan, > > > > > > On Tue, 8 Aug 2023 at 19:39, Tom Rini wrote: > > > > > > >

Re: [PATCH] video: Add parentheses around VNBYTES() macro

2024-09-02 Thread Miquel Raynal
Hello, tr...@konsulko.com wrote on Tue, 19 Sep 2023 11:14:56 -0400: > On Mon, Sep 18, 2023 at 07:04:41PM -0600, Simon Glass wrote: > > Hi Tom, Dan, > > > > On Tue, 8 Aug 2023 at 19:39, Tom Rini wrote: > > > > > > On Wed, Jul 26, 2023 at 09:54:08AM +0300, Dan Carpenter wrote: > > > > > > > T

Re: [PATCH] video: Add parentheses around VNBYTES() macro

2023-09-19 Thread Tom Rini
On Mon, Sep 18, 2023 at 07:04:41PM -0600, Simon Glass wrote: > Hi Tom, Dan, > > On Tue, 8 Aug 2023 at 19:39, Tom Rini wrote: > > > > On Wed, Jul 26, 2023 at 09:54:08AM +0300, Dan Carpenter wrote: > > > > > The VNBYTES() macro needs to have parentheses to prevent some (harmless) > > > macro expans

Re: [PATCH] video: Add parentheses around VNBYTES() macro

2023-09-18 Thread Simon Glass
Hi Tom, Dan, On Tue, 8 Aug 2023 at 19:39, Tom Rini wrote: > > On Wed, Jul 26, 2023 at 09:54:08AM +0300, Dan Carpenter wrote: > > > The VNBYTES() macro needs to have parentheses to prevent some (harmless) > > macro expansion bugs. The VNBYTES() macro is used like this: > > > > VID_TO_PIXEL(

Re: [PATCH] video: Add parentheses around VNBYTES() macro

2023-08-08 Thread Tom Rini
On Wed, Jul 26, 2023 at 09:54:08AM +0300, Dan Carpenter wrote: > The VNBYTES() macro needs to have parentheses to prevent some (harmless) > macro expansion bugs. The VNBYTES() macro is used like this: > > VID_TO_PIXEL(x) * VNBYTES(vid_priv->bpix) > > The * operation is done before the / o

Re: [PATCH] video: Add parentheses around VNBYTES() macro

2023-07-26 Thread Simon Glass
On Wed, 26 Jul 2023 at 00:54, Dan Carpenter wrote: > > The VNBYTES() macro needs to have parentheses to prevent some (harmless) > macro expansion bugs. The VNBYTES() macro is used like this: > > VID_TO_PIXEL(x) * VNBYTES(vid_priv->bpix) > > The * operation is done before the / operation.