Re: [PATCH] sunxi: usb: convert PHY GPIO functions to DM

2022-06-26 Thread Andre Przywara
On Wed, 8 Jun 2022 01:06:04 +0100 Andre Przywara wrote: > The Allwinner USB PHY driver is still using the legacy GPIO interface, > which is now implemented by the DM_GPIO compat functions. > Those seem to have some design flaws, as setting the direction, then > later setting the value will not w

Re: [PATCH] sunxi: usb: convert PHY GPIO functions to DM

2022-06-08 Thread Andre Przywara
On Wed, 8 Jun 2022 08:14:27 -0500 Samuel Holland wrote: Hi, > On 6/8/22 4:46 AM, Andre Przywara wrote: > > On Tue, 7 Jun 2022 21:07:59 -0500 > > Samuel Holland wrote: > > > > Hi, > > > >> On 6/7/22 7:06 PM, Andre Przywara wrote: > >>> The Allwinner USB PHY driver is still using the legacy

Re: [PATCH] sunxi: usb: convert PHY GPIO functions to DM

2022-06-08 Thread Samuel Holland
On 6/8/22 4:46 AM, Andre Przywara wrote: > On Tue, 7 Jun 2022 21:07:59 -0500 > Samuel Holland wrote: > > Hi, > >> On 6/7/22 7:06 PM, Andre Przywara wrote: >>> The Allwinner USB PHY driver is still using the legacy GPIO interface, >>> which is now implemented by the DM_GPIO compat functions. >>>

Re: [PATCH] sunxi: usb: convert PHY GPIO functions to DM

2022-06-08 Thread Milan P . Stanić
Hi, it works fine. Thank you. On Wed, 2022-06-08 at 01:06, Andre Przywara wrote: > The Allwinner USB PHY driver is still using the legacy GPIO interface, > which is now implemented by the DM_GPIO compat functions. > Those seem to have some design flaws, as setting the direction, then > later sett

Re: [PATCH] sunxi: usb: convert PHY GPIO functions to DM

2022-06-08 Thread Andre Przywara
On Tue, 7 Jun 2022 21:07:59 -0500 Samuel Holland wrote: Hi, > On 6/7/22 7:06 PM, Andre Przywara wrote: > > The Allwinner USB PHY driver is still using the legacy GPIO interface, > > which is now implemented by the DM_GPIO compat functions. > > Those seem to have some design flaws, as setting the

Re: [PATCH] sunxi: usb: convert PHY GPIO functions to DM

2022-06-07 Thread Samuel Holland
On 6/7/22 7:06 PM, Andre Przywara wrote: > The Allwinner USB PHY driver is still using the legacy GPIO interface, > which is now implemented by the DM_GPIO compat functions. > Those seem to have some design flaws, as setting the direction, then > later setting the value will not work, if the DM_GPI