Re: [PATCH] sunxi: psci: remove redundant initialization from psci_arch_init

2023-08-29 Thread Chen-Yu Tsai
On Tue, Aug 29, 2023 at 5:49 AM Sam Edwards wrote: > > On 8/26/23 04:22, Marc Zyngier wrote: > > Hi Marc! > > > The GIC definitely has the NS bit routed to it. Otherwise, the secure > > configuration would just be an utter joke. Just try it. > > Thank you for your response. I'd like to revisit my

Re: [PATCH] sunxi: psci: remove redundant initialization from psci_arch_init

2023-08-29 Thread Chen-Yu Tsai
(resent from kernel.org address) On Tue, Aug 29, 2023 at 5:49 AM Sam Edwards wrote: > > On 8/26/23 04:22, Marc Zyngier wrote: > > Hi Marc! > > > The GIC definitely has the NS bit routed to it. Otherwise, the secure > > configuration would just be an utter joke. Just try it. > > Thank you for your

Re: [PATCH] sunxi: psci: remove redundant initialization from psci_arch_init

2023-08-28 Thread Sam Edwards
On 8/26/23 04:22, Marc Zyngier wrote: Hi Marc! The GIC definitely has the NS bit routed to it. Otherwise, the secure configuration would just be an utter joke. Just try it. Thank you for your response. I'd like to revisit my prior point about the distinction between the NS bit and AxPROT[1]

Re: [PATCH] sunxi: psci: remove redundant initialization from psci_arch_init

2023-08-26 Thread Marc Zyngier
On Fri, 25 Aug 2023 19:05:32 +0100, Sam Edwards wrote: > > On 8/25/23 00:20, Chen-Yu Tsai wrote: > > Hi Chen-Yu, > > > IIRC the GIC manual says that the secure bit is set or cleared to select > > which bank of registers is accessed. > > Which secure bit are we talking about here? Do we mean th

Re: [PATCH] sunxi: psci: remove redundant initialization from psci_arch_init

2023-08-25 Thread Sam Edwards
On 8/25/23 00:20, Chen-Yu Tsai wrote: Hi Chen-Yu, IIRC the GIC manual says that the secure bit is set or cleared to select which bank of registers is accessed. Which secure bit are we talking about here? Do we mean the *configured* secure bit (SCR.NS, what the code is attempting to clear) or

Re: [PATCH] sunxi: psci: remove redundant initialization from psci_arch_init

2023-08-25 Thread Chen-Yu Tsai
On Tue, Aug 15, 2023 at 4:40 AM Andre Przywara wrote: > > On Wed, 31 May 2023 14:15:20 -0600 > Sam Edwards wrote: > > Hi, > > (CC:ing Marc and Chen-Yu as the original authors) > > sorry for the delay, found that mouldering in my Drafts folder. > > > The nonsec code overrides/handles these: > > -

Re: [PATCH] sunxi: psci: remove redundant initialization from psci_arch_init

2023-08-15 Thread Marc Zyngier
On Mon, 14 Aug 2023 21:39:10 +0100, Andre Przywara wrote: > > On Wed, 31 May 2023 14:15:20 -0600 > Sam Edwards wrote: > > Hi, > > (CC:ing Marc and Chen-Yu as the original authors) > > sorry for the delay, found that mouldering in my Drafts folder. > > > The nonsec code overrides/handles thes

Re: [PATCH] sunxi: psci: remove redundant initialization from psci_arch_init

2023-08-14 Thread Andre Przywara
On Wed, 31 May 2023 14:15:20 -0600 Sam Edwards wrote: Hi, (CC:ing Marc and Chen-Yu as the original authors) sorry for the delay, found that mouldering in my Drafts folder. > The nonsec code overrides/handles these: > - Setting PMR to 0xFF happens earlier, in _nonsec_init, so this is > redund