Re: [PATCH] rsa: fix alignment issue when getting public exponent

2020-05-07 Thread Tom Rini
On Thu, May 07, 2020 at 09:10:17AM +0200, Jan Kiszka wrote: > On 03.05.20 13:26, Heiko Stuebner wrote: > > From: Heiko Stuebner > > > > To fill the exponent field of the rsa_public_key struct, rsa_mod_exp_sw > > did a cast to uint64_t of the key_prop->public_exponent field. > > But that alignment

Re: [PATCH] rsa: fix alignment issue when getting public exponent

2020-05-07 Thread Tom Rini
On Sun, May 03, 2020 at 01:26:34PM +0200, Heiko Stuebner wrote: > From: Heiko Stuebner > > To fill the exponent field of the rsa_public_key struct, rsa_mod_exp_sw > did a cast to uint64_t of the key_prop->public_exponent field. > But that alignment is not guaranteed in all cases. > > This came

Re: [PATCH] rsa: fix alignment issue when getting public exponent

2020-05-07 Thread Jan Kiszka
On 03.05.20 13:26, Heiko Stuebner wrote: From: Heiko Stuebner To fill the exponent field of the rsa_public_key struct, rsa_mod_exp_sw did a cast to uint64_t of the key_prop->public_exponent field. But that alignment is not guaranteed in all cases. This came to light when in my spl-fit-signatur

Re: [PATCH] rsa: fix alignment issue when getting public exponent

2020-05-04 Thread Simon Glass
Hi Heiko, On Mon, 4 May 2020 at 09:40, Heiko Stübner wrote: > > Am Montag, 4. Mai 2020, 16:17:52 CEST schrieb Simon Glass: > > +Tom Rini > > > > On Sun, 3 May 2020 at 05:26, Heiko Stuebner wrote: > > > > > > From: Heiko Stuebner > > > > > > To fill the exponent field of the rsa_public_key struc

Re: [PATCH] rsa: fix alignment issue when getting public exponent

2020-05-04 Thread Heiko Stübner
Am Montag, 4. Mai 2020, 16:17:52 CEST schrieb Simon Glass: > +Tom Rini > > On Sun, 3 May 2020 at 05:26, Heiko Stuebner wrote: > > > > From: Heiko Stuebner > > > > To fill the exponent field of the rsa_public_key struct, rsa_mod_exp_sw > > did a cast to uint64_t of the key_prop->public_exponent f

Re: [PATCH] rsa: fix alignment issue when getting public exponent

2020-05-04 Thread Simon Glass
+Tom Rini On Sun, 3 May 2020 at 05:26, Heiko Stuebner wrote: > > From: Heiko Stuebner > > To fill the exponent field of the rsa_public_key struct, rsa_mod_exp_sw > did a cast to uint64_t of the key_prop->public_exponent field. > But that alignment is not guaranteed in all cases. > > This came to

Re: [PATCH] rsa: fix alignment issue when getting public exponent

2020-05-03 Thread Philipp Tomsich
> On 03.05.2020, at 13:26, Heiko Stuebner wrote: > > From: Heiko Stuebner > > To fill the exponent field of the rsa_public_key struct, rsa_mod_exp_sw > did a cast to uint64_t of the key_prop->public_exponent field. > But that alignment is not guaranteed in all cases. > > This came to light