Re: [PATCH] part: efi: Rely on a definition to specify the primary GPT position

2024-07-14 Thread Roman Stratiienko
Hello Heinrich, Sorry, I'm having a hard time answering your questions. > When writing the partition table shouldn't the offset be reflected in the protective MBR fields StartingCHS and StartingLBA? See Table 5.4 "Protective MBR Partition Record protecting the entire disk*" of the UEFI 2.10 speci

Re: [PATCH] part: efi: Rely on a definition to specify the primary GPT position

2024-07-13 Thread Heinrich Schuchardt
On 7/13/24 23:16, Roman Stratiienko wrote: Hello Heinrich, Thank you for your comments. Just a few thoughts about this patch. 1. I was also sending this patch as a noninvasive, semi-cosmetic change. Relying on hardcoded values is usually not a good practice. 2. Shifting of primary GPT works in

Re: [PATCH] part: efi: Rely on a definition to specify the primary GPT position

2024-07-13 Thread Roman Stratiienko
Hello Heinrich, Thank you for your comments. Just a few thoughts about this patch. 1. I was also sending this patch as a noninvasive, semi-cosmetic change. Relying on hardcoded values is usually not a good practice. 2. Shifting of primary GPT works in u-boot and Linux kernel with minor tweaks. S

Re: [PATCH] part: efi: Rely on a definition to specify the primary GPT position

2024-06-10 Thread Heinrich Schuchardt
On 19.05.24 17:35, Roman Stratiienko wrote: Use GPT_PRIMARY_PARTITION_TABLE_LBA as the only source for a primary GPT location instead of hardcoding it every time. Sometimes, we need to shift the primary GPT location. Having the location in the single place simplifies such shifting. In gdisk th