Re: [PATCH] nvme: Elaborate on cache maintenance operation in get/set_features

2021-03-19 Thread Tom Rini
On Tue, Mar 02, 2021 at 03:43:43PM +, Andre Przywara wrote: > At the moment the nvme_get_features() and nvme_set_features() functions > carry a (somewhat misleading) comment about missing cache maintenance. > > As it turns out, nvme_get_features() has no caller at all in the tree, > and nvme_

Re: [PATCH] nvme: Elaborate on cache maintenance operation in get/set_features

2021-03-05 Thread Marek Vasut
On 3/3/21 12:13 PM, Andre Przywara wrote: [...] @@ -488,12 +489,20 @@ int nvme_get_features(struct nvme_dev *dev, unsigned fid, unsigned nsid, c.features.prp1 = cpu_to_le64(dma_addr); c.features.fid = cpu_to_le32(fid); + ret = nvme_submit_admin_cmd(dev, &c, result); +

Re: [PATCH] nvme: Elaborate on cache maintenance operation in get/set_features

2021-03-03 Thread Andre Przywara
On Wed, 3 Mar 2021 03:42:40 +0100 Marek Vasut wrote: Hi, > On 3/2/21 4:43 PM, Andre Przywara wrote: > > [...] > > > @@ -488,12 +489,20 @@ int nvme_get_features(struct nvme_dev *dev, unsigned > > fid, unsigned nsid, > > c.features.prp1 = cpu_to_le64(dma_addr); > > c.features.fid = cpu_

Re: [PATCH] nvme: Elaborate on cache maintenance operation in get/set_features

2021-03-02 Thread Marek Vasut
On 3/2/21 4:43 PM, Andre Przywara wrote: [...] @@ -488,12 +489,20 @@ int nvme_get_features(struct nvme_dev *dev, unsigned fid, unsigned nsid, c.features.prp1 = cpu_to_le64(dma_addr); c.features.fid = cpu_to_le32(fid); + ret = nvme_submit_admin_cmd(dev, &c, result); +

Re: [PATCH] nvme: Elaborate on cache maintenance operation in get/set_features

2021-03-02 Thread Bin Meng
On Tue, Mar 2, 2021 at 11:43 PM Andre Przywara wrote: > > At the moment the nvme_get_features() and nvme_set_features() functions > carry a (somewhat misleading) comment about missing cache maintenance. > > As it turns out, nvme_get_features() has no caller at all in the tree, > and nvme_set_featu

Re: [PATCH] nvme: Elaborate on cache maintenance operation in get/set_features

2021-03-02 Thread Michael Nazzareno Trimarchi
Hi On Tue, Mar 2, 2021 at 4:43 PM Andre Przywara wrote: > > At the moment the nvme_get_features() and nvme_set_features() functions > carry a (somewhat misleading) comment about missing cache maintenance. > > As it turns out, nvme_get_features() has no caller at all in the tree, > and nvme_set_fe