Re: [PATCH] misc: Port USB251xB/xBi Hi-Speed Hub Controller Driver from Linux

2022-07-11 Thread Stefan Herbrechtsmeier
Hi Marek, Am 14.06.2022 um 09:38 schrieb Marek Vasut: On 6/14/22 09:08, Stefan Herbrechtsmeier wrote: Am 13.06.2022 um 22:26 schrieb Marek Vasut: On 6/13/22 19:23, Stefan Herbrechtsmeier wrote: [snip] +    if (dev_read_u32(dev, "vendor-id", &hub->vendor_id)) +    hub->vendor_id = USB25

Re: [PATCH] misc: Port USB251xB/xBi Hi-Speed Hub Controller Driver from Linux

2022-06-14 Thread Marek Vasut
On 6/14/22 09:08, Stefan Herbrechtsmeier wrote: Am 13.06.2022 um 22:26 schrieb Marek Vasut: On 6/13/22 19:23, Stefan Herbrechtsmeier wrote: [snip] +    if (dev_read_u32(dev, "vendor-id", &hub->vendor_id)) +    hub->vendor_id = USB251XB_DEF_VENDOR_ID; + +    if (dev_read_u32(dev, "product

Re: [PATCH] misc: Port USB251xB/xBi Hi-Speed Hub Controller Driver from Linux

2022-06-14 Thread Stefan Herbrechtsmeier
Am 13.06.2022 um 22:26 schrieb Marek Vasut: On 6/13/22 19:23, Stefan Herbrechtsmeier wrote: [snip] +    if (dev_read_u32(dev, "vendor-id", &hub->vendor_id)) +    hub->vendor_id = USB251XB_DEF_VENDOR_ID; + +    if (dev_read_u32(dev, "product-id", &hub->product_id)) +    hub->product_id

Re: [PATCH] misc: Port USB251xB/xBi Hi-Speed Hub Controller Driver from Linux

2022-06-13 Thread Marek Vasut
On 6/13/22 19:23, Stefan Herbrechtsmeier wrote: Hi Marek, Hi, [...] + +    if (IS_ENABLED(CONFIG_DM_REGULATOR)) { +    err = device_get_supply_regulator(dev, "vdd-supply", +  &hub->vdd); +    if (err && err != -ENOENT) { +    dev_err(dev, "Warning: can

Re: [PATCH] misc: Port USB251xB/xBi Hi-Speed Hub Controller Driver from Linux

2022-06-13 Thread Stefan Herbrechtsmeier
Hi Marek, Am 13.06.2022 um 18:00 schrieb Marek Vasut: On 6/13/22 17:39, Stefan Herbrechtsmeier wrote: Hi Marek, Hi, sorry for the late comments but I think the driver doesn't work as expected. How come ? It works on my board. Have you test with 16 bit property data? [...] + +    if

Re: [PATCH] misc: Port USB251xB/xBi Hi-Speed Hub Controller Driver from Linux

2022-06-13 Thread Marek Vasut
On 6/13/22 17:39, Stefan Herbrechtsmeier wrote: Hi Marek, Hi, sorry for the late comments but I think the driver doesn't work as expected. How come ? It works on my board. [...] + +    if (IS_ENABLED(CONFIG_DM_REGULATOR)) { +    err = device_get_supply_regulator(dev, "vdd-supply", + 

Re: [PATCH] misc: Port USB251xB/xBi Hi-Speed Hub Controller Driver from Linux

2022-06-13 Thread Stefan Herbrechtsmeier
Hi Marek, sorry for the late comments but I think the driver doesn't work as expected. Am 10.04.2022 um 06:27 schrieb Marek Vasut: This patch adds a driver for configuration of the Microchip USB251xB/xBi USB 2.0 hub controller series with USB 2.0 upstream connectivity, SMBus configuration inter

Re: [PATCH] misc: Port USB251xB/xBi Hi-Speed Hub Controller Driver from Linux

2022-05-09 Thread Marek Vasut
On 4/10/22 06:27, Marek Vasut wrote: This patch adds a driver for configuration of the Microchip USB251xB/xBi USB 2.0 hub controller series with USB 2.0 upstream connectivity, SMBus configuration interface and two to four USB 2.0 downstream ports. This is ported from Linux as of Linux kernel com

Re: [PATCH] misc: Port USB251xB/xBi Hi-Speed Hub Controller Driver from Linux

2022-04-13 Thread Marek Vasut
On 4/13/22 09:27, Michal Simek wrote: On 4/10/22 06:27, Marek Vasut wrote: This patch adds a driver for configuration of the Microchip USB251xB/xBi USB 2.0 hub controller series with USB 2.0 upstream connectivity, SMBus configuration interface and two to four USB 2.0 downstream ports. This is

Re: [PATCH] misc: Port USB251xB/xBi Hi-Speed Hub Controller Driver from Linux

2022-04-13 Thread Michal Simek
On 4/10/22 06:27, Marek Vasut wrote: This patch adds a driver for configuration of the Microchip USB251xB/xBi USB 2.0 hub controller series with USB 2.0 upstream connectivity, SMBus configuration interface and two to four USB 2.0 downstream ports. This is ported from Linux as of Linux kernel