Re: [PATCH] mach-snapdragon: Fix overwriting last digit of serial number

2020-04-05 Thread Tom Rini
On Mon, Mar 16, 2020 at 05:51:51PM +0100, Jan-Christoph Tebbe wrote: > When generating the MAC address based on the boards serial number > the last digit was overwritten with the null termination. That way > boards with serial numbers close to each other would use the same > MAC address. > > Sign

Re: [PATCH] mach-snapdragon: Fix overwriting last digit of serial number

2020-04-01 Thread Jan-Christoph Tebbe
Hello Tom, the buffer has to hold 8 hex digits and a trailing \0, therefore 9 bytes should be enough. The problem was, that snprintf was told sn were only 8 characters long, making snprintf to only write 7 digits followed by the trailing \0. Jan-Christoph Am Fr., 20. März 2020 um 18:31 Uhr schri

Re: [PATCH] mach-snapdragon: Fix overwriting last digit of serial number

2020-03-20 Thread Tom Rini
On Mon, Mar 16, 2020 at 05:51:51PM +0100, Jan-Christoph Tebbe wrote: > When generating the MAC address based on the boards serial number > the last digit was overwritten with the null termination. That way > boards with serial numbers close to each other would use the same > MAC address. > > Sign