c...@gmail.com>>
>> Sent: 2023年3月23日 17:34
>> To: Bough Chen mailto:haibo.c...@nxp.com>>
>> Cc: h...@denx.de <mailto:h...@denx.de>; ma...@denx.de
>> <mailto:ma...@denx.de>; u-boot@lists.denx.de <mailto:u-boot@lists.denx.de>;
>> dl-uboot-imx
&g
> -Original Message-
> From: Alexander Kochetkov
> Sent: 2023年3月23日 17:34
> To: Bough Chen
> Cc: h...@denx.de; ma...@denx.de; u-boot@lists.denx.de; dl-uboot-imx
> ; xypron.g...@gmx.de
> Subject: Re: [PATCH] i2c: correct I2C deblock logic
>
> Or even simpler. L
Or even simpler. Like your original patch. If we take into accout Patrik’s
comment from another message:
> but if I assume that GPIO_ACTIVE_HIGH is NOT activated in DT
static void i2c_gpio_set_pin(struct gpio_desc *pin, int bit)
{
if (bit) {
dm_gpio_set_dir_flags(pin, GPIOD_IS_IN);
Hello Haibo Chen!
Setting GPIOD_ACTIVE_LOW has no effect. It filtered out by
dm_gpio_set_dir_flags().
>
>
> if (bit)
> - dm_gpio_set_dir_flags(pin, GPIOD_IS_IN);
> + dm_gpio_set_dir_flags(pin, GPIOD_IS_IN |
> +GPIOD_ACTIVE_LOW);
Here in original code GPIOD_ACTIVE_LOW has not effect.
else
> -Original Message-
> From: Alexander Kochetkov
> Sent: 2023年3月21日 17:50
> To: Bough Chen
> Cc: h...@denx.de; ma...@denx.de; u-boot@lists.denx.de; dl-uboot-imx
> ; xypron.g...@gmx.de; Simon Glass
>
> Subject: Re: [PATCH] i2c: correct I2C deblock logic
>
t bug.
> 21 марта 2023 г., в 11:37, Bough Chen написал(а):
>
>> -Original Message-
>> From: Alexander Kochetkov
>> Sent: 2023年3月20日 16:03
>> To: h...@denx.de
>> Cc: Bough Chen ; ma...@denx.de;
>> u-boot@lists.denx.de; dl-uboot-imx ;
>>
> -Original Message-
> From: Alexander Kochetkov
> Sent: 2023年3月20日 16:03
> To: h...@denx.de
> Cc: Bough Chen ; ma...@denx.de;
> u-boot@lists.denx.de; dl-uboot-imx ;
> xypron.g...@gmx.de; Simon Glass
> Subject: Re: [PATCH] i2c: correct I2C deblock logic
>
>
Hello!
The patch doesn’t add new functionality to the code.
May be it makes code more readable. But in later case the patch description
should be corrected and
Fixes tag removed.
The flag GPIOD_ACTIVE_LOW affects return value dm_gpio_get_value().
And return value doesn’t depends on the DTS setti
Hi!
On 13.03.23 03:55, Bough Chen wrote:
>> -Original Message-
>> From: Bough Chen
>> Sent: 2023年2月10日 17:27
>> To: h...@denx.de; al.koc...@gmail.com; ma...@denx.de
>> Cc: u-boot@lists.denx.de; dl-uboot-imx ;
>> xypron.g...@gmx.de; Bough Chen
>> Subject: [PATCH] i2c: correct I2C deblock
> -Original Message-
> From: Bough Chen
> Sent: 2023年2月10日 17:27
> To: h...@denx.de; al.koc...@gmail.com; ma...@denx.de
> Cc: u-boot@lists.denx.de; dl-uboot-imx ;
> xypron.g...@gmx.de; Bough Chen
> Subject: [PATCH] i2c: correct I2C deblock logic
>
> From: Haibo Chen
>
> Current code us
10 matches
Mail list logo
