Re: [PATCH] fastboot: remove #ifdef CONFIG when it is possible

2023-01-12 Thread Tom Rini
On Thu, Dec 15, 2022 at 10:15:50AM +0100, Patrick Delaunay wrote: > Much of the fastboot code predates the introduction of Kconfig and > has quite a few #ifdefs in it which is unnecessary now that we can use > IS_ENABLED() et al. > > Signed-off-by: Patrick Delaunay > Reviewed-by: Mattijs Korpers

Re: [PATCH] fastboot: remove #ifdef CONFIG when it is possible

2023-01-06 Thread Tom Rini
On Thu, Jan 05, 2023 at 12:37:58PM +0100, Patrick DELAUNAY wrote: > Hi Tom, > > On 1/3/23 21:35, Tom Rini wrote: > > On Thu, Dec 15, 2022 at 10:15:50AM +0100, Patrick Delaunay wrote: > > > Much of the fastboot code predates the introduction of Kconfig and > > > has quite a few #ifdefs in it which

Re: [PATCH] fastboot: remove #ifdef CONFIG when it is possible

2023-01-05 Thread Patrick DELAUNAY
Hi Tom, On 1/3/23 21:35, Tom Rini wrote: On Thu, Dec 15, 2022 at 10:15:50AM +0100, Patrick Delaunay wrote: Much of the fastboot code predates the introduction of Kconfig and has quite a few #ifdefs in it which is unnecessary now that we can use IS_ENABLED() et al. Signed-off-by: Patrick Delaun

Re: [PATCH] fastboot: remove #ifdef CONFIG when it is possible

2023-01-03 Thread Tom Rini
On Thu, Dec 15, 2022 at 10:15:50AM +0100, Patrick Delaunay wrote: > Much of the fastboot code predates the introduction of Kconfig and > has quite a few #ifdefs in it which is unnecessary now that we can use > IS_ENABLED() et al. > > Signed-off-by: Patrick Delaunay > --- > > cmd/fastboot.c

Re: [PATCH] fastboot: remove #ifdef CONFIG when it is possible

2023-01-03 Thread Patrick DELAUNAY
Hi, On 12/15/22 16:40, Sean Anderson wrote: On 12/15/22 04:15, Patrick Delaunay wrote: Much of the fastboot code predates the introduction of Kconfig and has quite a few #ifdefs in it which is unnecessary now that we can use IS_ENABLED() et al. Signed-off-by: Patrick Delaunay ---   cmd/fastb

Re: [PATCH] fastboot: remove #ifdef CONFIG when it is possible

2022-12-15 Thread Mattijs Korpershoek
On Thu, Dec 15, 2022 at 14:45, Mattijs Korpershoek wrote: > On Thu, Dec 15, 2022 at 10:15, Patrick Delaunay > wrote: > >> Much of the fastboot code predates the introduction of Kconfig and >> has quite a few #ifdefs in it which is unnecessary now that we can use >> IS_ENABLED() et al. >> >> Si

Re: [PATCH] fastboot: remove #ifdef CONFIG when it is possible

2022-12-15 Thread Sean Anderson
On 12/15/22 04:15, Patrick Delaunay wrote: > Much of the fastboot code predates the introduction of Kconfig and > has quite a few #ifdefs in it which is unnecessary now that we can use > IS_ENABLED() et al. > > Signed-off-by: Patrick Delaunay > --- > > cmd/fastboot.c | 35

Re: [PATCH] fastboot: remove #ifdef CONFIG when it is possible

2022-12-15 Thread Sean Anderson
On 12/15/22 09:30, Marek Vasut wrote: > On 12/15/22 10:15, Patrick Delaunay wrote: >> Much of the fastboot code predates the introduction of Kconfig and >> has quite a few #ifdefs in it which is unnecessary now that we can use >> IS_ENABLED() et al. >> >> Signed-off-by: Patrick Delaunay >> --- >>

Re: [PATCH] fastboot: remove #ifdef CONFIG when it is possible

2022-12-15 Thread Marek Vasut
On 12/15/22 10:15, Patrick Delaunay wrote: Much of the fastboot code predates the introduction of Kconfig and has quite a few #ifdefs in it which is unnecessary now that we can use IS_ENABLED() et al. Signed-off-by: Patrick Delaunay --- cmd/fastboot.c | 35 +-- dri

Re: [PATCH] fastboot: remove #ifdef CONFIG when it is possible

2022-12-15 Thread Mattijs Korpershoek
On Thu, Dec 15, 2022 at 10:15, Patrick Delaunay wrote: > Much of the fastboot code predates the introduction of Kconfig and > has quite a few #ifdefs in it which is unnecessary now that we can use > IS_ENABLED() et al. > > Signed-off-by: Patrick Delaunay Hi Patrick, Thank you for this, it's a