Re: [PATCH] env: Make _init() expect _INVALID when _IS_NOWHERE

2021-09-24 Thread Tom Rini
On Fri, Sep 24, 2021 at 05:04:27AM +0200, Marek Vasut wrote: > On 9/24/21 4:40 AM, Tom Rini wrote: > > On Thu, Aug 12, 2021 at 03:28:31PM +, Pierre-Clément Tosi wrote: > > > > > Avoid applying the "fix" introduced by commit 5557eec01cbf ("env: Fix > > > invalid env handling in env_init()") to

Re: [PATCH] env: Make _init() expect _INVALID when _IS_NOWHERE

2021-09-23 Thread Marek Vasut
On 9/24/21 4:40 AM, Tom Rini wrote: On Thu, Aug 12, 2021 at 03:28:31PM +, Pierre-Clément Tosi wrote: Avoid applying the "fix" introduced by commit 5557eec01cbf ("env: Fix invalid env handling in env_init()") to the environment "nowhere". This is necessary as that commit, by setting the ret

Re: [PATCH] env: Make _init() expect _INVALID when _IS_NOWHERE

2021-09-23 Thread Tom Rini
On Thu, Aug 12, 2021 at 03:28:31PM +, Pierre-Clément Tosi wrote: > Avoid applying the "fix" introduced by commit 5557eec01cbf ("env: Fix > invalid env handling in env_init()") to the environment "nowhere". > > This is necessary as that commit, by setting the return value of > env_init() to -E

Re: [PATCH] env: Make _init() expect _INVALID when _IS_NOWHERE

2021-08-12 Thread Marek Vasut
On 8/12/21 5:28 PM, Pierre-Clément Tosi wrote: Avoid applying the "fix" introduced by commit 5557eec01cbf ("env: Fix invalid env handling in env_init()") to the environment "nowhere". This is necessary as that commit, by setting the return value of env_init() to -ENOENT if gd->env_valid is ENV_I