Re: [PATCH] doc/develop/codingstyle.rst: Clarify include section

2024-02-12 Thread Tom Rini
On Mon, Feb 12, 2024 at 05:52:03PM +0100, Heinrich Schuchardt wrote: > On 12.02.24 17:19, Tom Rini wrote: > > On Sun, Feb 11, 2024 at 06:53:47PM +0100, Igor Opaniuk wrote: > > > Hi Tom, > > > > > > On Fri, Feb 9, 2024 at 3:52 PM Tom Rini wrote: > > > > > > > > Rework the section about includes s

Re: [PATCH] doc/develop/codingstyle.rst: Clarify include section

2024-02-12 Thread Heinrich Schuchardt
On 12.02.24 17:19, Tom Rini wrote: On Sun, Feb 11, 2024 at 06:53:47PM +0100, Igor Opaniuk wrote: Hi Tom, On Fri, Feb 9, 2024 at 3:52 PM Tom Rini wrote: Rework the section about includes slightly. We should not be using common.h anywhere, so remove that from examples and ask people to send pa

Re: [PATCH] doc/develop/codingstyle.rst: Clarify include section

2024-02-12 Thread Tom Rini
On Sun, Feb 11, 2024 at 06:53:47PM +0100, Igor Opaniuk wrote: > Hi Tom, > > On Fri, Feb 9, 2024 at 3:52 PM Tom Rini wrote: > > > > Rework the section about includes slightly. We should not be using > > common.h anywhere, so remove that from examples and ask people to send > > patches removing it

Re: [PATCH] doc/develop/codingstyle.rst: Clarify include section

2024-02-11 Thread Igor Opaniuk
Hi Tom, On Fri, Feb 9, 2024 at 3:52 PM Tom Rini wrote: > > Rework the section about includes slightly. We should not be using > common.h anywhere, so remove that from examples and ask people to send > patches removing it when found. Doing this also means we need to reword > other parts of this se