Re: [PATCH] cpu: imx8_cpu: Avoid revision to corrupt device tree

2024-10-16 Thread Tom Rini
On Thu, Oct 17, 2024 at 03:14:46AM +, Peng Fan wrote: > > Subject: Re: [PATCH] cpu: imx8_cpu: Avoid revision to corrupt device > > tree > > > > On Fri, Oct 11, 2024 at 06:58:27PM +0800, Peng Fan (OSS) wrote: > > > > > From: Peng Fan > > > >

RE: [PATCH] cpu: imx8_cpu: Avoid revision to corrupt device tree

2024-10-16 Thread Peng Fan
> Subject: Re: [PATCH] cpu: imx8_cpu: Avoid revision to corrupt device > tree > > On Fri, Oct 11, 2024 at 06:58:27PM +0800, Peng Fan (OSS) wrote: > > > From: Peng Fan > > > > U-Boot device tree is padded just after U-Boot proper. After the > whole > > s

Re: [PATCH] cpu: imx8_cpu: Avoid revision to corrupt device tree

2024-10-16 Thread Tom Rini
On Fri, Oct 11, 2024 at 06:58:27PM +0800, Peng Fan (OSS) wrote: > From: Peng Fan > > U-Boot device tree is padded just after U-Boot proper. After the whole > stuff loaded to DRAM space, the device tree area is conflict with BSS > region before U-Boot relocation. So any write to BSS area before >

RE: [PATCH] cpu: imx8_cpu: Avoid revision to corrupt device tree

2024-10-16 Thread Peng Fan
> Subject: Re: [PATCH] cpu: imx8_cpu: Avoid revision to corrupt device > tree > > On Thu, Oct 17, 2024 at 01:10:02AM +, Peng Fan wrote: > > > Subject: Re: [PATCH] cpu: imx8_cpu: Avoid revision to corrupt > device > > > tree > > > > > > On Sa

Re: [PATCH] cpu: imx8_cpu: Avoid revision to corrupt device tree

2024-10-16 Thread Tom Rini
On Thu, Oct 17, 2024 at 01:10:02AM +, Peng Fan wrote: > > Subject: Re: [PATCH] cpu: imx8_cpu: Avoid revision to corrupt device > > tree > > > > On Sat, Oct 12, 2024 at 12:16:14AM +, Peng Fan wrote: > > > > Subject: Re: [PATCH] cpu: imx8_cpu:

RE: [PATCH] cpu: imx8_cpu: Avoid revision to corrupt device tree

2024-10-16 Thread Peng Fan
> Subject: Re: [PATCH] cpu: imx8_cpu: Avoid revision to corrupt device > tree > > On Sat, Oct 12, 2024 at 12:16:14AM +, Peng Fan wrote: > > > Subject: Re: [PATCH] cpu: imx8_cpu: Avoid revision to corrupt > device > > > tree > > > > > > > W

Re: [PATCH] cpu: imx8_cpu: Avoid revision to corrupt device tree

2024-10-16 Thread Tom Rini
On Sat, Oct 12, 2024 at 12:16:14AM +, Peng Fan wrote: > > Subject: Re: [PATCH] cpu: imx8_cpu: Avoid revision to corrupt device > > tree > > > > > Why isn't this padding and alignment with the BSS being taken care > > of > > > in either the linker

Re: [PATCH] cpu: imx8_cpu: Avoid revision to corrupt device tree

2024-10-16 Thread Fabio Estevam
Hi Peng, On Fri, Oct 11, 2024 at 1:56 PM Tom Rini wrote: > Why isn't this padding and alignment with the BSS being taken care of in > either the linker script or the binman dts? I have the same concern as Tom. This fix looks fragile. Can you propose another solution?

RE: [PATCH] cpu: imx8_cpu: Avoid revision to corrupt device tree

2024-10-11 Thread Peng Fan
> Subject: Re: [PATCH] cpu: imx8_cpu: Avoid revision to corrupt device > tree > > > Why isn't this padding and alignment with the BSS being taken care > of > > in either the linker script or the binman dts? Sorry, I am not sure what you mean. Add a alignment in bin

Re: [PATCH] cpu: imx8_cpu: Avoid revision to corrupt device tree

2024-10-11 Thread Fabio Estevam
> Why isn't this padding and alignment with the BSS being taken care of in > either the linker script or the binman dts? Peng, in addition to Tom's comment: which commit caused the problem? Please add a Fixes tag.

Re: [PATCH] cpu: imx8_cpu: Avoid revision to corrupt device tree

2024-10-11 Thread Tom Rini
On Fri, Oct 11, 2024 at 06:58:27PM +0800, Peng Fan (OSS) wrote: > From: Peng Fan > > U-Boot device tree is padded just after U-Boot proper. After the whole > stuff loaded to DRAM space, the device tree area is conflict with BSS > region before U-Boot relocation. So any write to BSS area before >