Re: [PATCH] clk: k210: Fix error calculation on 32bit

2022-10-16 Thread Michal Suchánek
Hello, On Sun, Oct 16, 2022 at 05:02:38PM +0200, Heinrich Schuchardt wrote: > > > On 10/16/22 16:57, Sean Anderson wrote: > > On 10/16/22 10:50, Heinrich Schuchardt wrote: > > > > > > > > > On 10/16/22 16:48, Sean Anderson wrote: > > > > On 10/16/22 10:40, Heinrich Schuchardt wrote: > > > > >

Re: [PATCH] clk: k210: Fix error calculation on 32bit

2022-10-16 Thread Heinrich Schuchardt
On 10/16/22 16:57, Sean Anderson wrote: On 10/16/22 10:50, Heinrich Schuchardt wrote: On 10/16/22 16:48, Sean Anderson wrote: On 10/16/22 10:40, Heinrich Schuchardt wrote: On 10/16/22 16:19, Sean Anderson wrote: On 10/16/22 07:46, Heinrich Schuchardt wrote: On 10/16/22 09:51, Michal

Re: [PATCH] clk: k210: Fix error calculation on 32bit

2022-10-16 Thread Sean Anderson
On 10/16/22 10:50, Heinrich Schuchardt wrote: On 10/16/22 16:48, Sean Anderson wrote: On 10/16/22 10:40, Heinrich Schuchardt wrote: On 10/16/22 16:19, Sean Anderson wrote: On 10/16/22 07:46, Heinrich Schuchardt wrote: On 10/16/22 09:51, Michal Suchánek wrote: On Thu, Oct 13, 2022 at 10

Re: [PATCH] clk: k210: Fix error calculation on 32bit

2022-10-16 Thread Heinrich Schuchardt
On 10/16/22 16:48, Sean Anderson wrote: On 10/16/22 10:40, Heinrich Schuchardt wrote: On 10/16/22 16:19, Sean Anderson wrote: On 10/16/22 07:46, Heinrich Schuchardt wrote: On 10/16/22 09:51, Michal Suchánek wrote: On Thu, Oct 13, 2022 at 10:34:29PM +0200, Michal Suchanek wrote: k210 i

Re: [PATCH] clk: k210: Fix error calculation on 32bit

2022-10-16 Thread Sean Anderson
On 10/16/22 10:40, Heinrich Schuchardt wrote: On 10/16/22 16:19, Sean Anderson wrote: On 10/16/22 07:46, Heinrich Schuchardt wrote: On 10/16/22 09:51, Michal Suchánek wrote: On Thu, Oct 13, 2022 at 10:34:29PM +0200, Michal Suchanek wrote: k210 is 64bit but the driver and tests are also bu

Re: [PATCH] clk: k210: Fix error calculation on 32bit

2022-10-16 Thread Heinrich Schuchardt
On 10/16/22 16:19, Sean Anderson wrote: On 10/16/22 07:46, Heinrich Schuchardt wrote: On 10/16/22 09:51, Michal Suchánek wrote: On Thu, Oct 13, 2022 at 10:34:29PM +0200, Michal Suchanek wrote: k210 is 64bit but the driver and tests are also built in sandbox, and that can be built 32bit.

Re: [PATCH] clk: k210: Fix error calculation on 32bit

2022-10-16 Thread Sean Anderson
On 10/16/22 07:46, Heinrich Schuchardt wrote: On 10/16/22 09:51, Michal Suchánek wrote: On Thu, Oct 13, 2022 at 10:34:29PM +0200, Michal Suchanek wrote: k210 is 64bit but the driver and tests are also built in sandbox, and that can be built 32bit. BIT(32) does not work on 32bit, shift before

Re: [PATCH] clk: k210: Fix error calculation on 32bit

2022-10-16 Thread Heinrich Schuchardt
On 10/16/22 09:51, Michal Suchánek wrote: On Thu, Oct 13, 2022 at 10:34:29PM +0200, Michal Suchanek wrote: k210 is 64bit but the driver and tests are also built in sandbox, and that can be built 32bit. BIT(32) does not work on 32bit, shift before subtraction to fit into 32bit integer with BI

Re: [PATCH] clk: k210: Fix error calculation on 32bit

2022-10-16 Thread Michal Suchánek
On Thu, Oct 13, 2022 at 10:34:29PM +0200, Michal Suchanek wrote: > k210 is 64bit but the driver and tests are also built in sandbox, and > that can be built 32bit. > > BIT(32) does not work on 32bit, shift before subtraction to fit into > 32bit integer with BIT values. Also see https://patchwork