Re: [PATCH] board: gw_ventana: gsc: fix GSC read/write functions

2022-03-31 Thread Tom Rini
On Thu, Mar 24, 2022 at 08:32:00AM -0700, Tim Harvey wrote: > commit 7c84319af9c7 ("dm: gpio: Correct use of -ENODEV in drivers") > changed the return code for an I2C NAK from -ENODEV to -EREMOTEIO. > > Update the gsc_i2c_read and gsc_i2c_write functions for this change > to properly retry the tr

Re: [PATCH] board: gw_ventana: gsc: fix GSC read/write functions

2022-03-29 Thread Tim Harvey
On Mon, Mar 28, 2022 at 12:53 PM Fabio Estevam wrote: > > Hi Tim, > > On Mon, Mar 28, 2022 at 4:24 PM Tim Harvey wrote: > > > Any other feedback on this? Regardless of if I2C drivers should return > > the same error code as Linux on a NAK, I would like to get this patch > > applied to fix the cur

Re: [PATCH] board: gw_ventana: gsc: fix GSC read/write functions

2022-03-28 Thread Fabio Estevam
Hi Tim, On Mon, Mar 28, 2022 at 4:24 PM Tim Harvey wrote: > Any other feedback on this? Regardless of if I2C drivers should return > the same error code as Linux on a NAK, I would like to get this patch > applied to fix the current regression for the upcoming v2022.04. Agreed, let's fix the reg

Re: [PATCH] board: gw_ventana: gsc: fix GSC read/write functions

2022-03-28 Thread Tim Harvey
On Thu, Mar 24, 2022 at 9:04 AM Tim Harvey wrote: > > On Thu, Mar 24, 2022 at 8:59 AM Fabio Estevam wrote: > > > > Hi Tim, > > > > On Thu, Mar 24, 2022 at 12:32 PM Tim Harvey wrote: > > > > > > commit 7c84319af9c7 ("dm: gpio: Correct use of -ENODEV in drivers") > > > changed the return code for

Re: [PATCH] board: gw_ventana: gsc: fix GSC read/write functions

2022-03-24 Thread Tim Harvey
On Thu, Mar 24, 2022 at 8:59 AM Fabio Estevam wrote: > > Hi Tim, > > On Thu, Mar 24, 2022 at 12:32 PM Tim Harvey wrote: > > > > commit 7c84319af9c7 ("dm: gpio: Correct use of -ENODEV in drivers") > > changed the return code for an I2C NAK from -ENODEV to -EREMOTEIO. > > I think we should be consi

Re: [PATCH] board: gw_ventana: gsc: fix GSC read/write functions

2022-03-24 Thread Fabio Estevam
Hi Tim, On Thu, Mar 24, 2022 at 12:32 PM Tim Harvey wrote: > > commit 7c84319af9c7 ("dm: gpio: Correct use of -ENODEV in drivers") > changed the return code for an I2C NAK from -ENODEV to -EREMOTEIO. I think we should be consistent with Linux and return -ENXIO for the NACK case: https://git.kern