Re: [PATCH u-boot 2/4] eth/r8152: reset PHY after setting it

2020-06-10 Thread Marek Vasut
On 6/10/20 11:47 AM, Hayes Wang wrote: > Marek Vasut [mailto:ma...@denx.de] >> Sent: Tuesday, June 09, 2020 10:22 PM > [...] >>> - bmcr = BMCR_ANENABLE | BMCR_ANRESTART; >>> + bmcr = BMCR_ANENABLE | BMCR_ANRESTART | BMCR_RESET; >> >> Do you really need to reset a PHY while reset

RE: [PATCH u-boot 2/4] eth/r8152: reset PHY after setting it

2020-06-10 Thread Hayes Wang
Marek Vasut [mailto:ma...@denx.de] > Sent: Tuesday, June 09, 2020 10:22 PM [...] > > - bmcr = BMCR_ANENABLE | BMCR_ANRESTART; > > + bmcr = BMCR_ANENABLE | BMCR_ANRESTART | BMCR_RESET; > > Do you really need to reset a PHY while resetting the autonegotiation ? > I think if you r

Re: [PATCH u-boot 2/4] eth/r8152: reset PHY after setting it

2020-06-09 Thread Marek Vasut
On 6/9/20 10:53 AM, Hayes Wang wrote: > Some settings of PHY have to work after resetting PHY. > > Signed-off-by: Hayes Wang > --- > drivers/usb/eth/r8152.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/eth/r8152.c b/drivers/usb/eth/r8152.c > index dbb1721