Re: [PATCH 09/16] pinctrl: renesas: Add RZ/G2L PFC driver

2023-10-05 Thread Marek Vasut
On 10/5/23 11:39, Paul Barker wrote: On 05/10/2023 03:24, Marek Vasut wrote: On 10/4/23 21:43, Paul Barker wrote: [...] +/* + * We need to ensure that the module clock is enabled and all resets are + * de-asserted before using either the gpio or pinctrl functionality. Error + * handling can b

Re: [PATCH 09/16] pinctrl: renesas: Add RZ/G2L PFC driver

2023-10-05 Thread Paul Barker
On 05/10/2023 03:24, Marek Vasut wrote: > On 10/4/23 21:43, Paul Barker wrote: > > [...] > >> +/* >> + * We need to ensure that the module clock is enabled and all resets are >> + * de-asserted before using either the gpio or pinctrl functionality. >> Error >> + * handling ca

Re: [PATCH 09/16] pinctrl: renesas: Add RZ/G2L PFC driver

2023-10-04 Thread Marek Vasut
On 10/4/23 21:43, Paul Barker wrote: [...] +/* + * We need to ensure that the module clock is enabled and all resets are + * de-asserted before using either the gpio or pinctrl functionality. Error + * handling can be quite simple here as if the PFC cannot be enabled then we + * will not be abl

Re: [PATCH 09/16] pinctrl: renesas: Add RZ/G2L PFC driver

2023-10-04 Thread Paul Barker
On Wed, Oct 04, 2023 at 02:24:38PM +0200, Marek Vasut wrote: > On 10/4/23 10:40, Paul Barker wrote: > > On 03/10/2023 14:20, Marek Vasut wrote: > > > On 9/20/23 14:42, Paul Barker wrote: > > > > This driver provides pinctrl and gpio control for the Renesas RZ/G2L > > > > (R9A07G044) SoC. > > > > >

RE: [PATCH 09/16] pinctrl: renesas: Add RZ/G2L PFC driver

2023-10-04 Thread Biju Das
Hi Paul Barker, > Subject: Re: [PATCH 09/16] pinctrl: renesas: Add RZ/G2L PFC driver > > On Wed, Oct 04, 2023 at 12:56:14PM +, Biju Das wrote: > > Hi Marek and Paul, > > > > > Subject: Re: [PATCH 09/16] pinctrl: renesas: Add RZ/G2L PFC driver > > > &g

RE: [PATCH 09/16] pinctrl: renesas: Add RZ/G2L PFC driver

2023-10-04 Thread Biju Das
Hi Marek, > Subject: Re: [PATCH 09/16] pinctrl: renesas: Add RZ/G2L PFC driver > > On 10/4/23 14:56, Biju Das wrote: > > [...] > > >>>>> + return -EINVAL; > >>>>> + } > >>>>> + > >>>>&g

Re: [PATCH 09/16] pinctrl: renesas: Add RZ/G2L PFC driver

2023-10-04 Thread Marek Vasut
On 10/4/23 14:56, Biju Das wrote: [...] + return -EINVAL; + } + + uc_priv->gpio_count = args.args[2]; + return rzg2l_pfc_enable(dev); +} + +U_BOOT_DRIVER(rzg2l_pfc_gpio) = { + .name = "rzg2l-pfc-gpio", + .id = UCLASS_GPIO, +

Re: [PATCH 09/16] pinctrl: renesas: Add RZ/G2L PFC driver

2023-10-04 Thread Paul Barker
On Wed, Oct 04, 2023 at 12:56:14PM +, Biju Das wrote: > Hi Marek and Paul, > > > Subject: Re: [PATCH 09/16] pinctrl: renesas: Add RZ/G2L PFC driver > > > > On 10/4/23 10:40, Paul Barker wrote: > > > On 03/10/2023 14:20, Marek Vasut wrote: > >

RE: [PATCH 09/16] pinctrl: renesas: Add RZ/G2L PFC driver

2023-10-04 Thread Biju Das
Hi Marek and Paul, > Subject: Re: [PATCH 09/16] pinctrl: renesas: Add RZ/G2L PFC driver > > On 10/4/23 10:40, Paul Barker wrote: > > On 03/10/2023 14:20, Marek Vasut wrote: > >> On 9/20/23 14:42, Paul Barker wrote: > >>> This driver provides pinctrl and

Re: [PATCH 09/16] pinctrl: renesas: Add RZ/G2L PFC driver

2023-10-04 Thread Marek Vasut
On 10/4/23 10:40, Paul Barker wrote: On 03/10/2023 14:20, Marek Vasut wrote: On 9/20/23 14:42, Paul Barker wrote: This driver provides pinctrl and gpio control for the Renesas RZ/G2L (R9A07G044) SoC. This patch is based on the corresponding Linux v6.5 driver. Signed-off-by: Paul Barker Revie

Re: [PATCH 09/16] pinctrl: renesas: Add RZ/G2L PFC driver

2023-10-04 Thread Paul Barker
On 03/10/2023 14:20, Marek Vasut wrote: > On 9/20/23 14:42, Paul Barker wrote: >> This driver provides pinctrl and gpio control for the Renesas RZ/G2L >> (R9A07G044) SoC. >> >> This patch is based on the corresponding Linux v6.5 driver. >> >> Signed-off-by: Paul Barker >> Reviewed-by: Biju Das >>

Re: [PATCH 09/16] pinctrl: renesas: Add RZ/G2L PFC driver

2023-10-03 Thread Marek Vasut
On 9/20/23 14:42, Paul Barker wrote: This driver provides pinctrl and gpio control for the Renesas RZ/G2L (R9A07G044) SoC. This patch is based on the corresponding Linux v6.5 driver. Signed-off-by: Paul Barker Reviewed-by: Biju Das Reviewed-by: Lad Prabhakar --- arch/arm/mach-rmobile/Kconf