Re: [PATCH] env: Allow string CONFIG options in the text environment

2022-11-10 Thread Simon Glass
Hi Tom, On Mon, 7 Nov 2022 at 10:29, Tom Rini wrote: > > On Mon, Nov 07, 2022 at 04:33:28PM +, Holger Brunck wrote: > > Hi Tom, > > > > > > > On Fri, 4 Nov 2022 at 08:20, Holger Brunck > > > > > wrote: > > > > >> > > > > >> Hi Simon, > > > > >> I got no time to try it yet but I have a gener

Re: [PATCH] env: Allow string CONFIG options in the text environment

2022-11-07 Thread Tom Rini
On Mon, Nov 07, 2022 at 04:33:28PM +, Holger Brunck wrote: > Hi Tom, > > > > > On Fri, 4 Nov 2022 at 08:20, Holger Brunck > > > > wrote: > > > >> > > > >> Hi Simon, > > > >> I got no time to try it yet but I have a general comment. > > > >> > > > >>> > > > >>> Sometimes it is useful to includ

RE: [PATCH] env: Allow string CONFIG options in the text environment

2022-11-07 Thread Holger Brunck
Hi Tom, > > > On Fri, 4 Nov 2022 at 08:20, Holger Brunck > > > wrote: > > >> > > >> Hi Simon, > > >> I got no time to try it yet but I have a general comment. > > >> > > >>> > > >>> Sometimes it is useful to include a CONFIG option that contains a > > >>> string. > > >>> This is hard to do in ge

Re: [PATCH] env: Allow string CONFIG options in the text environment

2022-11-07 Thread Tom Rini
On Mon, Nov 07, 2022 at 11:12:48AM +0100, Rasmus Villemoes wrote: > On 04/11/2022 20.08, Simon Glass wrote: > > Hi Holger, > > > > On Fri, 4 Nov 2022 at 08:20, Holger Brunck > > wrote: > >> > >> Hi Simon, > >> I got no time to try it yet but I have a general comment. > >> > >>> > >>> Sometimes it

RE: [PATCH] env: Allow string CONFIG options in the text environment

2022-11-07 Thread Holger Brunck
> > On Fri, 4 Nov 2022 at 08:20, Holger Brunck > > wrote: > >> > >> Hi Simon, > >> I got no time to try it yet but I have a general comment. > >> > >>> > >>> Sometimes it is useful to include a CONFIG option that contains a string. > >>> This is hard to do in general, since in many cases it is use

Re: [PATCH] env: Allow string CONFIG options in the text environment

2022-11-07 Thread Rasmus Villemoes
On 04/11/2022 20.08, Simon Glass wrote: > Hi Holger, > > On Fri, 4 Nov 2022 at 08:20, Holger Brunck > wrote: >> >> Hi Simon, >> I got no time to try it yet but I have a general comment. >> >>> >>> Sometimes it is useful to include a CONFIG option that contains a string. >>> This is hard to do in

Re: [PATCH] env: Allow string CONFIG options in the text environment

2022-11-04 Thread Simon Glass
Hi Holger, On Fri, 4 Nov 2022 at 08:20, Holger Brunck wrote: > > Hi Simon, > I got no time to try it yet but I have a general comment. > > > > > Sometimes it is useful to include a CONFIG option that contains a string. > > This is hard to do in general, since in many cases it is useful to have th

RE: [PATCH] env: Allow string CONFIG options in the text environment

2022-11-04 Thread Holger Brunck
Hi Simon, I got no time to try it yet but I have a general comment. > > Sometimes it is useful to include a CONFIG option that contains a string. > This is hard to do in general, since in many cases it is useful to have the > quotes > around the string so that, for example: > wouldn't it be cl