Re: Improvements to FIT ciphering

2020-09-10 Thread Patrick Oppenlander
Hi Philippe, On Fri, Sep 11, 2020 at 2:08 AM Philippe REYNES wrote: > > Hi Patrick, > > Sorry for the late answer, I was very busy in the beginning of september No problem at all. I have a product deadline at the end of September rapidly approaching so I am also extremely busy at the moment. >

Re: Improvements to FIT ciphering

2020-09-10 Thread Philippe REYNES
Hi Patrick, Sorry for the late answer, I was very busy in the beginning of september >> >> I agree that IV should be set in the FIT. >> >> So in the dts, we may have: >> cipher { >> algo = "aes256"; >> key-name-hint = "aeskey"; >> iv = "aesiv"; >> }; >> or (I propose) : >> cipher { >> algo = "a

Re: Improvements to FIT ciphering

2020-08-24 Thread Patrick Oppenlander
On Tue, Aug 25, 2020 at 1:57 AM Philippe REYNES wrote: > > I agree that IV should be set in the FIT. > > So in the dts, we may have: > cipher { > algo = "aes256"; > key-name-hint = "aeskey"; > iv = "aesiv"; > }; > or (I propose) : >

Re: Improvements to FIT ciphering

2020-08-24 Thread Philippe REYNES
Hi Patrick, >> >> Hi Patrick, >> >> Sorry for this late anwser, I was very busy this week. > > No problem! Again, sorry I was off and then busy. > Before I address your comments below, is there anything else I need to > do with the previous patches I posted? I haven't contributed to U-Boot >

Re: Improvements to FIT ciphering

2020-08-07 Thread Patrick Oppenlander
On Sat, Aug 8, 2020 at 3:03 AM Philippe REYNES wrote: > > Hi Patrick, > > Sorry for this late anwser, I was very busy this week. No problem! Before I address your comments below, is there anything else I need to do with the previous patches I posted? I haven't contributed to U-Boot before and I'

Re: Improvements to FIT ciphering

2020-08-07 Thread Philippe REYNES
Hi Patrick, Sorry for this late anwser, I was very busy this week. > Hi Simon & Philippe, > > I've been thinking about this some more and have added a few points > below. I will need feedback before proposing any patches for the > remaining issues. > > On Fri, Jul 24, 2020 at 12:06 PM Patrick O

Re: Improvements to FIT ciphering

2020-07-30 Thread Patrick Oppenlander
Hi Simon & Philippe, I've been thinking about this some more and have added a few points below. I will need feedback before proposing any patches for the remaining issues. On Fri, Jul 24, 2020 at 12:06 PM Patrick Oppenlander wrote: > > Issue #1 > > > Currently, mkimage treats the IV in

Re: Improvements to FIT ciphering

2020-07-29 Thread Philippe REYNES
Hi Simon and Patrick, Sorry, I've missed this serie of patches. I check them and send a review ASAP. Regards, Philippe > +Philippe Reynes too > > > On Mon, 27 Jul 2020 at 16:50, Patrick Oppenlander > wrote: >> >> On Fri, Jul 24, 2020 at 12:06 PM Patrick Oppenlander >> wrote: >> > >> > H

Re: Improvements to FIT ciphering

2020-07-28 Thread Simon Glass
+Philippe Reynes too On Mon, 27 Jul 2020 at 16:50, Patrick Oppenlander wrote: > > On Fri, Jul 24, 2020 at 12:06 PM Patrick Oppenlander > wrote: > > > > Hi, > > > > I recently posted some patches to the list [1], [2], [3] to address > > some issues with the cipher support in mkimage. Hopefully s

Re: Improvements to FIT ciphering

2020-07-27 Thread Patrick Oppenlander
On Fri, Jul 24, 2020 at 12:06 PM Patrick Oppenlander wrote: > > Hi, > > I recently posted some patches to the list [1], [2], [3] to address > some issues with the cipher support in mkimage. Hopefully someone gets > a chance to review these patches as I think mkimage is a bit broken > without them.

Improvements to FIT ciphering

2020-07-23 Thread Patrick Oppenlander
Hi, I recently posted some patches to the list [1], [2], [3] to address some issues with the cipher support in mkimage. Hopefully someone gets a chance to review these patches as I think mkimage is a bit broken without them. While considering using U-Boot cipher support in a product I work on, I