Re: [PATCH v2] qcom_defconfig: Add VID/PID to represent fastboot device

2025-07-25 Thread Casey Connolly
On 24/07/2025 13:19, Sumit Garg wrote: > From: Sumit Garg > > Currently fastboot mode is enumerated as VID/PID: : which is > not appropriate. On Qcom platforms, fastboot mode is rather enumerated > as VID/PID: 18d1:d00d in ABL or from fastboot.efi app. So lets use the

Re: [PATCH v2] qcom_defconfig: Add VID/PID to represent fastboot device

2025-07-24 Thread neil . armstrong
On 24/07/2025 13:19, Sumit Garg wrote: From: Sumit Garg Currently fastboot mode is enumerated as VID/PID: : which is not appropriate. On Qcom platforms, fastboot mode is rather enumerated as VID/PID: 18d1:d00d in ABL or from fastboot.efi app. So lets use the same VID/PID pair in U-Boot

[PATCH v2] qcom_defconfig: Add VID/PID to represent fastboot device

2025-07-24 Thread Sumit Garg
From: Sumit Garg Currently fastboot mode is enumerated as VID/PID: : which is not appropriate. On Qcom platforms, fastboot mode is rather enumerated as VID/PID: 18d1:d00d in ABL or from fastboot.efi app. So lets use the same VID/PID pair in U-Boot to represent fastboot mode. Signed-off

[PATCH] qcom_defconfig: Add VID/PID to represent fastboot device

2025-07-24 Thread Sumit Garg
From: Sumit Garg Currently fastboot mode is enumerated as VID/PID: : which is not appropriate. On Qcom platforms, fastboot mode is rather enumerated as VID/PID: 18d1:d00d in ABL or from fastboot.efi app. So lets use the same VID/PID pair in U-Boot to represent fastboot mode. Signed-off

Re: [PATCH] fastboot: Fix off by 1 error

2025-07-22 Thread Tom Rini
> [...] Applied to u-boot/master, thanks! [1/1] fastboot: Fix off by 1 error commit: 23d2c182d4be9f993a4e4d8f4fc6293e4d5a9ff8 -- Tom

Re: [PATCH v3] drivers: fastboot: Add support for SPI flash memory

2025-07-22 Thread Tom Rini
On Thu, 17 Jul 2025 10:58:54 -0300, Ariel D'Alessandro wrote: > Fastboot currently supports MMC and NAND flash devices. Similarly, > extend the support to SPI flash memories. > > Note that in this initial implementation, partitions on the device are > not supported yet, but r

Re: [PATCH v1 0/6] Enable fastboot support for IPQ9574 based boards

2025-07-22 Thread Casey Connolly
Hi Varadarajan, >>>> >>>> On 7/15/25 12:15, Varadarajan Narayanan wrote: >>>>> This series enables MMC based fastboot flashing for IPQ9574 boards. >>>>> For this the following are added/enabled >>>>> * USB2 & USB3 phys support &g

Re: [PATCH RFT v6 1/3] fastboot: blk: introduce fastboot block flashing support

2025-07-21 Thread Neil Armstrong
Hi, On 02/07/2025 04:59, Lothar Waßmann wrote: Hi, On Mon, 30 Jun 2025 17:19:57 +0200 Neil Armstrong wrote: From: Dmitrii Merkurev Introduce fastboot block flashing functions and helpers to be shared with the MMC implementation. The write logic comes from the mmc implementation, while the

Re: [PATCH v3] drivers: fastboot: Add support for SPI flash memory

2025-07-18 Thread Mattijs Korpershoek
Hi Ariel, Thank you for the patch. On Thu, Jul 17, 2025 at 10:58, Ariel D'Alessandro wrote: > Fastboot currently supports MMC and NAND flash devices. Similarly, > extend the support to SPI flash memories. > > Note that in this initial implementation, partitions on the

Re: [PATCH] fastboot: Fix off by 1 error

2025-07-18 Thread Mattijs Korpershoek
issue found by Smatch. This issue was* > > Signed-off-by: Andrew Goodbody Good catch! Reviewed-by: Mattijs Korpershoek > --- > drivers/fastboot/fb_command.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/fastboot/fb_command.c b/d

Re: [PATCH v1 0/6] Enable fastboot support for IPQ9574 based boards

2025-07-18 Thread Varadarajan Narayanan
yanan wrote: > >>> This series enables MMC based fastboot flashing for IPQ9574 boards. > >>> For this the following are added/enabled > >>> * USB2 & USB3 phys support > >>> * USB Gadget support, Fastboot-MMC related configs > >>> *

[PATCH v3] drivers: fastboot: Add support for SPI flash memory

2025-07-17 Thread Ariel D'Alessandro
Fastboot currently supports MMC and NAND flash devices. Similarly, extend the support to SPI flash memories. Note that in this initial implementation, partitions on the device are not supported yet, but raw partitions can be set in U-Boot environment. To define a raw partition descriptor, add an

Re: [PATCH v2] drivers: fastboot: Add support for SPI flash memory

2025-07-17 Thread Ariel D'Alessandro
Hi Mattijs, On 7/17/25 3:30 AM, Mattijs Korpershoek wrote: Hi Ariel, Thank you for the patch. On Tue, Jul 15, 2025 at 16:11, Ariel D'Alessandro wrote: Fastboot currently supports MMC and NAND flash devices. Similarly, extend the support to SPI flash memories. Note that in this in

Re: [PATCH v1 0/6] Enable fastboot support for IPQ9574 based boards

2025-07-17 Thread Casey Connolly
On 16/07/2025 06:57, Varadarajan Narayanan wrote: > On Tue, Jul 15, 2025 at 02:30:09PM +0200, Casey Connolly wrote: >> Hi Varadarajan, >> >> On 7/15/25 12:15, Varadarajan Narayanan wrote: >>> This series enables MMC based fastboot flashing for IPQ9574 boards.

[PATCH] fastboot: Fix off by 1 error

2025-07-17 Thread Andrew Goodbody
strlen only reports length of string not including terminating 0 byte but this has to be included in length of receiving buffer on copy so adjust length check to be correct. This issue found by Smatch. Signed-off-by: Andrew Goodbody --- drivers/fastboot/fb_command.c | 2 +- 1 file changed, 1

Re: [PATCH v2] drivers: fastboot: Add support for SPI flash memory

2025-07-16 Thread Mattijs Korpershoek
Hi Ariel, Thank you for the patch. On Tue, Jul 15, 2025 at 16:11, Ariel D'Alessandro wrote: > Fastboot currently supports MMC and NAND flash devices. Similarly, > extend the support to SPI flash memories. > > Note that in this initial implementation, partitions on the

Re: [PATCH v1 0/6] Enable fastboot support for IPQ9574 based boards

2025-07-15 Thread Varadarajan Narayanan
On Tue, Jul 15, 2025 at 02:30:09PM +0200, Casey Connolly wrote: > Hi Varadarajan, > > On 7/15/25 12:15, Varadarajan Narayanan wrote: > > This series enables MMC based fastboot flashing for IPQ9574 boards. > > For this the following are added/enabled > > * USB2 &

[PATCH v2] drivers: fastboot: Add support for SPI flash memory

2025-07-15 Thread Ariel D'Alessandro
Fastboot currently supports MMC and NAND flash devices. Similarly, extend the support to SPI flash memories. Note that in this initial implementation, partitions on the device are not supported yet, but raw partitions can be set in u-boot environment. To define a raw partition descriptor, add an

Re: [PATCH] drivers: fastboot: Add support for SPI flash memory

2025-07-15 Thread Ariel D'Alessandro
Hi Tom, On 7/15/25 2:50 PM, Tom Rini wrote: On Tue, Jul 15, 2025 at 02:23:11PM -0300, Ariel D'Alessandro wrote: [...] diff --git a/drivers/fastboot/Kconfig b/drivers/fastboot/Kconfig index 70207573de2..0cf955ef53d 100644 --- a/drivers/fastboot/Kconfig +++ b/drivers/fastboot/Kconfig @@

[PATCH] drivers: fastboot: Add support for SPI flash memory

2025-07-15 Thread Ariel D'Alessandro
Fastboot currently supports MMC and NAND flash devices. Similarly, extend the support to SPI flash memories. Note that in this initial implementation, partitions on the device are not supported yet, but raw partitions can be set in u-boot environment. To define a raw partition descriptor, add an

Re: [PATCH] drivers: fastboot: Add support for SPI flash memory

2025-07-15 Thread Tom Rini
On Tue, Jul 15, 2025 at 02:23:11PM -0300, Ariel D'Alessandro wrote: > Fastboot currently supports MMC and NAND flash devices. Similarly, > extend the support to SPI flash memories. > > Note that in this initial implementation, partitions on the device are > not supported yet

Re: [PATCH v1 0/6] Enable fastboot support for IPQ9574 based boards

2025-07-15 Thread Casey Connolly
Hi Varadarajan, On 7/15/25 12:15, Varadarajan Narayanan wrote: This series enables MMC based fastboot flashing for IPQ9574 boards. For this the following are added/enabled * USB2 & USB3 phys support * USB Gadget support, Fastboot-MMC related configs * Flashing rel

[PATCH v1 4/6] configs: ipq9574: Enable fastboot support

2025-07-15 Thread Varadarajan Narayanan
Enable relevant configs like USB PHY, gadget, fastboot, fastboot MMC support etc. to enable fastboot flashing of IPQ9574 based boards. Signed-off-by: Varadarajan Narayanan --- configs/qcom_ipq9574_mmc_defconfig | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff

[PATCH v1 0/6] Enable fastboot support for IPQ9574 based boards

2025-07-15 Thread Varadarajan Narayanan
This series enables MMC based fastboot flashing for IPQ9574 boards. For this the following are added/enabled * USB2 & USB3 phys support * USB Gadget support, Fastboot-MMC related configs * Flashing related documentation Varadarajan Narayanan (6): clk/qcom: Add

Re: [PATCH] fastboot: fb_mmc: Fix write/erase logic when buffer address is zero

2025-07-11 Thread Mattijs Korpershoek
&series=&q=&delegate=&archive=both Is it possible that you are not subscribed to the u-boot mailing list? Maybe it got (wrongly) filtered out as spam. If possible, please re-send it so that it gets properly tracked on the public mailing list. Thanks Mattijs > --- > drive

Re: [PATCH] fastboot: Fix has-slot command always returning yes for fb_nand

2025-07-11 Thread Mattijs Korpershoek
ting positive return values to -ENOENT in > fastboot_nand_get_part_info to match the expected error convention. > > Signed-off-by: Chance Yang > --- > drivers/fastboot/fb_nand.c | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/drivers/fastboot/fb_nand.c b/drivers/fastb

[PATCH 7/9] configs: e850-96: Enable USB gadget and fastboot

2025-07-09 Thread Sam Protsenko
to instantiate the peripheral driver, i.e. dwc3_generic_peripheral_probe() - USB VID and PID - DFU - Fastboot (including flashing to eMMC boot partitions) As all Exynos firmware binaries (including U-Boot) are contained in eMMC boot partition A (mmc0boot0), because that's where Boo

Re: [PATCH RFT v6 1/3] fastboot: blk: introduce fastboot block flashing support

2025-07-09 Thread Mattijs Korpershoek
wrote: >> From: Dmitrii Merkurev >> >> Introduce fastboot block flashing functions and helpers >> to be shared with the MMC implementation. >> >> The write logic comes from the mmc implementation, while >> the partition lookup is much simpler and could b

[PATCH] fastboot: Fix has-slot command always returning yes for fb_nand

2025-07-08 Thread Chance Yang
o passed it directly to getvar_get_part_info, which treated 1 >= 0 as success, causing has-slot to always return yes. Fix by converting positive return values to -ENOENT in fastboot_nand_get_part_info to match the expected error convention. Signed-off-by: Chance Yang --- drivers/fastboot/fb

Re: [PATCH RFT v6 3/3] fastboot: integrate block flashing back-end

2025-07-02 Thread Mattijs Korpershoek
d-off-by: Dmitrii Merkurev > Reviewed-by: Mattijs Korpershoek > Tested-by: Mattijs Korpershoek > Signed-off-by: Neil Armstrong > --- > drivers/fastboot/Kconfig | 32 ++++++-- > drivers/fastboot/Makefile | 1 + >

Re: [PATCH RFT v6 1/3] fastboot: blk: introduce fastboot block flashing support

2025-07-01 Thread Lothar Waßmann
Hi, On Mon, 30 Jun 2025 17:19:57 +0200 Neil Armstrong wrote: > From: Dmitrii Merkurev > > Introduce fastboot block flashing functions and helpers > to be shared with the MMC implementation. > > The write logic comes from the mmc implementation, while > the partition looku

Re: [PATCH v1 2/2] configs: qcom_qcs9100: Fix fastboot buffer address for QCS9100 board

2025-06-30 Thread Balaji Selvanathan
Hi Casey, Thanks for the detailed review and context. You're right — I had overlooked the fact that the default environment already defines a fastboot alias using $fastboot_addr_r, which is a safer and more flexible approach. I agree that relying on a hardcoded address

Re: [PATCH v1 2/2] configs: qcom_qcs9100: Fix fastboot buffer address for QCS9100 board

2025-06-30 Thread Casey Connolly
On 30/06/2025 09:00, Balaji Selvanathan wrote: > The default value of CONFIG_FASTBOOT_BUF_ADDR is 0, which causes > NULL pointer dereference during fastboot commands. > > Set it to 0xdb30, a safe and sufficiently large region in RAM > of the QCS9100 board, to prevent cra

[PATCH RFT v6 2/3] fastboot: blk: switch emmc to use the block helpers

2025-06-30 Thread Neil Armstrong
From: Dmitrii Merkurev Switch the mmc backend to this new shared block helpers, reducing block logic and only leaving MMC specific logic. Signed-off-by: Dmitrii Merkurev Reviewed-by: Mattijs Korpershoek Tested-by: Mattijs Korpershoek Signed-off-by: Neil Armstrong --- drivers/fastboot

[PATCH RFT v6 3/3] fastboot: integrate block flashing back-end

2025-06-30 Thread Neil Armstrong
so it doesn't break the CHIP & Ninendo boards, and for ROCKCHIP when MMC is enabled. Signed-off-by: Dmitrii Merkurev Reviewed-by: Mattijs Korpershoek Tested-by: Mattijs Korpershoek Signed-off-by: Neil Armstrong --- drivers/fastboot/Kconfig | 32 ++-- dr

[PATCH RFT v6 1/3] fastboot: blk: introduce fastboot block flashing support

2025-06-30 Thread Neil Armstrong
From: Dmitrii Merkurev Introduce fastboot block flashing functions and helpers to be shared with the MMC implementation. The write logic comes from the mmc implementation, while the partition lookup is much simpler and could be extended. For the erase logic, allmost no block drivers exposes

[PATCH RFT v6 0/3] fastboot: add support for generic block flashing

2025-06-30 Thread Neil Armstrong
This serie permits using any block device as target for fastboot by moving the generic block logic into a common set of helpers and also use them as generic backend. The erase logic has been extended to support software erase since only 2 block drivers exposes the erase operation. Tests are

[PATCH v1 2/2] configs: qcom_qcs9100: Fix fastboot buffer address for QCS9100 board

2025-06-30 Thread Balaji Selvanathan
The default value of CONFIG_FASTBOOT_BUF_ADDR is 0, which causes NULL pointer dereference during fastboot commands. Set it to 0xdb30, a safe and sufficiently large region in RAM of the QCS9100 board, to prevent crashes and ensure reliable fastboot functionality. Signed-off-by: Balaji

[PATCH v1 0/2] qcom: qcs9100: Rename defconfig and fix fastboot buffer

2025-06-30 Thread Balaji Selvanathan
pointer dereference during fastboot operations. The new address points to a safe and sufficiently large RAM region. Signed-off-by: Balaji Selvanathan Balaji Selvanathan (2): configs: Rename qcs9100_defconfig to qcom_qcs9100_defconfig configs: qcom_qcs9100: Fix fastboot buffer address for QCS9100

Re: [PATCH RFT v5 3/3] fastboot: integrate block flashing back-end

2025-06-10 Thread Neil Armstrong
Korpershoek Signed-off-by: Neil Armstrong --- drivers/fastboot/Kconfig | 29 - drivers/fastboot/Makefile | 1 + drivers/fastboot/fb_command.c | 8 drivers/fastboot/fb_common.c | 22 ++ drivers/fastboot/fb_getvar.c | 8 +++- 5

Re: [PATCH RFT v5 3/3] fastboot: integrate block flashing back-end

2025-06-06 Thread Tom Rini
s Korpershoek > Signed-off-by: Neil Armstrong > --- > drivers/fastboot/Kconfig | 29 ++++- > drivers/fastboot/Makefile | 1 + > drivers/fastboot/fb_command.c | 8 > drivers/fastboot/fb_common.c | 22 ++ > dri

Re: [PATCH RFT v4 3/3] fastboot: integrate block flashing back-end

2025-06-06 Thread Tom Rini
t; > > > > > > > > > > > > 1. Get partition info/size > > > > > > > 2. Erase partition > > > > > > > 3. Flash partition > > > > > > > 4. BCB > > > > > > > > > > &

Re: [PATCH RFT v4 3/3] fastboot: integrate block flashing back-end

2025-06-06 Thread Mattijs Korpershoek
y: Dmitrii Merkurev >>>>> Reviewed-by: Mattijs Korpershoek >>>>> Tested-by: Mattijs Korpershoek >>>>> Signed-off-by: Neil Armstrong >>>>> --- >>>>>drivers/fastboot/Kconfig | 29 + >&g

Re: [PATCH RFT v5 0/3] fastboot: add support for generic block flashing

2025-06-06 Thread Mattijs Korpershoek
Hi Neil, On ven., juin 06, 2025 at 11:33, Neil Armstrong wrote: > This serie permits using any block device as target > for fastboot by moving the generic block logic into > a common set of helpers and also use them as generic > backend. > > The erase logic has been e

[PATCH RFT v5 1/3] fastboot: blk: introduce fastboot block flashing support

2025-06-06 Thread Neil Armstrong
From: Dmitrii Merkurev Introduce fastboot block flashing functions and helpers to be shared with the MMC implementation. The write logic comes from the mmc implementation, while the partition lookup is much simpler and could be extended. For the erase logic, allmost no block drivers exposes

[PATCH RFT v5 3/3] fastboot: integrate block flashing back-end

2025-06-06 Thread Neil Armstrong
From: Dmitrii Merkurev 1. Get partition info/size 2. Erase partition 3. Flash partition 4. BCB Signed-off-by: Dmitrii Merkurev Reviewed-by: Mattijs Korpershoek Tested-by: Mattijs Korpershoek Signed-off-by: Neil Armstrong --- drivers/fastboot/Kconfig | 29

[PATCH RFT v5 2/3] fastboot: blk: switch emmc to use the block helpers

2025-06-06 Thread Neil Armstrong
From: Dmitrii Merkurev Switch the mmc backend to this new shared block helpers, reducing block logic and only leaving MMC specific logic. Signed-off-by: Dmitrii Merkurev Reviewed-by: Mattijs Korpershoek Tested-by: Mattijs Korpershoek Signed-off-by: Neil Armstrong --- drivers/fastboot

[PATCH RFT v5 0/3] fastboot: add support for generic block flashing

2025-06-06 Thread Neil Armstrong
This serie permits using any block device as target for fastboot by moving the generic block logic into a common set of helpers and also use them as generic backend. The erase logic has been extended to support software erase since only 2 block drivers exposes the erase operation. Tests are

Re: [PATCH RFT v4 3/3] fastboot: integrate block flashing back-end

2025-06-06 Thread Neil Armstrong
Armstrong wrote: From: Dmitrii Merkurev 1. Get partition info/size 2. Erase partition 3. Flash partition 4. BCB Signed-off-by: Dmitrii Merkurev Reviewed-by: Mattijs Korpershoek Tested-by: Mattijs Korpershoek Signed-off-by: Neil Armstrong --- drivers/fastboot/Kconfig | 29

Re: [PATCH RFT v4 3/3] fastboot: integrate block flashing back-end

2025-06-05 Thread Neil Armstrong
4. BCB Signed-off-by: Dmitrii Merkurev Reviewed-by: Mattijs Korpershoek Tested-by: Mattijs Korpershoek Signed-off-by: Neil Armstrong --- drivers/fastboot/Kconfig | 29 + drivers/fastboot/Makefile | 1 + drivers/fastboot/fb_command.c | 8

Re: [PATCH RFT v4 3/3] fastboot: integrate block flashing back-end

2025-06-05 Thread Tom Rini
t; > 2. Erase partition > > > 3. Flash partition > > > 4. BCB > > > > > > Signed-off-by: Dmitrii Merkurev > > > Reviewed-by: Mattijs Korpershoek > > > Tested-by: Mattijs Korpershoek > > > Signed-off-by: Neil Armstrong > > &

Re: [PATCH RFT v4 2/3] fastboot: blk: switch emmc to use the block helpers

2025-06-05 Thread Neil Armstrong
Korpershoek Tested-by: Mattijs Korpershoek Signed-off-by: Neil Armstrong --- drivers/fastboot/Kconfig | 4 +- drivers/fastboot/Makefile | 3 +- drivers/fastboot/fb_mmc.c | 210 +++--- 3 files changed, 16 insertions(+), 201 deletions(-) diff

Re: [PATCH RFT v4 3/3] fastboot: integrate block flashing back-end

2025-06-05 Thread Neil Armstrong
Korpershoek Signed-off-by: Neil Armstrong --- drivers/fastboot/Kconfig | 29 + drivers/fastboot/Makefile | 1 + drivers/fastboot/fb_command.c | 8 drivers/fastboot/fb_common.c | 22 ++ drivers/fastboot/fb_getvar.c | 8 +++- 5

Re: [PATCH RFT v4 3/3] fastboot: integrate block flashing back-end

2025-05-22 Thread Tom Rini
s Korpershoek > Signed-off-by: Neil Armstrong > --- > drivers/fastboot/Kconfig | 29 +++++ > drivers/fastboot/Makefile | 1 + > drivers/fastboot/fb_command.c | 8 > drivers/fastboot/fb_common.c | 22 ++ > dri

Re: [PATCH RFT v4 2/3] fastboot: blk: switch emmc to use the block helpers

2025-05-22 Thread Tom Rini
pershoek > Tested-by: Mattijs Korpershoek > Signed-off-by: Neil Armstrong > --- > drivers/fastboot/Kconfig | 4 +- > drivers/fastboot/Makefile | 3 +- > drivers/fastboot/fb_mmc.c | 210 > +++--- > 3 files changed, 16 inse

Re: [PATCH RFT v3 0/3] fastboot: add support for generic block flashing

2025-05-22 Thread Tom Rini
> > > > > > > > > > On mar., mai 20, 2025 at 13:35, Mattijs Korpershoek > > > > > > wrote: > > > > > > > > > > > > > Hi, > > > > > > > > > > > > > > On Tue, 06 May 2025

[PATCH RFT v4 0/3] fastboot: add support for generic block flashing

2025-05-22 Thread Neil Armstrong
This serie permits using any block device as target for fastboot by moving the generic block logic into a common set of helpers and also use them as generic backend. The erase logic has been extended to support software erase since only 2 block drivers exposes the erase operation. Tests are

[PATCH RFT v4 2/3] fastboot: blk: switch emmc to use the block helpers

2025-05-22 Thread Neil Armstrong
From: Dmitrii Merkurev Switch the mmc backend to this new shared block helpers, reducing block logic and only leaving MMC specific logic. Signed-off-by: Dmitrii Merkurev Reviewed-by: Mattijs Korpershoek Tested-by: Mattijs Korpershoek Signed-off-by: Neil Armstrong --- drivers/fastboot

[PATCH RFT v4 3/3] fastboot: integrate block flashing back-end

2025-05-22 Thread Neil Armstrong
From: Dmitrii Merkurev 1. Get partition info/size 2. Erase partition 3. Flash partition 4. BCB Signed-off-by: Dmitrii Merkurev Reviewed-by: Mattijs Korpershoek Tested-by: Mattijs Korpershoek Signed-off-by: Neil Armstrong --- drivers/fastboot/Kconfig | 29

[PATCH RFT v4 1/3] fastboot: blk: introduce fastboot block flashing support

2025-05-22 Thread Neil Armstrong
From: Dmitrii Merkurev Introduce fastboot block flashing functions and helpers to be shared with the MMC implementation. The write logic comes from the mmc implementation, while the partition lookup is much simpler and could be extended. For the erase logic, allmost no block drivers exposes

Re: [PATCH RFT v3 0/3] fastboot: add support for generic block flashing

2025-05-22 Thread neil . armstrong
Korpershoek wrote: Hi Neil, On mar., mai 20, 2025 at 13:35, Mattijs Korpershoek wrote: Hi, On Tue, 06 May 2025 18:10:06 +0200, neil.armstr...@linaro.org wrote: This serie permits using any block device as target for fastboot by moving the generic block logic into a common set of helpers and also use

Re: [PATCH RFT v3 0/3] fastboot: add support for generic block flashing

2025-05-21 Thread Mattijs Korpershoek
ijs Korpershoek wrote: >> >> Hi Neil, >> >> >> >> On mar., mai 20, 2025 at 13:35, Mattijs Korpershoek >> >> wrote: >> >> >> >> > Hi, >> >> > >> >> > On Tue, 06 May 2025 18:10:06 +0200, neil.armstr..

Re: [PATCH RFT v3 0/3] fastboot: add support for generic block flashing

2025-05-21 Thread Mattijs Korpershoek
n Tue, 06 May 2025 18:10:06 +0200, neil.armstr...@linaro.org wrote: >> >> This serie permits using any block device as target >> >> for fastboot by moving the generic block logic into >> >> a common set of helpers and also use them as generic >> >>

Re: [PATCH RFT v3 0/3] fastboot: add support for generic block flashing

2025-05-21 Thread Tom Rini
25 at 13:35, Mattijs Korpershoek > >> wrote: > >> > >> > Hi, > >> > > >> > On Tue, 06 May 2025 18:10:06 +0200, neil.armstr...@linaro.org wrote: > >> >> This serie permits using any block device as target > >> >>

Re: [PATCH RFT v3 0/3] fastboot: add support for generic block flashing

2025-05-21 Thread Tom Rini
e permits using any block device as target > >> for fastboot by moving the generic block logic into > >> a common set of helpers and also use them as generic > >> backend. > >> > >> The erase logic has been extended to support software > >> er

Re: [PATCH RFT v3 0/3] fastboot: add support for generic block flashing

2025-05-21 Thread Mattijs Korpershoek
Hi Neil, On mar., mai 20, 2025 at 13:35, Mattijs Korpershoek wrote: > Hi, > > On Tue, 06 May 2025 18:10:06 +0200, neil.armstr...@linaro.org wrote: >> This serie permits using any block device as target >> for fastboot by moving the generic block logic into >> a com

Re: [PATCH RFT v3 0/3] fastboot: add support for generic block flashing

2025-05-20 Thread Mattijs Korpershoek
Hi, On Tue, 06 May 2025 18:10:06 +0200, neil.armstr...@linaro.org wrote: > This serie permits using any block device as target > for fastboot by moving the generic block logic into > a common set of helpers and also use them as generic > backend. > > The erase logic has been e

Re: [PATCH RFT v3 0/3] fastboot: add support for generic block flashing

2025-05-07 Thread Neil Armstrong
On 07/05/2025 12:02, Mattijs Korpershoek wrote: Hi Neil, Thank you for the series. On mar., mai 06, 2025 at 18:10, neil.armstr...@linaro.org wrote: This serie permits using any block device as target for fastboot by moving the generic block logic into a common set of helpers and also use

Re: [PATCH RFT v3 0/3] fastboot: add support for generic block flashing

2025-05-07 Thread Mattijs Korpershoek
Hi Neil, Thank you for the series. On mar., mai 06, 2025 at 18:10, neil.armstr...@linaro.org wrote: > This serie permits using any block device as target > for fastboot by moving the generic block logic into > a common set of helpers and also use them as generic > backend. > &g

Re: [PATCH RFT v3 1/3] fastboot: blk: introduce fastboot block flashing support

2025-05-07 Thread Mattijs Korpershoek
Hi Neil, Thank you for the patch. On mar., mai 06, 2025 at 18:10, neil.armstr...@linaro.org wrote: > From: Dmitrii Merkurev > > Introduce fastboot block flashing functions and helpers > to be shared with the MMC implementation. > > The write logic comes from the mmc implement

Re: [PATCH RFT v3 2/3] fastboot: blk: switch emmc to use the block helpers

2025-05-07 Thread Mattijs Korpershoek
urev > Signed-off-by: Neil Armstrong Reviewed-by: Mattijs Korpershoek > --- > drivers/fastboot/Kconfig | 4 +- > drivers/fastboot/Makefile | 3 +- > drivers/fastboot/fb_mmc.c | 210 > +++--- > 3 files changed, 16 insertions(+), 201 deletions(-) >

[PATCH RFT v3 2/3] fastboot: blk: switch emmc to use the block helpers

2025-05-06 Thread neil . armstrong
From: Dmitrii Merkurev Switch the mmc backend to this new shared block helpers, reducing block logic and only leaving MMC specific logic. Signed-off-by: Dmitrii Merkurev Signed-off-by: Neil Armstrong --- drivers/fastboot/Kconfig | 4 +- drivers/fastboot/Makefile | 3 +- drivers/fastboot

[PATCH RFT v3 3/3] fastboot: integrate block flashing back-end

2025-05-06 Thread neil . armstrong
From: Dmitrii Merkurev 1. Get partition info/size 2. Erase partition 3. Flash partition 4. BCB Signed-off-by: Dmitrii Merkurev Reviewed-by: Mattijs Korpershoek Signed-off-by: Neil Armstrong --- drivers/fastboot/Kconfig | 24 drivers/fastboot/Makefile | 1

[PATCH RFT v3 0/3] fastboot: add support for generic block flashing

2025-05-06 Thread neil . armstrong
This serie permits using any block device as target for fastboot by moving the generic block logic into a common set of helpers and also use them as generic backend. The erase logic has been extended to support software erase since only 2 block drivers exposes the erase operation. Tests are

[PATCH RFT v3 1/3] fastboot: blk: introduce fastboot block flashing support

2025-05-06 Thread neil . armstrong
From: Dmitrii Merkurev Introduce fastboot block flashing functions and helpers to be shared with the MMC implementation. The write logic comes from the mmc implementation, while the partition lookup is much simpler and could be extended. For the erase logic, allmost no block drivers exposes

Re: [PATCH RFT v2 1/3] fastboot: blk: introduce fastboot block flashing support

2025-04-29 Thread neil . armstrong
CE_ID + int "Define FASTBOOT block device id" + depends on FASTBOOT_FLASH_BLOCK + help + "Fastboot block device id" This is similar as CONFIG_FASTBOOT_FLASH_MMC_DEV, no? No, the MMC one makes the mmc type implicit, while the block one can target any b

Re: [PATCH RFT v2 1/3] fastboot: blk: introduce fastboot block flashing support

2025-04-29 Thread neil . armstrong
On 29/04/2025 14:32, Mattijs Korpershoek wrote: On mar., avril 29, 2025 at 11:45, Dmitrii Merkurev wrote: Dmitrii, are you okay to re-licence this code under GPL v2 (which is common licence for this project) Yes, I'm ok with that. Fantastic, thanks a lot for answering so quickly! Thank

Re: [PATCH RFT v2 1/3] fastboot: blk: introduce fastboot block flashing support

2025-04-29 Thread Mattijs Korpershoek
On mar., avril 29, 2025 at 11:45, Dmitrii Merkurev wrote: >> >> Dmitrii, are you okay to re-licence this code under GPL v2 (which is >> common licence for this project) >> > > Yes, I'm ok with that. Fantastic, thanks a lot for answering so quickly!

Re: [PATCH RFT v2 1/3] fastboot: blk: introduce fastboot block flashing support

2025-04-29 Thread Dmitrii Merkurev
> > Dmitrii, are you okay to re-licence this code under GPL v2 (which is > common licence for this project) > Yes, I'm ok with that.

Re: [PATCH RFT v2 1/3] fastboot: blk: introduce fastboot block flashing support

2025-04-29 Thread Mattijs Korpershoek
linaro.org wrote: >> >>> From: Dmitrii Merkurev >>> >>> Introduce fastboot block flashing functions and helpers >>> to be shared with the MMC implementation. >>> >>> The write logic comes from the mmc implementation, while >>> the part

[PATCH 2/3] boot/bootmeth-android.c: Reuse fastboot memory block for unzip kernel

2025-04-27 Thread George Chan via B4 Relay
From: George Chan Some androidboot images have gzipped kernel so we need to reuse extra mem block for holding gzipped boot.img, and let loadaddr to hold unzipped kernel data. Here we choose fastboot memory for reuse and avoid dramatically increase memory footprint. Signed-off-by: George Chan

Re: [PATCH RFT v2 1/3] fastboot: blk: introduce fastboot block flashing support

2025-04-23 Thread Neil Armstrong
Hi, On 22/04/2025 15:17, Mattijs Korpershoek wrote: Hi Neil, Thank you for the patch. Thx for the review On mer., avril 09, 2025 at 09:58, neil.armstr...@linaro.org wrote: From: Dmitrii Merkurev Introduce fastboot block flashing functions and helpers to be shared with the MMC

Re: [PATCH RFT v2 1/3] fastboot: blk: introduce fastboot block flashing support

2025-04-22 Thread Mattijs Korpershoek
Hi Neil, Thank you for the patch. On mer., avril 09, 2025 at 09:58, neil.armstr...@linaro.org wrote: > From: Dmitrii Merkurev > > Introduce fastboot block flashing functions and helpers > to be shared with the MMC implementation. > > The write logic comes from the mmc imp

Re: [PATCH RFT v2 0/3] fastboot: add support for generic block flashing

2025-04-17 Thread Mattijs Korpershoek
Hey Neil, Thank you for the series. On mer., avril 09, 2025 at 09:58, neil.armstr...@linaro.org wrote: > This serie permits using any block device as target > for fastboot by moving the generic block logic into > a common set of helpers and also use them as generic > backend. &

Re: [PATCH RFT v2 0/3] fastboot: add support for generic block flashing

2025-04-14 Thread Mattijs Korpershoek
Hey Neil, On lun., avril 14, 2025 at 11:13, Neil Armstrong wrote: > Hi Mattijs, > > On 09/04/2025 09:58, neil.armstr...@linaro.org wrote: >> This serie permits using any block device as target >> for fastboot by moving the generic block logic into >> a common set o

Re: [PATCH RFT v2 0/3] fastboot: add support for generic block flashing

2025-04-14 Thread Neil Armstrong
Hi Mattijs, On 09/04/2025 09:58, neil.armstr...@linaro.org wrote: This serie permits using any block device as target for fastboot by moving the generic block logic into a common set of helpers and also use them as generic backend. The erase logic has been extended to support software erase

Re: [PATCH 1/3] fastboot: lift restrictions on !NET_LWIP for USB

2025-04-10 Thread Mattijs Korpershoek
Hi, On Wed, 12 Mar 2025 08:36:55 +0100, Michael Walle wrote: > Fastboot works either over TCP, UDP or USB. The latter doesn't have > anything to do with networking, thus should work just fine with > regardless which network stack is selected. In practice, header symbols > are u

[PATCH RFT v2 2/3] fastboot: blk: switch emmc to use the block helpers

2025-04-09 Thread neil . armstrong
From: Dmitrii Merkurev Switch the mmc backend to this new shared block helpers, reducing block logic and only leaving MMC specific logic. Signed-off-by: Dmitrii Merkurev Signed-off-by: Neil Armstrong --- drivers/fastboot/fb_mmc.c | 210 +++--- 1 file

[PATCH RFT v2 3/3] fastboot: integrate block flashing back-end

2025-04-09 Thread neil . armstrong
From: Dmitrii Merkurev 1. Get partition info/size 2. Erase partition 3. Flash partition 4. BCB Signed-off-by: Dmitrii Merkurev Reviewed-by: Mattijs Korpershoek Signed-off-by: Neil Armstrong --- drivers/fastboot/fb_command.c | 8 drivers/fastboot/fb_common.c | 16

[PATCH RFT v2 1/3] fastboot: blk: introduce fastboot block flashing support

2025-04-09 Thread neil . armstrong
From: Dmitrii Merkurev Introduce fastboot block flashing functions and helpers to be shared with the MMC implementation. The write logic comes from the mmc implementation, while the partition lookup is much simpler and could be extended. For the erase logic, allmost no block drivers exposes

[PATCH RFT v2 0/3] fastboot: add support for generic block flashing

2025-04-09 Thread neil . armstrong
This serie permits using any block device as target for fastboot by moving the generic block logic into a common set of helpers and also use them as generic backend. The erase logic has been extended to support software erase since only 2 block drivers exposes the erase operation. Tests are

[PATCH v1 03/11] usb: gadget: fastboot: make part of USB fastboot code shared

2025-04-05 Thread Arseniy Krasnov
This is preparation for fastboot-based flashing protocols (such as Amlogic ADNL). When device enters ADNL mode, it becomes "fastboot" device from USB point of view, so to avoid copy-paste of USB part of fastboot protocol, reimplement it as shared code between fastboot and ADNL imple

Re: [PATCH 2/4] fastboot: blk: add block device flashing configuration

2025-04-04 Thread neil . armstrong
>> wrote: Hi Dmitrii, So you plan to send a new version of this patchset ? It would be very useful to enable fastboot onr UFS/SCSI based devices. Thanks, Neil On 06/03/2024 19:59, Dmitrii Merkurev wrote: > Signed-off-by: Dmitrii Merkurev mailto:dimori...@g

Re: [PATCH 2/4] fastboot: blk: add block device flashing configuration

2025-04-01 Thread neil . armstrong
On 01/04/2025 15:18, Dmitrii Merkurev wrote: Hey Neil! > Ping, did you find time to resubmit a new version of this patchset ? Apologies, but it looks like I won’t have the capacity to complete this patch stack after all. Please feel free to take it over if you think it’s useful! Ack, I'll t

Re: [PATCH 2/4] fastboot: blk: add block device flashing configuration

2025-04-01 Thread Dmitrii Merkurev
Hey Neil! > Ping, did you find time to resubmit a new version of this patchset ? Apologies, but it looks like I won’t have the capacity to complete this patch stack after all. Please feel free to take it over if you think it’s useful!

Re: [PATCH 0/4] Qualcomm: fix sdm845 clocks and enable fastboot

2025-03-31 Thread Caleb Connolly
On Mon, 24 Mar 2025 19:17:36 +0100, Caleb Connolly wrote: > Fix clock init failures for USB and UFS on SDM845 devices, stub the RPMh > clock controller, enable DM_USB_GADGET and fastboot support for all > Qualcomm platforms supported by qcom_defconfig. > > Fastboot isn't s

Re: [PATCH 1/3] fastboot: lift restrictions on !NET_LWIP for USB

2025-03-28 Thread Mattijs Korpershoek
Hi Michael, Tom, On ven., mars 28, 2025 at 09:59, Tom Rini wrote: > On Fri, Mar 28, 2025 at 10:06:12AM +0100, Michael Walle wrote: >> Hi Mattijs, >> >> > > Fastboot works either over TCP, UDP or USB. The latter doesn't have >> > > anything to do with

Re: [PATCH 1/3] fastboot: lift restrictions on !NET_LWIP for USB

2025-03-28 Thread Tom Rini
On Fri, Mar 28, 2025 at 10:06:12AM +0100, Michael Walle wrote: > Hi Mattijs, > > > > Fastboot works either over TCP, UDP or USB. The latter doesn't have > > > anything to do with networking, thus should work just fine with > > > regardless which network

Re: [PATCH 1/3] fastboot: lift restrictions on !NET_LWIP for USB

2025-03-28 Thread Michael Walle
Hi Mattijs, > > Fastboot works either over TCP, UDP or USB. The latter doesn't have > > anything to do with networking, thus should work just fine with > > regardless which network stack is selected. In practice, header symbols > > are used inside common code paths

[PATCH 06/18] fastboot: annotate switch/case fallthrough case

2025-03-27 Thread Andre Przywara
The fastboot command handling uses an implicit switch/case fallthrough when receiving the OEM_CONSOLE command, but when this command is not enabled in Kconfig, to report this command as unknown. Add our "fallthrough;" statement-like macro before the default branch in the fastboot code,

  1   2   3   4   5   6   7   8   9   10   >