[PATCH v5 0/1] CONFIG_IS_ENABLED vs IS_ENABLED

2023-10-27 Thread Troy Kisky
This patch set gets ready to checks the usage of CONFIG_IS_ENABLED/IS_ENABLED. After the set has been applied, you can delete test/usage_of_is_enabled_todo.txt and run test/usage_of_is_enabled_commit.sh The script test/usage_of_is_enabled_check.sh checks for new questionable uses of CONFIG_IS_E

[PATCH v4 0/1] CONFIG_IS_ENABLED vs IS_ENABLED

2023-06-19 Thread Troy Kisky
This patch set gets ready to checks the usage of CONFIG_IS_ENABLED/IS_ENABLED. After the set has been applied, you can delete test/usage_of_is_enabled_todo.txt and run test/usage_of_is_enabled_commit.sh The script test/usage_of_is_enabled_check.sh checks for new questionable uses of CONFIG_IS_E

Re: [PATCH v3 00/23] CONFIG_IS_ENABLED vs IS_ENABLED

2023-05-11 Thread Tom Rini
On Mon, Mar 13, 2023 at 02:31:22PM -0700, Troy Kisky wrote: > This patch set gets ready to checks the usage of > CONFIG_IS_ENABLED/IS_ENABLED. > > After the set has been applied, you can delete > test/usage_of_is_enabled_todo.txt > and run test/usage_of_is_enabled_commit.sh > > The script test/u

[PATCH v3 00/23] CONFIG_IS_ENABLED vs IS_ENABLED

2023-03-13 Thread Troy Kisky
This patch set gets ready to checks the usage of CONFIG_IS_ENABLED/IS_ENABLED. After the set has been applied, you can delete test/usage_of_is_enabled_todo.txt and run test/usage_of_is_enabled_commit.sh The script test/usage_of_is_enabled_check.sh checks for new questionable uses of CONFIG_IS_E

[PATCH v2 00/26] CONFIG_IS_ENABLED vs IS_ENABLED

2023-02-24 Thread Troy Kisky
This patch set gets ready to check the usage of CONFIG_IS_ENABLED/IS_ENABLED. After the set has been applied, you can delete test/usage_of_is_enabled_todo.txt and run test/usage_of_is_enabled_commit.sh The script test/usage_of_is_enabled_check.sh checks for new questionable uses of CONFIG_IS_EN

[PATCH v1 00/24] CONFIG_IS_ENABLED vs IS_ENABLED

2023-02-21 Thread Troy Kisky
This patch set gets ready to checks the usage of CONFIG_IS_ENABLED/IS_ENABLED. After the set has been applied, you can delete test/usage_of_is_enabled_todo.txt and run test/usage_of_is_enabled_commit.sh The script test/usage_of_is_enabled_check.sh checks for new questionable uses of CONFIG_IS_E

Re: CONFIG_IS_ENABLED vs IS_ENABLED

2023-01-31 Thread Simon Glass
Hi Troy, On Mon, 30 Jan 2023 at 15:17, Troy Kisky wrote: > > > > On Mon, Jan 30, 2023 at 11:44 AM Tom Rini wrote: >> >> On Mon, Jan 30, 2023 at 10:51:03AM -0800, Troy Kisky wrote: >> > Hi Tom >> > >> > >> > On Mon, Jan 30, 2023 at 9:18 AM Tom Rini wrote: >> > >> > > On Sat, Jan 28, 2023 at 09:2

Re: CONFIG_IS_ENABLED vs IS_ENABLED

2023-01-30 Thread Troy Kisky
On Mon, Jan 30, 2023 at 11:44 AM Tom Rini wrote: > On Mon, Jan 30, 2023 at 10:51:03AM -0800, Troy Kisky wrote: > > Hi Tom > > > > > > On Mon, Jan 30, 2023 at 9:18 AM Tom Rini wrote: > > > > > On Sat, Jan 28, 2023 at 09:25:54AM -0800, Troy Kisky wrote: > > > > Thanks Tom, > > > > > > > > I cleane

Re: CONFIG_IS_ENABLED vs IS_ENABLED

2023-01-30 Thread Tom Rini
On Mon, Jan 30, 2023 at 10:51:03AM -0800, Troy Kisky wrote: > Hi Tom > > > On Mon, Jan 30, 2023 at 9:18 AM Tom Rini wrote: > > > On Sat, Jan 28, 2023 at 09:25:54AM -0800, Troy Kisky wrote: > > > Thanks Tom, > > > > > > I cleaned up the PR based on the CI results. Here's my current changes. > >

Re: CONFIG_IS_ENABLED vs IS_ENABLED

2023-01-30 Thread Troy Kisky
Hi Tom On Mon, Jan 30, 2023 at 9:18 AM Tom Rini wrote: > On Sat, Jan 28, 2023 at 09:25:54AM -0800, Troy Kisky wrote: > > Thanks Tom, > > > > I cleaned up the PR based on the CI results. Here's my current changes. > > > > Author: Troy Kisky > > Date: Fri Jan 27 11:03:11 2023 -0800 > > > >

Re: CONFIG_IS_ENABLED vs IS_ENABLED

2023-01-30 Thread Tom Rini
On Sat, Jan 28, 2023 at 09:25:54AM -0800, Troy Kisky wrote: > Thanks Tom, > > I cleaned up the PR based on the CI results. Here's my current changes. > > Author: Troy Kisky > Date: Fri Jan 27 11:03:11 2023 -0800 > > dm: device-internal: use EVENT instead of DM_EVENT, because > event_notif

Re: CONFIG_IS_ENABLED vs IS_ENABLED

2023-01-28 Thread Troy Kisky
Thanks Tom, I cleaned up the PR based on the CI results. Here's my current changes. Author: Troy Kisky Date: Fri Jan 27 11:03:11 2023 -0800 dm: device-internal: use EVENT instead of DM_EVENT, because event_notify is built for EVENT Signed-off-by: Troy Kisky diff --git a/include/dm/

Re: CONFIG_IS_ENABLED vs IS_ENABLED

2023-01-27 Thread Simon Glass
gt; > > > > > > From: Troy Kisky > > > > > > > Sent: Tuesday, January 24, 2023 2:52 PM > > > > > > > To: u-boot@lists.denx.de ; sba...@denx.de > > > > > > > ; tr...@konsulko.com ; > > > > > > > feste.

Re: CONFIG_IS_ENABLED vs IS_ENABLED

2023-01-26 Thread Tom Rini
; > > > > > > > > > > > > > > > > > > > > > > > > > From: Troy Kisky > > > > > > Sent: Tuesday, January 24, 2023 2:52 PM > > > > > > T

Re: CONFIG_IS_ENABLED vs IS_ENABLED

2023-01-26 Thread Simon Glass
> > > From: Troy Kisky > > > > > Sent: Tuesday, January 24, 2023 2:52 PM > > > > > To: u-boot@lists.denx.de ; sba...@denx.de > > > > > ; tr...@konsulko.com ; > > > > > feste...@gmail.com > > > > > Cc: s...@chromium.org ;

Re: CONFIG_IS_ENABLED vs IS_ENABLED

2023-01-26 Thread Tom Rini
; sba...@denx.de > > > > ; tr...@konsulko.com ; > > > > feste...@gmail.com > > > > Cc: s...@chromium.org ; ma...@denx.de > > > > Subject: CONFIG_IS_ENABLED vs IS_ENABLED > > > > > > > > Hi Guys > > > > > > > > I

Re: CONFIG_IS_ENABLED vs IS_ENABLED

2023-01-26 Thread Simon Glass
___ > > > From: Troy Kisky > > > Sent: Tuesday, January 24, 2023 2:52 PM > > > To: u-boot@lists.denx.de ; sba...@denx.de > > > ; tr...@konsulko.com ; > > > feste...@gmail.com > > > Cc: s...@chromium.org ; ma...@denx.de

Re: CONFIG_IS_ENABLED vs IS_ENABLED

2023-01-26 Thread Tom Rini
On Thu, Jan 26, 2023 at 09:26:18AM -0800, Troy Kisky wrote: > Thanks Simon > > I switched emails to get rid of the legalese. > Below are scripts to commit the changes sorted by > CONFIG_x variable. The only one I know causes a problem > is CONFIG_OF_LIVE because of > > drivers/core/Makefile > obj

re: CONFIG_IS_ENABLED vs IS_ENABLED

2023-01-26 Thread Troy Kisky
Thanks Simon I switched emails to get rid of the legalese. Below are scripts to commit the changes sorted by CONFIG_x variable. The only one I know causes a problem is CONFIG_OF_LIVE because of drivers/core/Makefile obj-$(CONFIG_$(SPL_)OF_LIVE) So, that config needs to keep using CONFIG_IS_ENABL

Re: CONFIG_IS_ENABLED vs IS_ENABLED

2023-01-26 Thread Tom Rini
To: u-boot@lists.denx.de ; sba...@denx.de > > ; tr...@konsulko.com ; > > feste...@gmail.com > > Cc: s...@chromium.org ; ma...@denx.de > > Subject: CONFIG_IS_ENABLED vs IS_ENABLED > > > > Hi Guys > > > > In a recent debugging session, I stu

Re: CONFIG_IS_ENABLED vs IS_ENABLED

2023-01-24 Thread Simon Glass
.@chromium.org ; ma...@denx.de > Subject: CONFIG_IS_ENABLED vs IS_ENABLED > > Hi Guys > > In a recent debugging session, I stumbled across this line > drivers/mmc/mmc.c: if (CONFIG_IS_ENABLED(MMC_QUIRKS) && mmc->quirks & > quirk) > > which prevents retries

Re: CONFIG_IS_ENABLED vs IS_ENABLED

2023-01-24 Thread Troy Kisky
From: Troy Kisky Sent: Tuesday, January 24, 2023 2:52 PM To: u-boot@lists.denx.de ; sba...@denx.de ; tr...@konsulko.com ; feste...@gmail.com Cc: s...@chromium.org ; ma...@denx.de Subject: CONFIG_IS_ENABLED vs IS_ENABLED Hi Guys In a recent debugging

CONFIG_IS_ENABLED vs IS_ENABLED

2023-01-24 Thread Troy Kisky
Hi Guys In a recent debugging session, I stumbled across this line drivers/mmc/mmc.c: if (CONFIG_IS_ENABLED(MMC_QUIRKS) && mmc->quirks & quirk) which prevents retries in SPL code, and was causing booting from an SD card to fail. So I wrote a little script to print uses of CONFIG_IS_ENABLED