Re: [patch 2/8] RFC: drivers/video/rockchip/rk_edp.c: Add rk3399 support

2020-10-23 Thread Alper Nebi Yasak
On 23/10/2020 11:49, Arnaud Patard (Rtp) wrote: > Alper Nebi Yasak writes: >> I think instead of supporting both devices in the same driver, it'd be >> cleaner to split chip-specific parts into rk3288_edp.c and rk3399_edp.c >> like the other ones for vop, hdmi, etc; the common parts would stay her

Re: [patch 2/8] RFC: drivers/video/rockchip/rk_edp.c: Add rk3399 support

2020-10-23 Thread Rtp
Alper Nebi Yasak writes: Hi, > On 25/09/2020 21:36, Arnaud Patard (Rtp) wrote: >> According to linux commit "drm/rockchip: analogix_dp: add rk3399 eDP >> support" (82872e42bb1501dd9e60ca430f4bae45a469aa64), rk3288 and rk3399 >> eDP IPs are nearly the same, the difference is in the grf register >

[patch 2/8] RFC: drivers/video/rockchip/rk_edp.c: Add rk3399 support

2020-09-25 Thread Rtp
According to linux commit "drm/rockchip: analogix_dp: add rk3399 eDP support" (82872e42bb1501dd9e60ca430f4bae45a469aa64), rk3288 and rk3399 eDP IPs are nearly the same, the difference is in the grf register (SOC_CON6 versus SOC_CON20). So, change the code to use the right register on each IP. The