Re: [fs/squashfs PATCH v3 2/2] avoid 64-bit divisions on 32-bit

2020-10-08 Thread Mauro Condarelli
On 10/8/20 9:34 AM, Miquel Raynal wrote: > Hi Mauro, > > Mauro Condarelli wrote on Thu, 8 Oct 2020 00:30:21 > +0200: > >> Use macros in linux/kernel.h to avoid 64-bit divisions. > s/in/from/? My command of English language is far from perfect. I meant those macros are used in Linux kernel. Fee

Re: [fs/squashfs PATCH v3 2/2] avoid 64-bit divisions on 32-bit

2020-10-08 Thread Thomas Petazzoni
Hello, The commit title lacks a proper prefix, it should start with "fs/squashfs". You confused the prefix of the commit title with the "subject prefix" of format-patch. On Thu, 8 Oct 2020 00:30:21 +0200 Mauro Condarelli wrote: > diff --git a/fs/squashfs/sqfs.c b/fs/squashfs/sqfs.c > index 152

Re: [fs/squashfs PATCH v3 2/2] avoid 64-bit divisions on 32-bit

2020-10-08 Thread Miquel Raynal
Hi Mauro, Mauro Condarelli wrote on Thu, 8 Oct 2020 00:30:21 +0200: > Use macros in linux/kernel.h to avoid 64-bit divisions. s/in/from/? > > These divisions are needed to convert from file length (potentially > over 32-bit range) to block number, so result and remainder are > guaranteed to

[fs/squashfs PATCH v3 2/2] avoid 64-bit divisions on 32-bit

2020-10-07 Thread Mauro Condarelli
Use macros in linux/kernel.h to avoid 64-bit divisions. These divisions are needed to convert from file length (potentially over 32-bit range) to block number, so result and remainder are guaranteed to fit in 32-bit integers. Some 32bit architectures (notably mipsel) lack an implementation of __u