Re: [U-Boot] net, kirkwood_egiga: init mac address before using network commands

2010-03-30 Thread Detlev Zundel
Hi Simon, >> Interesting. Why would you do this? Why would you not rather fix the >> Linux driver instead? [This is what I would do.] > > Basically two reasons: First, it's a simpler fix in U-boot (a oneliner > for Kirkwood), and secondly because (as far as I understand, correct me > if I'm wron

Re: [U-Boot] net, kirkwood_egiga: init mac address before using network commands

2010-03-30 Thread Simon Kagstrom
On Tue, 30 Mar 2010 10:26:59 +0200 Wolfgang Denk wrote: > > Personally, I'd prefer using Heikos approach until Arm Linux has moved > > to device trees. I know it's a deviation from how it's supposed to > > work, but it also solves a real problem without introducing kludges > > elsewhere. > > If

Re: [U-Boot] net, kirkwood_egiga: init mac address before using network commands

2010-03-30 Thread Wolfgang Denk
Dear Simon Kagstrom, In message <20100330100127.5f364...@marrow.netinsight.se> you wrote: > > > I also actively request the U-Boot community to give feedback here - > > after all, this _is_ a community project and fixing real problems is one > > of the main tasks of a bootloader. > > Personally,

Re: [U-Boot] net, kirkwood_egiga: init mac address before using network commands

2010-03-30 Thread Wolfgang Denk
Dear Heiko Schocher, In message <4bb18e5f.6060...@denx.de> you wrote: > initialize mac address with the value from "ethaddr", before > doing some network commands. This is not in line with u-boot > design principle "not to initalize not used devices", and > maybe should go away, if there is a solu

Re: [U-Boot] net, kirkwood_egiga: init mac address before using network commands

2010-03-30 Thread Simon Kagstrom
On Tue, 30 Mar 2010 09:52:29 +0200 Detlev Zundel wrote: > I also actively request the U-Boot community to give feedback here - > after all, this _is_ a community project and fixing real problems is one > of the main tasks of a bootloader. Personally, I'd prefer using Heikos approach until Arm Li

Re: [U-Boot] net, kirkwood_egiga: init mac address before using network commands

2010-03-30 Thread Detlev Zundel
Hello Heiko, > initialize mac address with the value from "ethaddr", before > doing some network commands. This is not in line with u-boot > design principle "not to initalize not used devices", and > maybe should go away, if there is a solution for passing > the mac address to arm linux kernels.

Re: [U-Boot] net, kirkwood_egiga: init mac address before using network commands

2010-03-30 Thread Simon Kagstrom
On Tue, 30 Mar 2010 07:38:39 +0200 Heiko Schocher wrote: > initialize mac address with the value from "ethaddr", before > doing some network commands. This is not in line with u-boot > design principle "not to initalize not used devices", and > maybe should go away, if there is a solution for pas

Re: [U-Boot] net, kirkwood_egiga: init mac address before using network commands

2010-03-30 Thread Mike Frysinger
On Tuesday 30 March 2010 01:38:39 Heiko Schocher wrote: > diff --git a/drivers/net/kirkwood_egiga.c b/drivers/net/kirkwood_egiga.c > index 2ad7fea..e8b3777 100644 > --- a/drivers/net/kirkwood_egiga.c > +++ b/drivers/net/kirkwood_egiga.c > @@ -678,7 +678,7 @@ int kirkwood_egiga_initialize(bd_t * bis

[U-Boot] net, kirkwood_egiga: init mac address before using network commands

2010-03-29 Thread Heiko Schocher
initialize mac address with the value from "ethaddr", before doing some network commands. This is not in line with u-boot design principle "not to initalize not used devices", and maybe should go away, if there is a solution for passing the mac address to arm linux kernels. Tested on the suen3 boa