Re: [U-Boot] board/BuR/common: incorrect check of dtb

2017-05-05 Thread Hannes Schmelzer
On 05/05/2017 08:14 PM, Tom Rini wrote: On Fri, May 05, 2017 at 08:11:54PM +0200, Anatolij Gustschin wrote: On Fri, 5 May 2017 12:38:06 -0400 Tom Rini tr...@konsulko.com wrote: ... char *dtbname = getenv("dtb"); char *dtbdev = getenv("dtbdev"); char *dtppart = getenv("dt

Re: [U-Boot] board/BuR/common: incorrect check of dtb

2017-05-05 Thread Tom Rini
On Fri, May 05, 2017 at 08:11:54PM +0200, Anatolij Gustschin wrote: > On Fri, 5 May 2017 12:38:06 -0400 > Tom Rini tr...@konsulko.com wrote: > ... > > > char *dtbname = getenv("dtb"); > > > char *dtbdev = getenv("dtbdev"); > > > char *dtppart = getenv("dtbpart"); > > > - if (!dtbdev || !dtbde

Re: [U-Boot] board/BuR/common: incorrect check of dtb

2017-05-05 Thread Anatolij Gustschin
On Fri, 5 May 2017 12:38:06 -0400 Tom Rini tr...@konsulko.com wrote: ... > > char *dtbname = getenv("dtb"); > > char *dtbdev = getenv("dtbdev"); > > char *dtppart = getenv("dtbpart"); > > - if (!dtbdev || !dtbdev || !dtbname) { > > + if (!dtbdev || !dtbpart || !dtbname) { > >

Re: [U-Boot] board/BuR/common: incorrect check of dtb

2017-05-05 Thread Tom Rini
On Wed, May 03, 2017 at 11:44:11PM +0200, xypron.g...@gmx.de wrote: > The logical expression to check the dtb is incorrect in > load_devicetree. > > The problem was indicated by cppcheck. > > Signed-off-by: Heinrich Schuchardt > Reviewed-by: Hannes Schmelzer > Acked-by: Hannes Schmelzer > ---