Re: [U-Boot] NULL base_name for hwaddr env lookup

2011-09-05 Thread Heiko Schocher
Hello MARCEL, stany MARCEL wrote: > in net/eth.c there is this function call with test: > > if (eth_write_hwaddr(dev, NULL, eth_number)) > > If I understand correctly this test will always be true as NULL is used. > > I think it should be "eth" instead of NULL. > > Am I wrong ? No. > If not

Re: [U-Boot] NULL base_name for hwaddr env lookup

2011-09-05 Thread Stany MARCEL
On Mon, Sep 5, 2011 at 3:53 PM, stany MARCEL wrote: > in net/eth.c there is this function call with test: > >  if (eth_write_hwaddr(dev, NULL, eth_number)) > > If I understand correctly this test will always be true as NULL is used. > > I think it should be "eth" instead of NULL. > > Am I wrong ?

[U-Boot] NULL base_name for hwaddr env lookup

2011-09-05 Thread stany MARCEL
in net/eth.c there is this function call with test: if (eth_write_hwaddr(dev, NULL, eth_number)) If I understand correctly this test will always be true as NULL is used. I think it should be "eth" instead of NULL. Am I wrong ? If not I can submit a patch. Regards, Stany