Re: [U-Boot] Inconsistencies in commands regarding load_addr

2015-10-09 Thread Stephen Warren
On 10/09/2015 02:28 AM, Benoît Thébaudeau wrote: Dear Wolfgang, On 08/10/2015 23:29, Wolfgang Denk wrote: Dear Stephen, In message <56167db6.3000...@wwwdotorg.org> you wrote: What's the expected correct behavior here? After successful loading the data to memory, load_addr should be set co

Re: [U-Boot] Inconsistencies in commands regarding load_addr

2015-10-09 Thread Wolfgang Denk
Dear Benoît, In message <5617c8b9.30...@wsystem.com> you wrote: > > Currently, it's all mixed up between CONFIG_SYS_LOAD_ADDR, the loadaddr > environment variable and the load_addr global C variable. > > The 1st issue is that loadaddr and load_addr currently diverge if the user > changes loadadd

Re: [U-Boot] Inconsistencies in commands regarding load_addr

2015-10-09 Thread Benoît Thébaudeau
Dear Wolfgang, On 09/10/2015 15:18, Wolfgang Denk wrote: > Regarding the "load address" topic, be careful, as there has always > been a lot of confusion (due to unfortunate historic choice of names). > There is the "load address" as part of the image formates (uImage, FIT > image), which means the

Re: [U-Boot] Inconsistencies in commands regarding load_addr

2015-10-09 Thread Wolfgang Denk
Dear Benoît Thébaudeau, In message <56177ac8.1020...@wsystem.com> you wrote: > > I'm not certain that this would be the least astonishing behavior. When I read > the documentation, I rather expect the loadaddr environment variable to be > used > whenever the address is omitted in a command invoc

Re: [U-Boot] Inconsistencies in commands regarding load_addr

2015-10-09 Thread Benoît Thébaudeau
Dear Wolfgang, On 08/10/2015 23:29, Wolfgang Denk wrote: > Dear Stephen, > > In message <56167db6.3000...@wwwdotorg.org> you wrote: >> What's the expected correct behavior here? >>> >>> After successful loading the data to memory, load_addr should be set >>> correctly, for all commands. In

Re: [U-Boot] Inconsistencies in commands regarding load_addr

2015-10-08 Thread Wolfgang Denk
Dear Stephen, In message <56167db6.3000...@wwwdotorg.org> you wrote: > > >> What's the expected correct behavior here? > > > > After successful loading the data to memory, load_addr should be set > > correctly, for all commands. In the error case, the value of > > load_addr is undefined. > > Is

Re: [U-Boot] Inconsistencies in commands regarding load_addr

2015-10-08 Thread Stephen Warren
On 10/07/2015 10:40 PM, Wolfgang Denk wrote: Dear Benoît, In message <5613e20f.8060...@wsystem.com> you wrote: I've just noticed that before the commit 045fa1e1142552799ad3203e9e0bc22a11e866ea, ext2load and ext4load were setting the load_addr global variable, but not fatload. Since then, none

Re: [U-Boot] Inconsistencies in commands regarding load_addr

2015-10-07 Thread Wolfgang Denk
Dear Benoît, In message <5613e20f.8060...@wsystem.com> you wrote: > > I've just noticed that before the commit > 045fa1e1142552799ad3203e9e0bc22a11e866ea, ext2load and ext4load were setting > the > load_addr global variable, but not fatload. Since then, none of these commands > set load_addr (in

Re: [U-Boot] Inconsistencies in commands regarding load_addr

2015-10-06 Thread Benoît Thébaudeau
On Tue, Oct 6, 2015 at 8:09 PM, Stephen Warren wrote: > On 10/06/2015 09:00 AM, Benoît Thébaudeau wrote: >> >> Hi all, >> >> I've just noticed that before the commit >> 045fa1e1142552799ad3203e9e0bc22a11e866ea, ext2load and ext4load were >> setting the >> load_addr global variable, but not fatload

Re: [U-Boot] Inconsistencies in commands regarding load_addr

2015-10-06 Thread Stephen Warren
On 10/06/2015 09:00 AM, Benoît Thébaudeau wrote: Hi all, I've just noticed that before the commit 045fa1e1142552799ad3203e9e0bc22a11e866ea, ext2load and ext4load were setting the load_addr global variable, but not fatload. Since then, none of these commands set load_addr (initially derived from

[U-Boot] Inconsistencies in commands regarding load_addr

2015-10-06 Thread Benoît Thébaudeau
Hi all, I've just noticed that before the commit 045fa1e1142552799ad3203e9e0bc22a11e866ea, ext2load and ext4load were setting the load_addr global variable, but not fatload. Since then, none of these commands set load_addr (initially derived from the loadaddr environment variable). ubifsload also