Re: [U-Boot] 83xx and LCRR setting

2009-08-24 Thread Kim Phillips
On Mon, 24 Aug 2009 12:15:39 +0200 Detlev Zundel wrote: > > but I can do of course a: > > > > + /* LCRR - Clock Ratio Register (10.3.1.14) */ > > + im->lbus.lcrr = (im->lbus.lcrr & ~LCRR_MASK) | \ > > + (CONFIG_SYS_LCRR & LCRR_MASK); > > > > Which way is prefered? > > Perso

Re: [U-Boot] 83xx and LCRR setting

2009-08-24 Thread Kim Phillips
On Sat, 22 Aug 2009 08:17:51 +0200 Heiko Schocher wrote: > Hello Kim, > > Kim Phillips wrote: > > On Thu, 20 Aug 2009 12:05:58 +0200 > > Heiko Schocher wrote: > > > On my board (and for example on the MPC832XEMDS) the flash is connected > to the localbus ... and this register setting

Re: [U-Boot] 83xx and LCRR setting

2009-08-24 Thread Detlev Zundel
Hi Heiko, > Hello Kim, > > Kim Phillips wrote: >> On Thu, 20 Aug 2009 13:03:09 +0200 >> Detlev Zundel wrote: >> >>> or maybe even always use the mask, define it in the board config and do >>> a >>> >>> #if !defined(LCCR_MASK) >>> #define LCCR_MASK 0x >>> #endif >> >> ack. > > nack, it s

Re: [U-Boot] 83xx and LCRR setting

2009-08-21 Thread Heiko Schocher
Hello Kim, Kim Phillips wrote: > On Thu, 20 Aug 2009 13:03:09 +0200 > Detlev Zundel wrote: > >> or maybe even always use the mask, define it in the board config and do >> a >> >> #if !defined(LCCR_MASK) >> #define LCCR_MASK 0x >> #endif > > ack. nack, it should be #if !defined(LCCR_MA

Re: [U-Boot] 83xx and LCRR setting

2009-08-21 Thread Heiko Schocher
Hello Kim, Kim Phillips wrote: > On Thu, 20 Aug 2009 12:05:58 +0200 > Heiko Schocher wrote: > On my board (and for example on the MPC832XEMDS) the flash is connected to the localbus ... and this register setting is done, while running from flash ... Hmm.. is this safe? >>> yeah, I

Re: [U-Boot] 83xx and LCRR setting

2009-08-21 Thread Kim Phillips
On Thu, 20 Aug 2009 13:03:09 +0200 Detlev Zundel wrote: > or maybe even always use the mask, define it in the board config and do > a > > #if !defined(LCCR_MASK) > #define LCCR_MASK 0x > #endif ack. > This really depends if and how this applies to the other members of the > 83xx family

Re: [U-Boot] 83xx and LCRR setting

2009-08-21 Thread Kim Phillips
On Thu, 20 Aug 2009 12:05:58 +0200 Heiko Schocher wrote: > >> On my board (and for example on the MPC832XEMDS) the flash is connected > >> to the localbus ... and this register setting is done, while > >> running from flash ... Hmm.. is this safe? > > > > yeah, I'm not quite sure how that works

Re: [U-Boot] 83xx and LCRR setting

2009-08-20 Thread Detlev Zundel
Hi Heiko, > I stumbled over this, just because I didn;t set this > LCRR_DBYP bit, which the CPU sets after a reset, so > what Do you think about this patch? > > 832x, LCRR: change only the valid bits for this register > > Signed-off-by: Heiko Schocher > --- > cpu/mpc83xx/cpu_init.c|6 +++

Re: [U-Boot] 83xx and LCRR setting

2009-08-20 Thread Heiko Schocher
Hello Kim, Kim Phillips schrieb: > On Tue, 18 Aug 2009 15:23:47 +0200 > Heiko Schocher wrote: > >> Hello Kim, > > Hello Heiko, sorry for the late reply, > >> I actually work on an u-boot mpc8321 port (mostly identical with the kmeter1 >> port already in mainline), and I have to set the LCRR (C

Re: [U-Boot] 83xx and LCRR setting

2009-08-19 Thread Heiko Schocher
Hello Kim, Kim Phillips wrote: > On Tue, 18 Aug 2009 15:23:47 +0200 > Heiko Schocher wrote: > >> Hello Kim, > > Hello Heiko, sorry for the late reply, No problem, thanks for your response! >> I actually work on an u-boot mpc8321 port (mostly identical with the kmeter1 >> port already in mainl

Re: [U-Boot] 83xx and LCRR setting

2009-08-19 Thread Kim Phillips
On Tue, 18 Aug 2009 15:23:47 +0200 Heiko Schocher wrote: > Hello Kim, Hello Heiko, sorry for the late reply, > I actually work on an u-boot mpc8321 port (mostly identical with the kmeter1 > port already in mainline), and I have to set the LCRR (Clock Ratio Register > Reference Manual 10.3.1.14)

[U-Boot] 83xx and LCRR setting

2009-08-18 Thread Heiko Schocher
Hello Kim, I actually work on an u-boot mpc8321 port (mostly identical with the kmeter1 port already in mainline), and I have to set the LCRR (Clock Ratio Register Reference Manual 10.3.1.14). As I see in cpu/mpc83xx/cpu_init.c cpu_init_f() this is done while running from flash. Hmm... the Refer