Re: [U-Boot] [PATCH v2 4/4] Flex-OneNAND boundary setting command

2009-03-26 Thread Amul Kumar Saha
OneNAND commands now work for Flex-OneNAND. Add command for changing Flex-OneNAND SLC / MLC boundary. Signed-off-by: Rohit Hagargundgi Signed-off-by: Amul Kumar Saha --- common/cmd_onenand.c | 103 -- include/configs/apollon.h |2 2 files chang

Re: [U-Boot] [PATCH v2 4/4] Flex-OneNAND boundary setting command

2009-03-26 Thread Amul Kumar Saha
Hi Scott, >> I believe that typecasting a UL to an int, is OK. >> Do let me know. > > The compiler will implicitly cast unsigned long to int. The explicit cast > is unnecessary clutter which makes it harder to find casts that aren't OK. Accepted and changed. Thank You Amul. ___

Re: [U-Boot] [PATCH v2 4/4] Flex-OneNAND boundary setting command

2009-03-25 Thread Scott Wood
On Wed, Mar 25, 2009 at 08:44:37PM +0530, Amul Kumar Saha wrote: > >> +die = (int) simple_strtoul(argv[2], NULL, 0); > >> +bdry = (int) simple_strtoul(argv[3], NULL, 0); > > > > Casts should not be necessary. > > > > I believe that typecasting a UL to an int, is OK. > Do let me know. Th

Re: [U-Boot] [PATCH v2 4/4] Flex-OneNAND boundary setting command

2009-03-25 Thread Amul Kumar Saha
Hi Scott, > >> + int blocks = (int) onenand_block(this, from + len) >> +- onenand_block(this, from); > > Why the (int) cast? onenand_block() already returns int. > Resolved >> - if (end_block > (mtd->size >> this->erase_shift)) >> - end_block = mtd->size >> this->erase_shift; >> + if (e

Re: [U-Boot] [PATCH v2 4/4] Flex-OneNAND boundary setting command

2009-03-23 Thread Scott Wood
On Mon, Mar 23, 2009 at 12:36:32PM +0530, Amul Kumar Saha wrote: > diff --git a/common/cmd_onenand.c b/common/cmd_onenand.c > index 5832ff8..ed6681a 100644 > --- a/common/cmd_onenand.c > +++ b/common/cmd_onenand.c > @@ -65,36 +65,49 @@ static int arg_off_size(int argc, char *argv[], ulong > *off,

Re: [U-Boot] [PATCH v2 4/4] Flex-OneNAND boundary setting command

2009-03-23 Thread Amul Kumar Saha
Hi Scott, >> +static inline int onenand_blocksize(loff_t ofs) >> +{ >> + struct onenand_chip *this = mtd->priv; >> + int i; >> + >> + if (!FLEXONENAND(this)) >> + return mtd->erasesize; >> + >> + i = flexonenand_region(mtd, ofs); >> + return mtd->eraseregions[i].erasesize; > > Can we define the i

Re: [U-Boot] [PATCH v2 4/4] Flex-OneNAND boundary setting command

2009-03-09 Thread Scott Wood
On Sun, Mar 08, 2009 at 12:17:36PM +0530, Rohit Hagargundgi wrote: > +static inline int onenand_blocksize(loff_t ofs) > +{ > + struct onenand_chip *this = mtd->priv; > + int i; > + > + if (!FLEXONENAND(this)) > + return mtd->erasesize; > + > + i = flexonenand_region(mtd,

Re: [U-Boot] [PATCH v2 4/4] Flex-OneNAND boundary setting command

2009-03-07 Thread Rohit Hagargundgi
On Thursday 11 December 2008 19:57:53 Rohit Hagargundgi wrote: > Add command for changing Flex-OneNAND SLC / MLC boundary. > Also onenand commands work for Flex-OneNAND. Signed-off-by: Rohit Hagargundgi --- common/cmd_onenand.c | 88 -- includ

[U-Boot] [PATCH v2 4/4] Flex-OneNAND boundary setting command

2008-12-11 Thread Rohit Hagargundgi
Add command for changing Flex-OneNAND SLC / MLC boundary. Signed-off-by: Rohit Hagargundgi <[EMAIL PROTECTED]> --- common/cmd_onenand.c | 65 +++--- 1 files changed, 56 insertions(+), 9 deletions(-) diff --git a/common/cmd_onenand.c b/common/cmd_onen