Hi Adam,
On 19/07/2016 19:51, Adam Duskett wrote:
>> From: feste...@gmail.com
>> Date: Tue, 19 Jul 2016 14:46:38 -0300
>> Subject: Re: [U-Boot] [v2 1/1] wandboard: fix dtb file names.
>> To: adamdusk...@outlook.com
>> CC: u-boot@lists.denx.de; sba...@denx.de
>>
On Tue, Jul 19, 2016 at 2:58 PM, Adam Duskett wrote:
> The original patch that I submitted just changed the dts files to the new
> naming
> scheme found in 4.1.15. Once I submitted that,
And the naming scheme in 4.1.15 vendor kernel is the problem. Make it
match the dtb names of the mainline ke
On Tue, Jul 19, 2016 at 02:51:11PM -0300, Fabio Estevam wrote:
> On Tue, Jul 19, 2016 at 2:43 PM, Tom Rini wrote:
>
> > But this does show that we need to step back and think about how to more
> > easily do what this is trying to do. If $soc was set as in Stefan's
> > patch for example, we would
> From: feste...@gmail.com
> Date: Tue, 19 Jul 2016 14:51:11 -0300
> Subject: Re: [U-Boot] [v2 1/1] wandboard: fix dtb file names.
> To: tr...@konsulko.com
> CC: adamdusk...@outlook.com; u-boot@lists.denx.de
>
> On Tue, Jul 19, 2016 at 2:43 PM, Tom Rini wrote:
>
> &
> From: feste...@gmail.com> Date: Tue, 19 Jul 2016 14:46:38 -0300
> Subject: Re: [U-Boot] [v2 1/1] wandboard: fix dtb file names.
> To: adamdusk...@outlook.com
> CC: u-boot@lists.denx.de; sba...@denx.de
>
> On Tue, Jul 19, 2016 at 2:40 PM, Adam Duskett wrote:
>
> >
On Tue, Jul 19, 2016 at 02:32:17PM -0300, Fabio Estevam wrote:
> On Tue, Jul 19, 2016 at 2:23 PM, Adam Duskett wrote:
> > With the previous suggestion from Wolfgang Denk, this patch removes
> > the findfdt function from wandboard.h and instead replaces it with
> > some simple logic in wandboard.c.
On Tue, Jul 19, 2016 at 2:43 PM, Tom Rini wrote:
> But this does show that we need to step back and think about how to more
> easily do what this is trying to do. If $soc was set as in Stefan's
> patch for example, we would just need board_name to be being set in
> lowercase rather than upper ca
Dear Adam,
In message you wrote:
>
> + int length = strlen(getenv("board_rev")) + strlen("-wandboard-rev") +
> + strlen(getenv("board_name")) + strlen(".dtb") + 1;
> + fdtfile = malloc(length);
Don't you think you should add some error checking here? Each of the
getenv(
On Tue, Jul 19, 2016 at 2:40 PM, Adam Duskett wrote:
>> I prefer to keep the current code as is.
> If it is left as is, then the previous version of the patch needs to be
> applied
> because the new dtb file names in kernel 4.1.15 are different.
Then please change the name of the 4.1.15 vendor k
> From: feste...@gmail.com
> Date: Tue, 19 Jul 2016 14:32:17 -0300
> Subject: Re: [U-Boot] [v2 1/1] wandboard: fix dtb file names.
> To: adamdusk...@outlook.com
> CC: u-boot@lists.denx.de; sba...@denx.de
>
> On Tue, Jul 19, 2016 at 2:23 PM, Adam Duskett wrote:
> > W
On Tue, Jul 19, 2016 at 2:23 PM, Adam Duskett wrote:
> With the previous suggestion from Wolfgang Denk, this patch removes
> the findfdt function from wandboard.h and instead replaces it with
> some simple logic in wandboard.c.
>
> The new function "set_fdtfile" is called in board_late_init. This
With the previous suggestion from Wolfgang Denk, this patch removes
the findfdt function from wandboard.h and instead replaces it with
some simple logic in wandboard.c.
The new function "set_fdtfile" is called in board_late_init. This
function simply finds the length of the dtb file name, allocat
12 matches
Mail list logo
