Re: [U-Boot] [patch] rm9200 ethernet driver: board-specific quirk?(csb337)

2009-07-10 Thread Wolfgang Denk
Dear Jean-Christophe PLAGNIOL-VILLARD, In message <20090613145439.gg25...@game.jcrosoft.org> you wrote: > > > i dont get it. the CPP expands into if(0) and unless you have a completely > > shitty compiler, gcc will do dead code elimination on it resulting in the > > same > > binary size. > I'v

Re: [U-Boot] [patch] rm9200 ethernet driver: board-specific quirk (csb337)

2009-06-19 Thread Jean-Christophe PLAGNIOL-VILLARD
On 00:01 Fri 19 Jun , Ben Warren wrote: > David Brownell wrote: > > On Wednesday 17 June 2009, Ben Warren wrote: > > > >> Applied to net repo. > >> > > > > Thanks. Random question: is that driver going to move > > into drivers/net or will it stay in cpu/arm920t? I thought > > I saw y

Re: [U-Boot] [patch] rm9200 ethernet driver: board-specific quirk (csb337)

2009-06-19 Thread Ben Warren
David Brownell wrote: > On Wednesday 17 June 2009, Ben Warren wrote: > >> Applied to net repo. >> > > Thanks. Random question: is that driver going to move > into drivers/net or will it stay in cpu/arm920t? I thought > I saw you moving things out of cpu/* a while back. > > - Dave > >

Re: [U-Boot] [patch] rm9200 ethernet driver: board-specific quirk (csb337)

2009-06-18 Thread David Brownell
On Wednesday 17 June 2009, Ben Warren wrote: > Applied to net repo. Thanks. Random question: is that driver going to move into drivers/net or will it stay in cpu/arm920t? I thought I saw you moving things out of cpu/* a while back. - Dave ___ U-Boot

Re: [U-Boot] [patch] rm9200 ethernet driver: board-specific quirk (csb337)

2009-06-17 Thread Ben Warren
David, David Brownell wrote: > CSB337 boards originally shipped with MicroMonitor, not U-Boot; > and with a version using a different convention for recording > Ethernet addresses than anyone else. To avoid breaking Linux > when it uses U-Boot, have it use the same convention on that > hardware.

Re: [U-Boot] [patch] rm9200 ethernet driver: board-specific quirk (csb337)

2009-06-13 Thread David Brownell
On Saturday 13 June 2009, Mike Frysinger wrote: > > > > > See above.  There already *IS* such an #ifdef, but it's just not > > > > > cluttering up the guts of that driver. > > > > > > > > you adding MUST have NO size impact on other board > > > > > > > > if we apply you code as it we will increase

Re: [U-Boot] [patch] rm9200 ethernet driver: board-specific quirk?(csb337)

2009-06-13 Thread Mike Frysinger
On Saturday 13 June 2009 10:54:39 Jean-Christophe PLAGNIOL-VILLARD wrote: > On 10:50 Sat 13 Jun , Mike Frysinger wrote: > > On Saturday 13 June 2009 08:28:23 Jean-Christophe PLAGNIOL-VILLARD wrote: > > > On 04:13 Sat 13 Jun , David Brownell wrote: > > > > On Saturday 13 June 2009, Jean-Chri

Re: [U-Boot] [patch] rm9200 ethernet driver: board-specific quirk?(csb337)

2009-06-13 Thread Jean-Christophe PLAGNIOL-VILLARD
On 10:50 Sat 13 Jun , Mike Frysinger wrote: > On Saturday 13 June 2009 08:28:23 Jean-Christophe PLAGNIOL-VILLARD wrote: > > On 04:13 Sat 13 Jun , David Brownell wrote: > > > On Saturday 13 June 2009, Jean-Christophe PLAGNIOL-VILLARD wrote: > > > > > The machine_is_X() macros are automatical

Re: [U-Boot] [patch] rm9200 ethernet driver: board-specific quirk (csb337)

2009-06-13 Thread Jean-Christophe PLAGNIOL-VILLARD
On 04:13 Sat 13 Jun , David Brownell wrote: > On Saturday 13 June 2009, Jean-Christophe PLAGNIOL-VILLARD wrote: > > > > > > The machine_is_X() macros are automatically #ifdeffed in > > > the header; no size impact.  Read ... > > > > If I use this pacth on the rm9200ek the u-boot.bin size will

Re: [U-Boot] [patch] rm9200 ethernet driver: board-specific quirk (csb337)

2009-06-13 Thread David Brownell
On Saturday 13 June 2009, Jean-Christophe PLAGNIOL-VILLARD wrote: > > > > The machine_is_X() macros are automatically #ifdeffed in > > the header; no size impact.  Read ... > > If I use this pacth on the rm9200ek the u-boot.bin size will increase > for nothing I'm not following you. The lines a

Re: [U-Boot] [patch] rm9200 ethernet driver: board-specific quirk (csb337)

2009-06-13 Thread Jean-Christophe PLAGNIOL-VILLARD
On 15:02 Fri 12 Jun , David Brownell wrote: > On Friday 12 June 2009, Jean-Christophe PLAGNIOL-VILLARD wrote: > > On 11:14 Tue 09 Jun , David Brownell wrote: > > > I'm not really a fan of this > > but ok if I see the csn337 board patch > > I meant to send that in before, thanks for the re

Re: [U-Boot] [patch] rm9200 ethernet driver: board-specific quirk (csb337)

2009-06-12 Thread Ben Warren
Jean-Christophe PLAGNIOL-VILLARD wrote: > On 11:14 Tue 09 Jun , David Brownell wrote: > >> CSB337 boards originally shipped with MicroMonitor, not U-Boot; >> and with a version using a different convention for recording >> Ethernet addresses than anyone else. To avoid breaking Linux >> when

Re: [U-Boot] [patch] rm9200 ethernet driver: board-specific quirk (csb337)

2009-06-12 Thread David Brownell
On Friday 12 June 2009, Jean-Christophe PLAGNIOL-VILLARD wrote: > On 11:14 Tue 09 Jun , David Brownell wrote: > I'm not really a fan of this > but ok if I see the csn337 board patch I meant to send that in before, thanks for the reminder. The email I just sent has that. If you don't like it,

Re: [U-Boot] [patch] rm9200 ethernet driver: board-specific quirk (csb337)

2009-06-12 Thread Jean-Christophe PLAGNIOL-VILLARD
On 11:14 Tue 09 Jun , David Brownell wrote: > CSB337 boards originally shipped with MicroMonitor, not U-Boot; > and with a version using a different convention for recording > Ethernet addresses than anyone else. To avoid breaking Linux > when it uses U-Boot, have it use the same convention on

[U-Boot] [patch] rm9200 ethernet driver: board-specific quirk (csb337)

2009-06-09 Thread David Brownell
CSB337 boards originally shipped with MicroMonitor, not U-Boot; and with a version using a different convention for recording Ethernet addresses than anyone else. To avoid breaking Linux when it uses U-Boot, have it use the same convention on that hardware. Signed-off-by: David Brownell --- cpu