Re: [U-Boot] [linux-sunxi] Re: [PATCH] video: add cfb console driver for sunxi

2014-08-06 Thread Maxime Ripard
On Tue, Aug 05, 2014 at 11:37:11PM +0200, Michal Suchanek wrote: > > I'm probably missing a bit of context, but one thing I still don't get > > is why you're taking into account the simplefb <-> KMS handover. It's > > a case that shouldn't exist. > > > > By essence, simplefb has never been meant fo

Re: [U-Boot] [linux-sunxi] Re: [PATCH] video: add cfb console driver for sunxi

2014-08-05 Thread Michal Suchanek
On 5 August 2014 23:03, Maxime Ripard wrote: > On Mon, Aug 04, 2014 at 05:05:00PM +0200, Luc Verhaegen wrote: >> On Mon, Aug 04, 2014 at 10:39:13AM +0200, Hans de Goede wrote: >> > Hi Luc, >> > >> > First of all many thanks for your work on this. >> > >> > ATM I don't have time to do a full review

Re: [U-Boot] [linux-sunxi] Re: [PATCH] video: add cfb console driver for sunxi

2014-08-05 Thread Maxime Ripard
On Mon, Aug 04, 2014 at 05:05:00PM +0200, Luc Verhaegen wrote: > On Mon, Aug 04, 2014 at 10:39:13AM +0200, Hans de Goede wrote: > > Hi Luc, > > > > First of all many thanks for your work on this. > > > > ATM I don't have time to do a full review, but I don't expect there > > to be too many supris

Re: [U-Boot] [linux-sunxi] Re: [PATCH] video: add cfb console driver for sunxi

2014-08-05 Thread Maxime Ripard
On Tue, Aug 05, 2014 at 12:10:30AM +0200, Henrik Nordström wrote: > > How's this for the sunxi implementation of simplefb: > > * u-boot lists used clocks, to allow some code in simplefb.c to grab all > > clocks. This is necessary as the list of clocks might change with > > changed cfb-console

Re: [U-Boot] [linux-sunxi] Re: [PATCH] video: add cfb console driver for sunxi

2014-08-05 Thread Maxime Ripard
On Tue, Aug 05, 2014 at 01:56:36PM +0200, Hans de Goede wrote: > Hi, > > On 08/02/2014 06:14 PM, Luc Verhaegen wrote: > > This adds a fixed mode hdmi driver (lcd to be added in future) for the > > sunxi platform. Current config is such that 8MB is shaved off at the top > > of the RAM. Simplefb sup

Re: [U-Boot] [linux-sunxi] Re: [PATCH] video: add cfb console driver for sunxi

2014-08-04 Thread Henrik Nordström
mån 2014-08-04 klockan 19:28 +0200 skrev Luc Verhaegen: > We can work around most situations gracefully in kernelspace. We should > for instance never set a bad mode, and never show random memory content, > as that is a total no-go. So some code will have to exist to cleanly > disable the displ

Re: [U-Boot] [linux-sunxi] Re: [PATCH] video: add cfb console driver for sunxi

2014-08-04 Thread Henrik Nordström
mån 2014-08-04 klockan 18:53 +0200 skrev Michal Suchanek: > Then you have to define what is compatible. Yes, and the part I responded to was odd unexpected combinations of u-boot only partially providing the right information (missing in DT) or kernel not having enabled support. Likewise there i

Re: [U-Boot] [linux-sunxi] Re: [PATCH] video: add cfb console driver for sunxi

2014-08-04 Thread Luc Verhaegen
On Mon, Aug 04, 2014 at 05:31:36PM +0200, Henrik Nordström wrote: > mån 2014-08-04 klockan 17:05 +0200 skrev Luc Verhaegen: > > But... What do we do when u-boot sets up cfb, without setting up a > > simplefb node in the dt. Or what do we do when a simplefb node is set > > up, but no simplefb code

Re: [U-Boot] [linux-sunxi] Re: [PATCH] video: add cfb console driver for sunxi

2014-08-04 Thread Michal Suchanek
On 4 August 2014 17:31, Henrik Nordström wrote: > mån 2014-08-04 klockan 17:05 +0200 skrev Luc Verhaegen: >> But... What do we do when u-boot sets up cfb, without setting up a >> simplefb node in the dt. Or what do we do when a simplefb node is set >> up, but no simplefb code is included in the ke

Re: [U-Boot] [linux-sunxi] Re: [PATCH] video: add cfb console driver for sunxi

2014-08-04 Thread Henrik Nordström
mån 2014-08-04 klockan 17:05 +0200 skrev Luc Verhaegen: > But... What do we do when u-boot sets up cfb, without setting up a > simplefb node in the dt. Or what do we do when a simplefb node is set > up, but no simplefb code is included in the kernel? Well, we then either > need to claim the clock