Re: [U-Boot] [UBOOT][PATCHv4 4/6] spi: add TI QSPI driver

2013-10-06 Thread Sourav Poddar
On Sunday 06 October 2013 09:00 PM, Jagan Teki wrote: On Sun, Oct 6, 2013 at 3:44 PM, Sourav Poddar wrote: On Sunday 06 October 2013 02:14 PM, Jagan Teki wrote: What if this code is placed in cs_active() with BEGIN flag.? + /* setup command reg */ + qslave->cmd = 0; + qslav

Re: [U-Boot] [UBOOT][PATCHv4 4/6] spi: add TI QSPI driver

2013-10-06 Thread Jagan Teki
On Sun, Oct 6, 2013 at 3:44 PM, Sourav Poddar wrote: > On Sunday 06 October 2013 02:14 PM, Jagan Teki wrote: >> >> What if this code is placed in cs_active() with BEGIN flag.? > + /* setup command reg */ >> + qslave->cmd = 0; >> + qslave->cmd |= QSPI_WLEN(8); >> + qslave->c

Re: [U-Boot] [UBOOT][PATCHv4 4/6] spi: add TI QSPI driver

2013-10-06 Thread Sourav Poddar
On Sunday 06 October 2013 02:14 PM, Jagan Teki wrote: What if this code is placed in cs_active() with BEGIN flag.? + /* setup command reg */ + qslave->cmd = 0; + qslave->cmd |= QSPI_WLEN(8); + qslave->cmd |= QSPI_EN_CS(slave->cs); + if (flags& SPI_3WIRE) +

Re: [U-Boot] [UBOOT][PATCHv4 4/6] spi: add TI QSPI driver

2013-10-06 Thread Jagan Teki
What if this code is placed in cs_active() with BEGIN flag.? + /* setup command reg */ + qslave->cmd = 0; + qslave->cmd |= QSPI_WLEN(8); + qslave->cmd |= QSPI_EN_CS(slave->cs); + if (flags & SPI_3WIRE) + qslave->cmd |= QSPI_3_PIN; + qslave->cmd |= 0

Re: [U-Boot] [UBOOT][PATCHv4 4/6] spi: add TI QSPI driver

2013-10-05 Thread Sourav Poddar
On Saturday 05 October 2013 05:10 PM, Jagan Teki wrote: On Sat, Oct 5, 2013 at 3:25 PM, Sourav Poddar wrote: On Saturday 05 October 2013 03:11 PM, Jagan Teki wrote: On Sat, Oct 5, 2013 at 11:38 AM, Sourav Poddar wrote: On Saturday 05 October 2013 01:43 AM, Jagan Teki wrote: On Sat, Oct 5, 20

Re: [U-Boot] [UBOOT][PATCHv4 4/6] spi: add TI QSPI driver

2013-10-05 Thread Jagan Teki
On Sat, Oct 5, 2013 at 3:25 PM, Sourav Poddar wrote: > On Saturday 05 October 2013 03:11 PM, Jagan Teki wrote: >> >> On Sat, Oct 5, 2013 at 11:38 AM, Sourav Poddar >> wrote: >>> >>> On Saturday 05 October 2013 01:43 AM, Jagan Teki wrote: On Sat, Oct 5, 2013 at 1:32 AM, Sourav Poddar

Re: [U-Boot] [UBOOT][PATCHv4 4/6] spi: add TI QSPI driver

2013-10-05 Thread Sourav Poddar
On Saturday 05 October 2013 03:11 PM, Jagan Teki wrote: On Sat, Oct 5, 2013 at 11:38 AM, Sourav Poddar wrote: On Saturday 05 October 2013 01:43 AM, Jagan Teki wrote: On Sat, Oct 5, 2013 at 1:32 AM, Sourav Poddar wrote: On Saturday 05 October 2013 12:27 AM, Jagan Teki wrote: On Fri, Oct 4, 20

Re: [U-Boot] [UBOOT][PATCHv4 4/6] spi: add TI QSPI driver

2013-10-05 Thread Jagan Teki
On Sat, Oct 5, 2013 at 11:38 AM, Sourav Poddar wrote: > On Saturday 05 October 2013 01:43 AM, Jagan Teki wrote: >> >> On Sat, Oct 5, 2013 at 1:32 AM, Sourav Poddar >> wrote: >>> >>> On Saturday 05 October 2013 12:27 AM, Jagan Teki wrote: On Fri, Oct 4, 2013 at 8:21 PM, Sourav Poddar

Re: [U-Boot] [UBOOT][PATCHv4 4/6] spi: add TI QSPI driver

2013-10-04 Thread Sourav Poddar
On Saturday 05 October 2013 01:43 AM, Jagan Teki wrote: On Sat, Oct 5, 2013 at 1:32 AM, Sourav Poddar wrote: On Saturday 05 October 2013 12:27 AM, Jagan Teki wrote: On Fri, Oct 4, 2013 at 8:21 PM, Sourav Poddar wrote: From: Matt Porter Adds a SPI master driver for the TI QSPI peripheral. Si

Re: [U-Boot] [UBOOT][PATCHv4 4/6] spi: add TI QSPI driver

2013-10-04 Thread Jagan Teki
On Sat, Oct 5, 2013 at 1:32 AM, Sourav Poddar wrote: > On Saturday 05 October 2013 12:27 AM, Jagan Teki wrote: >> >> On Fri, Oct 4, 2013 at 8:21 PM, Sourav Poddar >> wrote: >>> >>> From: Matt Porter >>> >>> Adds a SPI master driver for the TI QSPI peripheral. >>> >>> Signed-off-by: Matt Porter >>>

Re: [U-Boot] [UBOOT][PATCHv4 4/6] spi: add TI QSPI driver

2013-10-04 Thread Sourav Poddar
On Saturday 05 October 2013 12:27 AM, Jagan Teki wrote: On Fri, Oct 4, 2013 at 8:21 PM, Sourav Poddar wrote: From: Matt Porter Adds a SPI master driver for the TI QSPI peripheral. Signed-off-by: Matt Porter Signed-off-by: Sourav Poddar [Added quad read support and memory mapped support). Wha

Re: [U-Boot] [UBOOT][PATCHv4 4/6] spi: add TI QSPI driver

2013-10-04 Thread Jagan Teki
On Fri, Oct 4, 2013 at 8:21 PM, Sourav Poddar wrote: > From: Matt Porter > > Adds a SPI master driver for the TI QSPI peripheral. > > Signed-off-by: Matt Porter > Signed-off-by: Sourav Poddar > [Added quad read support and memory mapped support). What is this comment, any specific? > --- You m

[U-Boot] [UBOOT][PATCHv4 4/6] spi: add TI QSPI driver

2013-10-04 Thread Sourav Poddar
From: Matt Porter Adds a SPI master driver for the TI QSPI peripheral. Signed-off-by: Matt Porter Signed-off-by: Sourav Poddar [Added quad read support and memory mapped support). --- drivers/spi/Makefile |1 + drivers/spi/ti_qspi.c | 328