Re: [U-Boot] [U-Boot, 3/9] nand: add a hw specific subcommand to the nand command.

2011-08-04 Thread Wolfgang Denk
Dear Scott Wood, In message <4e3b0109.5070...@freescale.com> you wrote: > > How about some way of board/controller/etc. code plugging in commands to > "nand" without "hwfunc"? Could be a chained handler, or copying entries > into a command table, or some way of generalizing the stuff in > comm

Re: [U-Boot] [U-Boot, 3/9] nand: add a hw specific subcommand to the nand command.

2011-08-04 Thread Scott Wood
On 08/04/2011 03:14 PM, Wolfgang Denk wrote: > Dear Scott Wood, > > In message<4e3af62b.8080...@freescale.com> you wrote: >> >> Again, I think "nand hwfunc" conveys little information about what it's >> actually going to do, versus something like: >> >> => nandrbl >> off > > I agree with Heiko th

Re: [U-Boot] [U-Boot, 3/9] nand: add a hw specific subcommand to the nand command.

2011-08-04 Thread Wolfgang Denk
Dear Scott Wood, In message <4e3af62b.8080...@freescale.com> you wrote: > > Again, I think "nand hwfunc" conveys little information about what it's > actually going to do, versus something like: > > => nandrbl > off I agree with Heiko that NAND related commands should be implemented as subcomma

Re: [U-Boot] [U-Boot, 3/9] nand: add a hw specific subcommand to the nand command.

2011-08-04 Thread Scott Wood
On 08/04/2011 12:40 AM, Heiko Schocher wrote: > Scott Wood wrote: >> What if there are multiple such commands? You'd end up with "nand hwfunc > > Then we would have a (as hwfunc is a nand subcommand) hwfunc > subcommand(s) ... The question was rhetorical, as the next sentence indicates -- unless

Re: [U-Boot] [U-Boot, 3/9] nand: add a hw specific subcommand to the nand command.

2011-08-03 Thread Heiko Schocher
Hello Scott, Scott Wood wrote: > On Wed, 3 Aug 2011 07:14:51 +0200 > Heiko Schocher wrote: > >> Hello Scott, >> >> Scott Wood wrote: >>> Sorry for the delay, didn't see this the first time around -- just >>> noticed it in patchwork. >> No problem. Thanks for the review! >> >>> On Sat, Jul 16, 20

Re: [U-Boot] [U-Boot, 3/9] nand: add a hw specific subcommand to the nand command.

2011-08-03 Thread Scott Wood
On Wed, 3 Aug 2011 07:14:51 +0200 Heiko Schocher wrote: > Hello Scott, > > Scott Wood wrote: > > Sorry for the delay, didn't see this the first time around -- just > > noticed it in patchwork. > > No problem. Thanks for the review! > > > On Sat, Jul 16, 2011 at 12:06:44AM -, Heiko Schocher

Re: [U-Boot] [U-Boot, 3/9] nand: add a hw specific subcommand to the nand command.

2011-08-02 Thread Heiko Schocher
Hello Scott, Scott Wood wrote: > Sorry for the delay, didn't see this the first time around -- just > noticed it in patchwork. No problem. Thanks for the review! > On Sat, Jul 16, 2011 at 12:06:44AM -, Heiko Schocher wrote: >> @@ -739,6 +743,10 @@ U_BOOT_CMD( >> "nand env.oob set off|pa

Re: [U-Boot] [U-Boot, 3/9] nand: add a hw specific subcommand to the nand command.

2011-08-02 Thread Scott Wood
Sorry for the delay, didn't see this the first time around -- just noticed it in patchwork. On Sat, Jul 16, 2011 at 12:06:44AM -, Heiko Schocher wrote: > @@ -739,6 +743,10 @@ U_BOOT_CMD( > "nand env.oob set off|partition - set enviromnent offset\n" > "nand env.oob get - get environ