Re: [U-Boot] [U-Boot, 1/3] rockchip: boot mode: parse adc channel from dts

2017-12-01 Thread Simon Glass
Hi Philipp, On 29 November 2017 at 02:53, Dr. Philipp Tomsich wrote: > [Getting Simon's email-address right, helps…] > > Simon, > > could you comment on this one from a general U-Boot architecture and > DM-maintainer perspective? > > Thanks, > Philipp. > > On 29 Nov 2017, at 10:50, Dr. Philipp To

Re: [U-Boot] [U-Boot, 1/3] rockchip: boot mode: parse adc channel from dts

2017-11-29 Thread Andy Yan
Hi PHilipp: On 2017年11月29日 17:53, Dr. Philipp Tomsich wrote: [Getting Simon's email-address right, helps…] Simon, could you comment on this one from a general U-Boot architecture and DM-maintainer perspective? Thanks, Philipp. On 29 Nov 2017, at 10:50, Dr. Philipp Tomsich

Re: [U-Boot] [U-Boot, 1/3] rockchip: boot mode: parse adc channel from dts

2017-11-29 Thread Dr . Philipp Tomsich
[Getting Simon's email-address right, helps…] Simon, could you comment on this one from a general U-Boot architecture and DM-maintainer perspective? Thanks, Philipp. > On 29 Nov 2017, at 10:50, Dr. Philipp Tomsich > > wrote: > > >> On 29 Nov 20

Re: [U-Boot] [U-Boot, 1/3] rockchip: boot mode: parse adc channel from dts

2017-11-29 Thread Dr. Philipp Tomsich
Simon, could you comment on this one from a general U-Boot architecture and DM-maintainer perspective? Thanks, Philipp. > On 29 Nov 2017, at 10:50, Dr. Philipp Tomsich > wrote: > > >> On 29 Nov 2017, at 07:34, Andy Yan > > wrote: >> >> Hi Philipp: >> >> >>

Re: [U-Boot] [U-Boot, 1/3] rockchip: boot mode: parse adc channel from dts

2017-11-29 Thread Dr. Philipp Tomsich
> On 29 Nov 2017, at 07:34, Andy Yan wrote: > > Hi Philipp: > > > On 2017年11月28日 21:59, Philipp Tomsich wrote: >> +sjg >> >> On Tue, 28 Nov 2017, Andy Yan wrote: >> >>> Most the current rockchip based boards use adc channel >>> 1 detect the download key, but there are also some >>> boards li

Re: [U-Boot] [U-Boot, 1/3] rockchip: boot mode: parse adc channel from dts

2017-11-28 Thread Andy Yan
Hi Philipp: On 2017年11月28日 21:59, Philipp Tomsich wrote: +sjg On Tue, 28 Nov 2017, Andy Yan wrote: Most the current rockchip based boards use adc channel 1 detect the download key, but there are also some boards like rv1108 based plaform use adc channel 0. So we parse the adc channel from dt

Re: [U-Boot] [U-Boot, 1/3] rockchip: boot mode: parse adc channel from dts

2017-11-28 Thread Philipp Tomsich
+sjg On Tue, 28 Nov 2017, Andy Yan wrote: Most the current rockchip based boards use adc channel 1 detect the download key, but there are also some boards like rv1108 based plaform use adc channel 0. So we parse the adc channel from dts if we can get it, otherwise we use the channel 1 as defaul

Re: [U-Boot] [U-Boot, 1/3] rockchip: boot mode: parse adc channel from dts

2017-11-28 Thread Philipp Tomsich
> Most the current rockchip based boards use adc channel > 1 detect the download key, but there are also some > boards like rv1108 based plaform use adc channel 0. > So we parse the adc channel from dts if we can get > it, otherwise we use the channel 1 as default. > > Signed-off-by: Andy Yan > -