Re: [U-Boot] [RFC V2 PATCH 0/3] Add cache for block devices

2016-03-22 Thread Eric Nelson
Hi Marek, On 03/20/2016 06:59 PM, Marek Vasut wrote: > On 03/21/2016 02:45 AM, Eric Nelson wrote: >> Here's a more full-featured implementation of a cache for block >> devices that uses a small linked list of cache blocks. > > Why do you use linked list ? You have four entries, you can as well >

Re: [U-Boot] [RFC V2 PATCH 0/3] Add cache for block devices

2016-03-21 Thread Marek Vasut
On 03/21/2016 06:56 PM, Eric Nelson wrote: > Hi Marek, Hi! > On 03/21/2016 09:49 AM, Marek Vasut wrote: >> On 03/21/2016 02:48 PM, Eric Nelson wrote: >>> On 03/20/2016 06:59 PM, Marek Vasut wrote: On 03/21/2016 02:45 AM, Eric Nelson wrote: > Here's a more full-featured implementation of

Re: [U-Boot] [RFC V2 PATCH 0/3] Add cache for block devices

2016-03-21 Thread Eric Nelson
Hi Marek, On 03/21/2016 09:49 AM, Marek Vasut wrote: > On 03/21/2016 02:48 PM, Eric Nelson wrote: >> On 03/20/2016 06:59 PM, Marek Vasut wrote: >>> On 03/21/2016 02:45 AM, Eric Nelson wrote: Here's a more full-featured implementation of a cache for block devices that uses a small linked

Re: [U-Boot] [RFC V2 PATCH 0/3] Add cache for block devices

2016-03-21 Thread Marek Vasut
On 03/21/2016 02:48 PM, Eric Nelson wrote: > Hi Marek, > > On 03/20/2016 06:59 PM, Marek Vasut wrote: >> On 03/21/2016 02:45 AM, Eric Nelson wrote: >>> Here's a more full-featured implementation of a cache for block >>> devices that uses a small linked list of cache blocks. >> >> Why do you use li

Re: [U-Boot] [RFC V2 PATCH 0/3] Add cache for block devices

2016-03-20 Thread Marek Vasut
On 03/21/2016 02:45 AM, Eric Nelson wrote: > Here's a more full-featured implementation of a cache for block devices > that uses a small linked list of cache blocks. Why do you use linked list ? You have four entries, you can as well use fixed array. Maybe you should implement an adaptive cache wo

[U-Boot] [RFC V2 PATCH 0/3] Add cache for block devices

2016-03-20 Thread Eric Nelson
Here's a more full-featured implementation of a cache for block devices that uses a small linked list of cache blocks. Experimentation loading a 4.5 MiB kernel from the root directory of a FAT filesystem shows that a single cache entry of a single block is the only Loading the same from the /bo