Re: [U-Boot] [RFC PATCH 1/2] USB: SS: Add support for Super Speed USB interface

2012-10-26 Thread Marek Vasut
Dear Vivek Gautam, [...] > >> > >> Isn't USB_PRINTF itself a conditional debug print ? > > > > Yes, but I'd prefer to kill USB_PRINTF altogether in favor of debug(). > > Ok, will switch to debug(...). > And may be in that case we may try to eliminate USB _PRINTF and > other such macro altogethe

Re: [U-Boot] [RFC PATCH 1/2] USB: SS: Add support for Super Speed USB interface

2012-10-26 Thread Vivek Gautam
Hi Marek, On Fri, Oct 26, 2012 at 3:48 PM, Marek Vasut wrote: > Dear Vivek Gautam, > > [...] >> >> This comes as an affect of introduction of "struct usb_ep_desc" >> which eventually contains "struct usb_endpoint_descriptor" and >> "struct usb_ss_ep_comp_descriptor". > > I see, can we split this?

Re: [U-Boot] [RFC PATCH 1/2] USB: SS: Add support for Super Speed USB interface

2012-10-26 Thread Marek Vasut
Dear Vivek Gautam, [...] > > This comes as an affect of introduction of "struct usb_ep_desc" > which eventually contains "struct usb_endpoint_descriptor" and > "struct usb_ss_ep_comp_descriptor". I see, can we split this? I really enjoy small incremental patches, it's much easier to bisect issu

Re: [U-Boot] [RFC PATCH 1/2] USB: SS: Add support for Super Speed USB interface

2012-10-26 Thread Vivek Gautam
Dear Marek, CCing Simon Glass. On Tue, Oct 23, 2012 at 5:10 PM, Marek Vasut wrote: > Dear Vivek Gautam, > >> This adds usb framework support for super-speed usb, which will >> further facilitate to add stack support for xHCI. >> >> Signed-off-by: Vikas C Sajjan >> Signedoff-by: Vivek Gautam >

[U-Boot] [RFC PATCH 1/2] USB: SS: Add support for Super Speed USB interface

2012-10-23 Thread Vivek Gautam
This adds usb framework support for super-speed usb, which will further facilitate to add stack support for xHCI. Signed-off-by: Vikas C Sajjan Signedoff-by: Vivek Gautam --- common/cmd_usb.c |6 +- common/usb.c | 41 - common/usb_hub.c | 26 +- c

Re: [U-Boot] [RFC PATCH 1/2] USB: SS: Add support for Super Speed USB interface

2012-10-23 Thread Marek Vasut
Dear Vivek Gautam, > This adds usb framework support for super-speed usb, which will > further facilitate to add stack support for xHCI. > > Signed-off-by: Vikas C Sajjan > Signedoff-by: Vivek Gautam CCing Benoit, (help me! ;-) ) I'll be blunt and technical below, try not to take it personall