Re: [U-Boot] [RFC PATCH 03/11] SPL: FIT: factor out spl_load_fit_image()

2017-01-23 Thread André Przywara
On 23/01/17 08:53, Lokesh Vutla wrote: Hi Lokesh, thanks a lot for having a thorough look at it! >> On Friday 20 January 2017 07:23 AM, Andre Przywara wrote: >> At the moment we load two images from a FIT image: the actual U-Boot >> image and the DTB. Both times we have very similar code to deal

Re: [U-Boot] [RFC PATCH 03/11] SPL: FIT: factor out spl_load_fit_image()

2017-01-23 Thread Tom Rini
On Mon, Jan 23, 2017 at 07:01:38PM +0530, Lokesh Vutla wrote: > Tom, > > On Monday 23 January 2017 06:28 PM, Tom Rini wrote: > > On Mon, Jan 23, 2017 at 02:23:40PM +0530, Lokesh Vutla wrote: > >> > >> > >> On Friday 20 January 2017 07:23 AM, Andre Przywara wrote: > >>> At the moment we load two im

Re: [U-Boot] [RFC PATCH 03/11] SPL: FIT: factor out spl_load_fit_image()

2017-01-23 Thread Lokesh Vutla
Tom, On Monday 23 January 2017 06:28 PM, Tom Rini wrote: > On Mon, Jan 23, 2017 at 02:23:40PM +0530, Lokesh Vutla wrote: >> >> >> On Friday 20 January 2017 07:23 AM, Andre Przywara wrote: >>> At the moment we load two images from a FIT image: the actual U-Boot >>> image and the DTB. Both times we

Re: [U-Boot] [RFC PATCH 03/11] SPL: FIT: factor out spl_load_fit_image()

2017-01-23 Thread Tom Rini
On Mon, Jan 23, 2017 at 02:23:40PM +0530, Lokesh Vutla wrote: > > > On Friday 20 January 2017 07:23 AM, Andre Przywara wrote: > > At the moment we load two images from a FIT image: the actual U-Boot > > image and the DTB. Both times we have very similar code to deal with > > alignment requirement

Re: [U-Boot] [RFC PATCH 03/11] SPL: FIT: factor out spl_load_fit_image()

2017-01-23 Thread Lokesh Vutla
On Friday 20 January 2017 07:23 AM, Andre Przywara wrote: > At the moment we load two images from a FIT image: the actual U-Boot > image and the DTB. Both times we have very similar code to deal with > alignment requirement the media we load from imposes upon us. > Factor out this code into a new

Re: [U-Boot] [RFC PATCH 03/11] SPL: FIT: factor out spl_load_fit_image()

2017-01-22 Thread Kever Yang
Hi Andre, On 01/22/2017 06:42 PM, André Przywara wrote: On 22/01/17 07:16, Kever Yang wrote: Hi Andre, On 01/20/2017 09:53 AM, Andre Przywara wrote: At the moment we load two images from a FIT image: the actual U-Boot image and the DTB. Both times we have very similar code to deal with alignm

Re: [U-Boot] [RFC PATCH 03/11] SPL: FIT: factor out spl_load_fit_image()

2017-01-22 Thread André Przywara
On 22/01/17 07:16, Kever Yang wrote: > Hi Andre, > > On 01/20/2017 09:53 AM, Andre Przywara wrote: >> At the moment we load two images from a FIT image: the actual U-Boot >> image and the DTB. Both times we have very similar code to deal with >> alignment requirement the media we load from imposes

Re: [U-Boot] [RFC PATCH 03/11] SPL: FIT: factor out spl_load_fit_image()

2017-01-21 Thread Kever Yang
Hi Andre, On 01/20/2017 09:53 AM, Andre Przywara wrote: At the moment we load two images from a FIT image: the actual U-Boot image and the DTB. Both times we have very similar code to deal with alignment requirement the media we load from imposes upon us. Factor out this code into a new function

[U-Boot] [RFC PATCH 03/11] SPL: FIT: factor out spl_load_fit_image()

2017-01-19 Thread Andre Przywara
At the moment we load two images from a FIT image: the actual U-Boot image and the DTB. Both times we have very similar code to deal with alignment requirement the media we load from imposes upon us. Factor out this code into a new function, which we just call twice. Signed-off-by: Andre Przywara