Re: [U-Boot] [RFC PATCH] USB style patch

2008-11-26 Thread Wolfgang Denk
Dear Michael, In message <[EMAIL PROTECTED]> you wrote: > > - printf(" NOTE: this command is obsolete and will be > phased out\n"); > - printf(" please use 'usb storage' for USB storage > devices information\n\n"); ... > At the end, can I break t

Re: [U-Boot] [RFC PATCH] USB style patch

2008-11-26 Thread michael
Wolfgang Denk wrote: > Dear michael, > > In message <[EMAIL PROTECTED]> you wrote: > - printf(" NOTE: this command is obsolete and will be phased out\n"); - printf(" please use 'usb storage' for USB storage devices information\n\n"); +

Re: [U-Boot] [RFC PATCH] USB style patch

2008-11-26 Thread Wolfgang Denk
Dear michael, In message <[EMAIL PROTECTED]> you wrote: > > >> - printf(" NOTE: this command is obsolete and will be > >> phased out\n"); > >> - printf(" please use 'usb storage' for USB storage devices > >> information\n\n"); > >> + printf(" NOTE: t

Re: [U-Boot] [RFC PATCH] USB style patch

2008-11-26 Thread michael
Hi, Remy Bohmer wrote: > Hello Michael, > > Nice work, but I have a few small comments: > > >> + case USB_PROT_HID_MOUSE: >> + printf("Mouse"); >> + break; >> + default: >> +

Re: [U-Boot] [RFC PATCH] USB style patch

2008-11-26 Thread Remy Bohmer
Hello Michael, Nice work, but I have a few small comments: > + case USB_PROT_HID_MOUSE: > + printf("Mouse"); > + break; > + default: > + printf("reserved"); >

[U-Boot] [RFC PATCH] USB style patch

2008-11-26 Thread Michael Trimarchi
[PATCH] USB style patch Signed-off-by: Michael Trimarchi <[EMAIL PROTECTED]> --- common/cmd_usb.c | 591 - common/usb.c | 40 +++-- include/usb.h| 222 - 3 files changed, 461 insertions(+), 392 deletions(-) diff