Re: [U-Boot] [RFC 2/5] CAN device test command

2009-11-01 Thread Mike Frysinger
On Sunday 01 November 2009 11:24:59 Wolfgang Grandegger wrote: > Note that this is a RFC trying to discuss the real requirements of a CAN > interface in U-Boot. I think it would also be nice to have can_xmit() > and can_recv() with a timeout parameter, e.g.: > > can_xmit(struct can_dev *dev, int

Re: [U-Boot] [RFC 2/5] CAN device test command

2009-11-01 Thread Wolfgang Grandegger
Mike Frysinger wrote: > On Sunday 01 November 2009 06:33:34 Wolfgang Grandegger wrote: >> +if (op == 's') { >> +else if (op == 'i') { >> +else if (op == 'r') { >> +} else if (op == 'x') { >> +} else { > > your if style here is inconsistent, but ignoring that, shouldnt this real

Re: [U-Boot] [RFC 2/5] CAN device test command

2009-11-01 Thread Mike Frysinger
On Sunday 01 November 2009 06:33:34 Wolfgang Grandegger wrote: > + if (op == 's') { > + else if (op == 'i') { > + else if (op == 'r') { > + } else if (op == 'x') { > + } else { your if style here is inconsistent, but ignoring that, shouldnt this really be a switch() ? althoug

[U-Boot] [RFC 2/5] CAN device test command

2009-11-01 Thread Wolfgang Grandegger
From: Wolfgang Grandegger Signed-off-by: Wolfgang Grandegger --- common/Makefile |1 + common/cmd_can.c | 119 ++ 2 files changed, 120 insertions(+), 0 deletions(-) create mode 100644 common/cmd_can.c diff --git a/common/Makefile b/com